Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2669068imm; Fri, 20 Jul 2018 02:48:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdN0urlUjrYoD6m9LvcjjyvOhH0fzCS6D+LfhozSyRQbLU8LRlYSHckH/EK0biHgGHxzNPK X-Received: by 2002:a17:902:9893:: with SMTP id s19-v6mr1424710plp.130.1532080108905; Fri, 20 Jul 2018 02:48:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532080108; cv=none; d=google.com; s=arc-20160816; b=0C9k8przzcd/rPVx1NpTcPRT+UUxGAZAViNQ4/B6lfSlqivuYEMoXXVmNsNABcad/L JhVHXowQDJusTpwDv//0vFKebDJCzGItdt/iJ/lpSlO1x3VJ20zaYBJ5M2bxA1peTzMU QTfh9hdPJVmkx4UJZ598QB1VYnvKspNFYcRlj4YA8iUDQP6t3qCgvw/mb3m21b0nPsT9 NuDW+yZWtmrpYFxacpgIcstzf2GATOUi1cq/n3O2psaE/++WynTYV9K2QhTFbLiXjkh+ ExX1fsHyE8NAhHtDrVjA4nXqBZtW0VNVMT3tyQh4t0k8qkYiQr6WApriBr/aEWiL8Sl+ UFwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=l4y55Yt+UhcZKLnIte/uJp/LMLKAU2E3/7SIa17IvbQ=; b=xZUz5iEoou8aSGwvqnkB5zIYyB6lSxaLpmxO/+5XbFDjAleQIQ+uYeFs4DP1+e6OiL BNdD54JS0+wjzC1xW7spTqfPpAJZHL70jmlvgEb0Dl56iBWHQ2/1A3f0JYR8ta8BNR+6 A5P4VEm7+gMZf9PdaA3MFH63vzUt8k8zwVdAgICBKVkFLYztszNZMS0ovxlqRfq7FyPB HLGiQDVuqs6ZNO0C9LZZADz6O4Y00I/L7qzr3ngvHHOy6W+QXTGRYB2NwGaEzQa25CMg +h/Iz5DIoSeEZzwL/RKBeDbBoiDuNK907jRaPEYw/5FqOvX8pi0B+YuOu5AwcouDgRGy pfGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9-v6si1445158pgg.423.2018.07.20.02.48.14; Fri, 20 Jul 2018 02:48:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbeGTKew (ORCPT + 99 others); Fri, 20 Jul 2018 06:34:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:32776 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727243AbeGTKev (ORCPT ); Fri, 20 Jul 2018 06:34:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 20FBEAD38; Fri, 20 Jul 2018 09:47:23 +0000 (UTC) Subject: Re: [PATCH v3 0/7] kmalloc-reclaimable caches To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Michal Hocko , Johannes Weiner , Christoph Lameter , David Rientjes , Joonsoo Kim , Mel Gorman , Matthew Wilcox , Laura Abbott , Sumit Semwal , Vijayanand Jitta References: <20180718133620.6205-1-vbabka@suse.cz> <20180719195332.GB26595@castle.DHCP.thefacebook.com> From: Vlastimil Babka Openpgp: preference=signencrypt Autocrypt: addr=vbabka@suse.cz; prefer-encrypt=mutual; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSFWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmNvbT7CwZcEEwEKAEECGwMFCwkIBwMFFQoJCAsFFgIDAQAC HgECF4ACGQEWIQSpQNQ0mSwujpkQPVAiT6fnzIKmZAUCWi/zTwUJBbOLuQAKCRAiT6fnzIKm ZIpED/4jRN/6LKZZIT4R2xoou0nJkBGVA3nfb+mUMgi3uwn/zC+o6jjc3ShmP0LQ0cdeuSt/ t2ytstnuARTFVqZT4/IYzZgBsLM8ODFY5vGfPw00tsZMIfFuVPQX3xs0XgLEHw7/1ZCVyJVr mTzYmV3JruwhMdUvIzwoZ/LXjPiEx1MRdUQYHAWwUfsl8lUZeu2QShL3KubR1eH6lUWN2M7t VcokLsnGg4LTajZzZfq2NqCKEQMY3JkAmOu/ooPTrfHCJYMF/5dpi8YF1CkQF/PVbnYbPUuh dRM0m3NzPtn5DdyfFltJ7fobGR039+zoCo6dFF9fPltwcyLlt1gaItfX5yNbOjX3aJSHY2Vc A5T+XAVC2sCwj0lHvgGDz/dTsMM9Ob/6rRJANlJPRWGYk3WVWnbgW8UejCWtn1FkiY/L/4qJ UsqkId8NkkVdVAenCcHQmOGjRQYTpe6Cf4aQ4HGNDeWEm3H8Uq9vmHhXXcPLkxBLRbGDSHyq vUBVaK+dAwAsXn/5PlGxw1cWtur1ep7RDgG3vVQDhIOpAXAg6HULjcbWpBEFaoH720oyGmO5 kV+yHciYO3nPzz/CZJzP5Ki7Q1zqBb/U6gib2at5Ycvews+vTueYO+rOb9sfD8BFTK386LUK uce7E38owtgo/V2GV4LMWqVOy1xtCB6OAUfnGDU2EM7ATQRbGTU1AQgAn0H6UrFiWcovkh6E XVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQLa1PQDUi6j00ChlcR66g9/V0sPIcSutacPKf dKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMhFmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCT sTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sfbAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZO rIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq+aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahK tQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4njQARAQABwsF8BBgBCgAmFiEEqUDUNJksLo6Z ED1QIk+n58yCpmQFAlsZNTUCGwwFCQPCZwAACgkQIk+n58yCpmQ83g/9Frg1sRMdGPn98zV+ O2eC3h0p5f/oxxQ8MhG5znwHoW4JDG2TuxfcQuz7X7Dd5JWscjlw4VFJ2DD+IrDAGLHwPhCr RyfKalnrbYokvbClM9EuU1oUuh7k+Sg5ECNXEsamW9AiWGCaKWNDdHre3Lf4xl+RJWxghOVW RiUdpLA/a3yDvJNVr6rxkDHQ1P24ZZz/VKDyP+6g8aty2aWEU0YFNjI+rqYZb2OppDx6fdma YnLDcIfDFnkVlDmpznnGCyEqLLyMS3GH52AH13zMT9L9QYgT303+r6QQpKBIxAwn8Jg8dAlV OLhgeHXKr+pOQdFf6iu2sXlUR4MkO/5KWM1K0jFR2ug8Pb3aKOhowVMBT64G0TXhQ/kX4tZ2 ZF0QZLUCHU3Cigvbu4AWWVMNDEOGD/4sn9OoHxm6J04jLUHFUpFKDcjab4NRNWoHLsuLGjve Gdbr2RKO2oJ5qZj81K7os0/5vTAA4qHDP2EETAQcunTn6aPlkUnJ8aw6I1Rwyg7/XsU7gQHF IM/cUMuWWm7OUUPtJeR8loxZiZciU7SMvN1/B9ycPMFs/A6EEzyG+2zKryWry8k7G/pcPrFx O2PkDPy3YmN1RfpIX2HEmnCEFTTCsKgYORangFu/qOcXvM83N+2viXxG4mjLAMiIml1o2lKV cqmP8roqufIAj+Ohhzs= Message-ID: <8ed44a53-fa20-a7ff-c662-72de9a9fd9e4@suse.cz> Date: Fri, 20 Jul 2018 11:45:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180719195332.GB26595@castle.DHCP.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2018 09:53 PM, Roman Gushchin wrote: >> Vlastimil > Overall the patchset looks solid to me. > Please, feel free to add > Acked-by: Roman Gushchin Thanks! > Two small nits: > 1) The last patch is unrelated to the main idea, > and can potentially cause ABI breakage. Yes, that's why it's last. > I'd separate it from the rest of the patchset. It's not independent though because there would be conflicts. It has to be decided if it goes before of after the rest. Putting it last in the series makes the order clear and makes it possible to revert it in case it does break any users, without disrupting the rest of the series. > 2) It's actually re-opening the security issue for SLOB > users. Is the memory overhead really big enough to > justify that? I assume that anyone choosing SLOB has a tiny embedded device which runs only pre-flashed code, so that's less of an issue. If somebody can trigger the issue remotely, there are likely also other ways to exhaust the limited memory there? > Thanks!