Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2744932imm;
        Fri, 20 Jul 2018 04:17:05 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpcb/jB7UUCuh1f4UP/4SjvH3q8o1t7IbXFH2rjaiL2HiuDakLbeAhumP/V65SMTHs7um479
X-Received: by 2002:a62:d10b:: with SMTP id z11-v6mr1739859pfg.255.1532085425843;
        Fri, 20 Jul 2018 04:17:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1532085425; cv=none;
        d=google.com; s=arc-20160816;
        b=iIfEoCPzMo8ph00OHEJJI6DZc9iXQmkKq02rFLhdykaiCbfolhIf0/wx8hKl+GC6ch
         ASt5eHctVg+97Xkeau0lklzxL9K1QNL41sE4BqjQSO8sMUZvYdIoSyWFARSBmc4No0+T
         SbxK4A8T+WDBVfgDPWfMCDX876JTcnQMMwE08e1VFu+oVTcZxLrrFs+jH+NtNnmmXYzG
         cL/gp6+i/QJKBrIYyvh+20KECt0aRIFG+cj0QszyXmrcCUZsS+12AZ0lPCf5y0AVT+Q8
         dFQXcIW4Je06VwRo4rLvSoYqALwoAqTN9WY+ZMg4pDy5nv+pCeS3Ylzv0N9Bg7sVkMCg
         7ZBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=pQ/3ctgOsyAWdlj7S0v8mcBSpwvjw6eVgcXgbJtvu24=;
        b=ZOZDFhPpPT+6+tjBgzPL8FsB914xzCx9FIBg7QhRnbz7rzmBKIHueKmizSasTJOa3C
         H5PeAVopD2iS5VjTXnsEX7yDI746Qi6Y2x2f1Bhu3r1dR2x9MZ9eC/VokBhow0pZitq6
         6EOjDivyC5yisTLq8E7zcwQWXuCFQsA5eeL8kYHoNrnRrrNGdH8Ta+hcngwdS9rZAcDc
         zDGBMKWQb4wzh2c4Y92MDElQbhIs2DzdrWyiRUZNSocaK+NniB6Eyej/7Fkz8L6vh4mK
         bMHiGlDrGcudU1xYZLAyvcdtwqoCRelcnWNdI21I5ajwv7QAUcWH6aR5s75IgQVCa/JU
         3rWg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z63-v6si1631090pfi.214.2018.07.20.04.16.51;
        Fri, 20 Jul 2018 04:17:05 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730798AbeGTMD4 (ORCPT <rfc822;hubert.jasudowicz@gmail.com>
        + 99 others); Fri, 20 Jul 2018 08:03:56 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:15142 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727361AbeGTMDz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Jul 2018 08:03:55 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b51c4710000>; Fri, 20 Jul 2018 04:16:01 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Fri, 20 Jul 2018 04:16:06 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Fri, 20 Jul 2018 04:16:06 -0700
Received: from [10.21.132.122] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 20 Jul
 2018 11:16:06 +0000
Subject: Re: [PATCH v3 5/7] dt-bindings: Add Tegra PMC pad configuration
 bindings
To:     Aapo Vienamo <avienamo@nvidia.com>, Rob Herring <robh@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
CC:     Mark Rutland <mark.rutland@arm.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1531396813-6581-1-git-send-email-avienamo@nvidia.com>
 <1531396813-6581-6-git-send-email-avienamo@nvidia.com>
 <20180716154309.GA16477@rob-hp-laptop>
 <20180717152318.3608e3f9@dhcp-10-21-25-168>
 <CAL_JsqL1F0RF_6=ho0pa7Uh4AUsyvFRDGM50gN4=6_+MwBfGYQ@mail.gmail.com>
 <20180717183020.5ab9bfa6@dhcp-10-21-25-168>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <cb67ced4-eef8-abb5-5706-3282a55edbb2@nvidia.com>
Date:   Fri, 20 Jul 2018 12:16:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180717183020.5ab9bfa6@dhcp-10-21-25-168>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Adding Linus ...

On 17/07/18 16:30, Aapo Vienamo wrote:

...

>>>>> +Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt.
>>>>> +
>>>>> +The values accepted by power-source property are
>>>>> +TEGRA_IO_PAD_VOLTAGE_1V8 and TEGRA_IO_PAD_VOLTAGE_3V3, which are defined
>>>>> +in dt-bindings/pinctrl/pinctrl-tegra-io-pad.h.  
>>>>
>>>> You need to list out what properties the child nodes can have.
>>>>
>>>> power-source needs a vendor prefix.  
>>>
>>> Isn't it a generic pinctrl property?  
>>
>> I don't know offhand. Doesn't look like it if you have custom values.
> 
> It's listed under "Supported generic properties" in
> pinctrl-bindings.txt. The convention seems to be not to add a vendor
> prefix even though such custom macro values are used. The property is
> currently used by qcom,pmic-gpio, qcom,pmic-mpp, and renesas,pfc-pinctrl.
> I could not find a bindings document describing it with a vendor prefix.
Looking at other users of the 'power-source' property it is not clear to
me if the values should/can be vendor specific or not. I see cases where
some people use definitions and others use actual voltages. 

Linus, any recommendations here?

Cheers
Jon	

-- 
nvpublic