Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2991873imm; Fri, 20 Jul 2018 08:18:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfxkjT9zf2szmm1ZYOQujqqCgWzvb1T7LNGm1MnAu8gQcQLHcicpbzJk98l2Qds3AnKQJHc X-Received: by 2002:a63:9619:: with SMTP id c25-v6mr2458096pge.75.1532099908184; Fri, 20 Jul 2018 08:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532099908; cv=none; d=google.com; s=arc-20160816; b=OQa+IeT+PK3K7/sJj30C7uEDovB0QPPA+zZcZuzoaDWKIgtNosZj1o8fiSlkSY7yjS v9F6tkvbdrH/8qSHCfYw6GothGX5kOGEJwL5so4HYNk7ndu1CkkIK1zzaXZcvV2lQcsw NjqdysqKEOqC5CV8DwwspQv4eq0prnhhUpwsLl6PAhucEqPnWtRYCfx1DL467Sz/L0Gf jM9WfqedSW61NPK9GS2Pjps51HlMjlO4TIYzVwBX9xWr0X/x+aHFK/vRgM/lxGvHMHS6 SODa8SvsfoDTw5mDD0kKvBqx5FBESq8ng1FyD0/u+KRSiGgKNfc+lVWWPfSe2XTCo09v 1Bcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=jThYYX2IH0KwIXB57etzRK6Vtwf2g96Tobz7XGb6Rn8=; b=mJBSATyYEztI/3orqlcHnDP6P1lfUMsVFCRghVvTQ5ZT+Jayd5oZ/PZFkBcHY+kNoL HmgXrOMSQcV9oW/HZlRp59B9nz7KVjfcO18F7AE3SLHizY87sxYU5GrbaHfP27OQtDV1 kVKo5iK2qEXiLlovVDUfnFsE5p9fBmZTL35//RkvNyCOTE5EUry8jNDDdLM0eXepgOdT lD0g77NMrrZtMpIKEKI+3uLuEe9vrwheFvelXEGIrXDsezrSkpi4ZMLNVBchcBj8CGS8 sw8D7unVsMbvLZP+4g6dXcXWhupyetU5x8sISxSGOkre++t0msE50MBXoX9J1Df6S5Zv JknA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2-v6si2115569pff.192.2018.07.20.08.18.13; Fri, 20 Jul 2018 08:18:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388134AbeGTQEs (ORCPT + 99 others); Fri, 20 Jul 2018 12:04:48 -0400 Received: from mail.bootlin.com ([62.4.15.54]:54571 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388103AbeGTQEr (ORCPT ); Fri, 20 Jul 2018 12:04:47 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 42A0C209B9; Fri, 20 Jul 2018 17:16:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122]) by mail.bootlin.com (Postfix) with ESMTPSA id 9C4B2209BD; Fri, 20 Jul 2018 17:15:44 +0200 (CEST) From: Miquel Raynal To: Wenyou Yang , Josh Wu , Tudor Ambarus , Boris Brezillon , Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: [PATCH v4 28/35] mtd: rawnand: allow exiting immediately nand_scan_ident() Date: Fri, 20 Jul 2018 17:15:20 +0200 Message-Id: <20180720151527.16038-29-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180720151527.16038-1-miquel.raynal@bootlin.com> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some driver (eg. docg4) will need to handle themselves the identification phase. As part of the migration to use nand_scan() everywhere (which will unconditionnaly call nand_scan_ident()), we add a condition at the start of nand_scan_ident() to just "do nothing" if the maxchips parameters is zero, meaning that the driver does not want the core to handle this phase. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/nand_base.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index dea41fa25be1..e7f135c100c2 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -5926,7 +5926,7 @@ static int nand_dt_init(struct nand_chip *chip) /** * nand_scan_ident - [NAND Interface] Scan for the NAND device * @mtd: MTD device structure - * @maxchips: number of chips to scan for + * @maxchips: number of chips to scan for, returns immediately if 0 * @table: alternative NAND ID table * * This is the first phase of the normal nand_scan() function. It reads the @@ -5940,6 +5940,14 @@ int nand_scan_ident(struct mtd_info *mtd, int maxchips, struct nand_chip *chip = mtd_to_nand(mtd); int ret; + /* + * If the number of chips to scan for is null, just return silently. + * This is for specific drivers that must handle this part of the + * probe process themselves (e.g docg4). + */ + if (!maxchips) + return 0; + /* Enforce the right timings for reset/detection */ onfi_fill_data_interface(chip, NAND_SDR_IFACE, 0); -- 2.14.1