Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3124609imm; Fri, 20 Jul 2018 10:32:45 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcb5TtSrEfNv8obCmZf2IfDQT3pEdEHYwB7VefkpDeknRJ1q4NizCxz3YzdTem8aDWBKQWW X-Received: by 2002:a63:c114:: with SMTP id w20-v6mr2907361pgf.234.1532107965652; Fri, 20 Jul 2018 10:32:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532107965; cv=none; d=google.com; s=arc-20160816; b=spXGQTEz3x+mv4txizlQDIZa9vBdcchzqeo5Q/KP5VKqbIFavykJT8QtkbrGCzxpfP XjTvj36RCQUWSQdS/YE//Y6MAKMT7QfjynMEEMZKAi98XqslDEAxYx0/sNkUHfz5kdJQ KF0l35ns9jbxfhfO16gMXTwHxnrPlP9qN5R61Xd7nyrUxWIJUjsiTafSuAtUyIfMrkQ4 QG4EJVAv6zWKxYfndTvTYqMzrbXJEc7UT/wk9MtWtDuzOTmlI23njsNF3z1I4QyYnE3r Uu6sCqkq9qMrcM/yprlwu1+O2A6SG6Yek1yvUn2nAM/mlhrbvK8aaS23T+V7HUzOEmLf FQvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=tIBy/BCBMV/hLlng9LYFlWWMgWQWfEQ5Tu1d3ZnqtDA=; b=0LX1MMJFg6oec+xFVJRuLQ2onTUGdsMREIemXzCs3KZ+KFOCnNc31NmTbzdebQ8P8M IZG0Px4l0mTqHPtLl1MXQ/tJtA+PXn8tpUVgiaUuFUc5gAPcXVeJkfs9NK8cbd4Srd4d KLJadlBa1B5QDh21AUzStqB8BJxlWOWmdHEvQmqib1zx4ObRNtKxHb8TdUIBHA7NmJHg lImnvOVJECWOV1CijyZA2lqyn/vFVIOLos2/5bt2AWT6yULH5lR5m0gwUFjsyaOrMw1Q xpncurPZoMEfzg1bapP1sUKwTHumk314tHCErQiLJgtVvemeiSP6D3DbhEmyewy1nOO9 FjQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k11-v6si2228204pgi.328.2018.07.20.10.32.30; Fri, 20 Jul 2018 10:32:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388118AbeGTSTk (ORCPT + 99 others); Fri, 20 Jul 2018 14:19:40 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:39982 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387868AbeGTSTj (ORCPT ); Fri, 20 Jul 2018 14:19:39 -0400 Received: from linux-r8p5.suse.de (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Fri, 20 Jul 2018 11:30:19 -0600 From: Davidlohr Bueso To: akpm@linux-foundation.org Cc: jbaron@akamai.com, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, dave@stgolabs.net Subject: [PATCH -next 0/2] fs/epoll: loosen irq safety when possible Date: Fri, 20 Jul 2018 10:29:54 -0700 Message-Id: <20180720172956.2883-1-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Both patches replace saving+restoring interrupts when taking the ep->lock (now the waitqueue lock), with just disabling local irqs. This shows immediate performance benefits in patch 1 for an epoll workload running on Xen. The main concern we need to have with this sort of changes in epoll is the ep_poll_callback() which is passed to the wait queue wakeup and is done very often under irq context, this patch does not touch this call. Patches have been tested pretty heavily with the customer workload, microbenchmarks, ltp testcases and two high level workloads that use epoll under the hood: nginx and libevent benchmarks. Details are in the individual patches. Applies on top of mmotd. Thanks! Davidlohr Bueso (2): fs/epoll: loosen irq safety in ep_scan_ready_list() fs/epoll: loosen irq safety in epoll_insert() and epoll_remove() fs/eventpoll.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) -- 2.16.4