Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3339062imm; Fri, 20 Jul 2018 14:53:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeLAYdtt8kQBymOUXpqzXxxZpc2B8gNqjsC1BmUXFRYrLPJinjc39g1ebZk1KcC7jA0wQLl X-Received: by 2002:a63:d613:: with SMTP id q19-v6mr3510880pgg.327.1532123597871; Fri, 20 Jul 2018 14:53:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532123597; cv=none; d=google.com; s=arc-20160816; b=oY2gOWWMX757dUVQ6aJZ5d4D9igbFISmwNHhRZxcgCmCg48gsZ6COfDIMb5Wp1Getc lwJMu7XbiplT5v+mD9Yvm7tGPMmdKVQoEMwS9w9g79ZhGB6bOjtceBgCEO6cYPn/eFJh oZ4nKcTXK910e63OjrW1UXUvZAgYNBV0lpzgxOuosEiaFj/AbT5oqo9+rnrCocjs+x9s c2tznctxrfG4A9g+hTUyhlcvaBPHe8/KqDUd127EcHKKin+54Y1zdaIVpDBe+E+XLtY8 n9D1lNH063rSYPsSPgZjAi0fNfBgYr216WFQdmaP4+v3/cC8tG5NtMHN6EePUm/xPj5k 6noA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=jdVB9V71YWRr+QxMiwZZC0zUNCIfHMfic+gGLuQ0KIk=; b=qKm8K1o5/KsCeXXIIpeopO/ww8VydROlWKXti5yyQ2aOz65WYy0VKAnXRwCDWPIQ77 ETezcyWibxL8sIaOqCt5agCkKTfnpLz9L59z0OZmZNNPf2ULKuNNsvegCdZWXzVigIKR z+FXxyNwuHOxOgCcLfITPomrg5foMXSDZTJb5XFzgtOk0VsgUzKHnvvhWrP/Kqtg/vLb JoGj1YkVFMxFnEFOW5PKLy5evWb12RFRMPKVbrDMNiiCsuj0HVyjbRYNFU3SjTtBOZvt 5sg4mgRlFHnbovX0YaYSEj4IqH5NJN+DSQG3e1lxr8+TD3SuUZeha2mOFDioSGVfuL8W moLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id az7-v6si2404253plb.267.2018.07.20.14.53.03; Fri, 20 Jul 2018 14:53:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730177AbeGTWmL (ORCPT + 99 others); Fri, 20 Jul 2018 18:42:11 -0400 Received: from avasout06.plus.net ([212.159.14.18]:48150 "EHLO avasout06.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729966AbeGTWmK (ORCPT ); Fri, 20 Jul 2018 18:42:10 -0400 Received: from hairyalien ([80.229.148.18]) by smtp with SMTP id gdJffIgOiWLW2gdJgf5XFC; Fri, 20 Jul 2018 22:52:01 +0100 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.3 cv=fJUXI6Se c=1 sm=1 tr=0 a=o7Djd4SkmPXITDn8qH+ssQ==:117 a=o7Djd4SkmPXITDn8qH+ssQ==:17 a=R9QF1RCXAYgA:10 a=V0UhwjhiAAAA:8 a=VP-kpNrJ8D7Mw6TV3z8A:9 a=biiqoiEWpCWGFnDq:21 a=PkcNIt57vdPO81cB:21 a=_UVLBGXn8Au_dgoMdIS7:22 Received: by hairyalien (sSMTP sendmail emulation); Fri, 20 Jul 2018 22:51:59 +0100 From: Nick Dyer To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Chris Healy , Nikita Yushchenko , Lucas Stach , Nick Dyer Subject: [PATCH v1 04/10] Input: atmel_mxt_ts - remove unnecessary debug on ENOMEM Date: Fri, 20 Jul 2018 22:51:16 +0100 Message-Id: <20180720215122.23558-4-nick@shmanahar.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180720215122.23558-1-nick@shmanahar.org> References: <20180720215122.23558-1-nick@shmanahar.org> X-CMAE-Envelope: MS4wfBA5dMsXA9VkdUdHS5scszU3hw7sui8xLLBYia4n/j0TuTkYpjXSNd03eyXeJNQBIJP+0N2Zmch7+QMThL/j3PAjszNX5zm8cZgT+jDMGHZ2gLBaLwdH UQIDXgmjPZ9KfS60x9X6jWLDGQqwV0r6dsHBbXb45nXO9CWB1uC0nO3w Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Dyer Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index dcafb812ee7e..92661aa910ae 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -1520,10 +1520,8 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *cfg) MXT_INFO_CHECKSUM_SIZE; config_mem_size = data->mem_size - cfg_start_ofs; config_mem = kzalloc(config_mem_size, GFP_KERNEL); - if (!config_mem) { - dev_err(dev, "Failed to allocate memory\n"); + if (!config_mem) return -ENOMEM; - } ret = mxt_prepare_cfg_mem(data, cfg, data_pos, cfg_start_ofs, config_mem, config_mem_size); @@ -1982,10 +1980,8 @@ static int mxt_initialize_input_device(struct mxt_data *data) /* Register input device */ input_dev = input_allocate_device(); - if (!input_dev) { - dev_err(dev, "Failed to allocate memory\n"); + if (!input_dev) return -ENOMEM; - } input_dev->name = "Atmel maXTouch Touchscreen"; input_dev->phys = data->phys; -- 2.17.1