Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3339150imm; Fri, 20 Jul 2018 14:53:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpepLXCfO2d2m0lGpP628OFlDvV59yZNH26gYggIyW7yz3qQAFKkAfMvZ7PMitLCHA2jFW3U X-Received: by 2002:a63:f002:: with SMTP id k2-v6mr3510656pgh.8.1532123605151; Fri, 20 Jul 2018 14:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532123605; cv=none; d=google.com; s=arc-20160816; b=0ezHWaNWQC/w5QFKh6MGIJgRiZvooNZOIRX+LMes4Ta8VVQftAst7SnpN2Ppeu593m kY+JIEM10mTdYMbLk4m7oEc1iRl+jR7g3wHN6NUDqX0Y3R1SviqN+qLceW/5LC24SrjR KtRTxs4mYw1bl3N13MILzNiH0jo7M3UJeTA/+1Z5zMDT0ujJN4Dyv+hdbN+xZqWQMiSr 5yHkg328DPIn+uFV3sThK67RA2tMRRkoeTWgaaUz2KPsfXodN5dTANDgQPkHdqYrllQV h/YiCPctZi+luJOfENSV9oEueCKOQ3AA5rIebYCvC4+nbLauScfYpMqTLeJiyglmxi9B KU+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=KRdx9DBXdI5dRxNHrDLxj+94MNHcRnlSqSGMH0znDiU=; b=C8o9w5ycQprlUUo1rc41SvQnv3KDe/8k03oSahDHOiKdG/YXK72s2oMEQJcy3rvYS2 QnrWi1dMu6S/8oD780BLTP6MGxlxAc8KKDgw00LX3F3P5oQl2uZcnVDu1Aps/1utRo94 +zmQOEjv0eOncccm+p9c7ryNyf18l6kqsuATeAe84thMFsoSJQYiDZSIjFaAmRccfgPg f+XqDB3jt5MkWYT64r1MAny/TzA89CMgO1xByMkfOMA+NS23lsI7+qJJHoXGmytkbQ9m K3VHEs3KjvKlc/ONEZgcul/IQ5yBmF5UELZ8pIBXLgtDBDLZZu3ROXPZDfNWOCnqrH76 3fIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3-v6si2757493pgl.579.2018.07.20.14.53.10; Fri, 20 Jul 2018 14:53:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731692AbeGTWmX (ORCPT + 99 others); Fri, 20 Jul 2018 18:42:23 -0400 Received: from avasout06.plus.net ([212.159.14.18]:48149 "EHLO avasout06.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731402AbeGTWmW (ORCPT ); Fri, 20 Jul 2018 18:42:22 -0400 Received: from hairyalien ([80.229.148.18]) by smtp with SMTP id gdJrfIgPWWLW2gdJsf5XFx; Fri, 20 Jul 2018 22:52:13 +0100 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.3 cv=fJUXI6Se c=1 sm=1 tr=0 a=o7Djd4SkmPXITDn8qH+ssQ==:117 a=o7Djd4SkmPXITDn8qH+ssQ==:17 a=R9QF1RCXAYgA:10 a=V0UhwjhiAAAA:8 a=xGj3VbYo4tSy6rsc-G8A:9 a=2yqr0foQS1KSvOaB:21 a=1eU8UPaeLwi3yF78:21 a=_UVLBGXn8Au_dgoMdIS7:22 Received: by hairyalien (sSMTP sendmail emulation); Fri, 20 Jul 2018 22:52:11 +0100 From: Nick Dyer To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Chris Healy , Nikita Yushchenko , Lucas Stach , Nick Dyer Subject: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed Date: Fri, 20 Jul 2018 22:51:21 +0100 Message-Id: <20180720215122.23558-9-nick@shmanahar.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180720215122.23558-1-nick@shmanahar.org> References: <20180720215122.23558-1-nick@shmanahar.org> X-CMAE-Envelope: MS4wfMZA/UAmca2sz579MWtfQxoyq7nP9de9tx0V7vdYQlC2odWcjtVlDBjyNdIubuJlX0USZJeOWnxhzOFHD+ypIBpCfW3MmQBJyh1a30dJODUrOz+BgZyc es5hQWnNTfkNQtFd6hp0+9yX82yTMH0XgSaqxFSnR/jjEEGOg0vjGghUC4y8Wv/mXCy5O5f8MGFENQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Dyer input_mt_report_slot_state() ignores the tool when the slot is closed. Remove the tool type from these function calls, which has caused a bit of confusion. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index d7023d261458..c31af790ef84 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -838,8 +838,7 @@ static void mxt_proc_t9_message(struct mxt_data *data, u8 *message) * have happened. */ if (status & MXT_T9_RELEASE) { - input_mt_report_slot_state(input_dev, - MT_TOOL_FINGER, 0); + input_mt_report_slot_state(input_dev, 0, 0); mxt_input_sync(data); } @@ -855,7 +854,7 @@ static void mxt_proc_t9_message(struct mxt_data *data, u8 *message) input_report_abs(input_dev, ABS_MT_TOUCH_MAJOR, area); } else { /* Touch no longer active, close out slot */ - input_mt_report_slot_state(input_dev, MT_TOOL_FINGER, 0); + input_mt_report_slot_state(input_dev, 0, 0); } data->update_input = true; -- 2.17.1