Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3692811imm; Sat, 21 Jul 2018 00:48:21 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeI2k0YDZ6bgMhvvbU6sQDtMR+ypuLFjNUiCR662OFrzjuScK6ITOq1fy4xs7FWuOi/b8VH X-Received: by 2002:a63:4811:: with SMTP id v17-v6mr4692406pga.379.1532159301371; Sat, 21 Jul 2018 00:48:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532159301; cv=none; d=google.com; s=arc-20160816; b=yRXzkKeLgTOVTfb4uXB1YiAhntmMjx0kxGbsCZWcaNZn1Y7Z+7bO/h1pfOZURm4Hbs XLi5lLaVQMmbE7V0pA+FopqbmNvgodqi5k73uR3U0gPuH2mteklNLusJu0RxSuVfSUnP iAb9Jt0hFJrlyCMlw/1S/Ea2zfZ35/0Ahyu3bMmYc0B0IqwWX2oxox2CctrNWvGGzfz+ SyC66BeD/1Pc9tF56MNkGJSHtKmIuVIgRJGUBnHpGRsN/OxYaL0dNK6vLUBRpENQq/O2 jEIwPH3VcMrrFORJl5F7vf9FNBymzezQwAZSyiNZB4P/kBB2Va5jkewn70LmU/aFpuS0 0GtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=7WD6mzM8/iIZYxkanfkRHujf69UEXJxCfdYMNpRyCJk=; b=wnfbwCxA1BLJzewrlx3ydYYAKzFH5mxhoGV7d7SQUlXCLlU1EzW9ipp+u/QTMbmq5X AwkL5DLUoUgSLq24ApkkvzG63/dSmge02FcXbjdJfGvQx13/VjAW6fppILrhDH+wocvh SNjStOXZ3Y9dzvXbRvvQbdp39Q/6EFnydJuJaJdV/N+45FcYnKE4pEc7P1edYEKDRG2x O2lhttIIjqGcDcCw7Li9JNGtdRZfVcDuw72TFFuNBYnoi17D+yzlToosTZC9DXpJeZ0l XTkxBZWOZ9a3HhXGRj7RDOZapaOgCG/wpGsn55UJWb5JczoCGHjlYi/RBh/7rjuvjI9I FMig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m192-v6si3533515pga.398.2018.07.21.00.48.06; Sat, 21 Jul 2018 00:48:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727755AbeGUIiB (ORCPT + 99 others); Sat, 21 Jul 2018 04:38:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48660 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbeGUIiB (ORCPT ); Sat, 21 Jul 2018 04:38:01 -0400 Received: from localhost (LFbn-1-12238-233.w90-92.abo.wanadoo.fr [90.92.53.233]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 893A4AEF; Sat, 21 Jul 2018 07:46:13 +0000 (UTC) Date: Sat, 21 Jul 2018 09:46:11 +0200 From: Greg KH To: rkir@google.com Cc: linux-kernel@vger.kernel.org, tkjos@google.com Subject: Re: [PATCH 3/3] tty: Mark goldfish_tty_line_count as const Message-ID: <20180721074611.GC6484@kroah.com> References: <20180718001455.140575-1-rkir@google.com> <20180718001455.140575-3-rkir@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180718001455.140575-3-rkir@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2018 at 05:14:55PM -0700, rkir@google.com wrote: > From: Roman Kiryanov > > The driver never mutates this variable - no benefits of > keeping it mutable. Then why not just make it a #define? No need to waste the memory of a variable, right? thanks, greg k-h