Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 21 Jul 2018 19:21:16 +0100
From:   Al Viro <viro@ZenIV.linux.org.uk>
To:     Sean Fu <fxinrong@gmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/buffer.c: Optimize grow_buffer function.
Message-ID: <20180721182116.GC30522@ZenIV.linux.org.uk>
References: <1532194217-19002-1-git-send-email-fxinrong@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1532194217-19002-1-git-send-email-fxinrong@gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jul 22, 2018 at 01:30:17AM +0800, Sean Fu wrote:
> Use PAGE_SHIFT and i_blkbits of bd_inode directly to avoid ugly sizebits
> calculation.
> Remove ugly sizebits calculation.
> Remove unnecessary sizebits parameter of grow_dev_page.
> 
> Reduces code size:
> 
> Before:
> 
> sean@linux-zmni:~/sda5/source/linus_repo/linux> size fs/buffer.o
>    text	   data	    bss	    dec	    hex	filename
>   34037	   1510	     16	  35563	   8aeb	fs/buffer.o
> 
> After:
> 
> sean@linux-zmni:~/sda5/source/linus_repo/linux> size fs/buffer.o
>    text	   data	    bss	    dec	    hex	filename
>   34021	   1510	     16	  35547	   8adb	fs/buffer.o

First of all, 16 bytes is pretty much noise.  What's more, the "remove ugly
sizebits calculation" part really needs an explanation of the reasons why
it's safe.  You assume that size == 1<<bdev->bd_inode->i_blkbits; where's
the proof that it always holds?