Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4224815imm; Sat, 21 Jul 2018 13:18:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdZYVfXHzockKN4E8xZdwS3dEqZP3xLeTF4l8BmAD3Tvtit9YpXuQGiryE2OP/2F4Ac5x/9 X-Received: by 2002:a62:d693:: with SMTP id a19-v6mr7084786pfl.248.1532204323358; Sat, 21 Jul 2018 13:18:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532204323; cv=none; d=google.com; s=arc-20160816; b=hU/dfVHv9gMqXNTVzHqlslcO7ME4vuYXBNZOoSSRAraOct8KObWWoLrvsmAgkGOfuh WZGIFVFGDcfAf5V1ojXfpKVEAD19bKF8Wr1dy3qs/Uw6SPUrzx5mItcv2Kp0fjovZdpU 2uWhof6slmVT92VNtjboiCbPZIGEHoYVS0MiRHvs6exHWgjxA/r71DUXx9oskA1nxw0q /yCLguYyk7iMsOrI5zW16TgFwwfHQsR8E2A0qIdKLZO5K4T3Fweebk8Vll0pEGd2mMga GjMGTqkQQ2MyDQxNA7Zfy7ruWNdGQ1EYN9XoU6zTKxa0Idy4NbfzjdzWcCDaBwvot4/9 IhTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=vRaj/2RLs74uPxhO/TC7tWMoih0nwTmZ15/V8EujcZs=; b=Brq11KSPapKvF3Hn1wdbbjmXqHCde4CcyFyQPy+dth43l2twJQ8kh/aN2MTrASqSXa A5YYTJjscBkwrNb8W5/+ES5J/tWdaPdyqUC9Gb1J8Iv3QR7ndvv8n6fDnB8gGpfLA4Q3 8MiBQzGnUIgZIduqKrkBhuMRrz3KC1hKsiq9szZ7ly5Agu8FKvdBSVdin4EeqK85XlpY w4wyfeg7sOGpgsYrfR8aHIAtjBhEcpliPgNdH+IFxhy7rayjv9u6QpQqPkHuMEeQC1AC 9VfwaLA4JZqZ4HrG/pfuTbwiwAm9rPdKsAgfXcNDrz4BsGF0LpnTh3eXkW/JDJ0shZak FF1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=KWhKa8oQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v24-v6si4267268plo.159.2018.07.21.13.18.29; Sat, 21 Jul 2018 13:18:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=KWhKa8oQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728174AbeGUVLe (ORCPT + 99 others); Sat, 21 Jul 2018 17:11:34 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:35342 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbeGUVLe (ORCPT ); Sat, 21 Jul 2018 17:11:34 -0400 Received: by mail-oi0-f65.google.com with SMTP id i12-v6so27071897oik.2; Sat, 21 Jul 2018 13:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vRaj/2RLs74uPxhO/TC7tWMoih0nwTmZ15/V8EujcZs=; b=KWhKa8oQ4qzH9Y56eUUNSA1SaRNbv4apo3HzgrNpKWOWsMS3PH2UgwaaVsP0QtuNJq WbgQY3rq2ijhFoosyy+jGudx2gJEQDrZCW3EsaYC9UGFhPAxoNIVebT3AEwgJmUG1gQQ hX7lWFNL0o6Qlz8BzyEdiH6RopMS+ma1xI76I6CjvGTJQsn7JXvap8KmHEXmh0JcZlAo jAeq8ldtL6RJRzrCH1LKViPoT2kPNobf0yPogwEMir6x1mk0hfOMBENfoAasRAygI8ib KpXzySn9QFcv77ZJIUG7aXkV7H7YykiwtnCxOeTdk4XELxnbtBMDBSAa7KJtg7N0MRia 8fdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vRaj/2RLs74uPxhO/TC7tWMoih0nwTmZ15/V8EujcZs=; b=JJoR/OogXgoAfUuZ/oVNt7v+nZ8Q8GzDQQdYWnNu4klXosMlHuFljuAPwZ1UPRAz9y Ut/1sXvwayJxYHUnGUrgYrT588tamHTWv9E7BY4xfIS/iZNXwrmUrRuRTx342ttyIgmr /gGCSOh0DcXCKSBUkacwoP1FU08QPsNn2sPv/Yt299bjOqmeJmaYTH17dRuGrlLuBV31 BbVfMctvRz5IAQ3OhmEEDtdFElpDPtHoe6twuZbHadGEphkeUDi8E2REq2l+lpcCd/gC v91eGaRez5b8hRwQjktN97ZUxgXuY35Cu8iGqmZAAow0/UIzxnPnTkI8xYGOCF9PPfUs w8VA== X-Gm-Message-State: AOUpUlEbW4kqmn3f2veC5rskTL6l7FWSDB5i+Zc3DVecuXSQnV+wQwZm B54dHOBRNWk3xYN2UZZtsWTDx1sY7oaBubWUzbnDTQ== X-Received: by 2002:aca:5b0b:: with SMTP id p11-v6mr3270836oib.116.1532204256473; Sat, 21 Jul 2018 13:17:36 -0700 (PDT) MIME-Version: 1.0 References: <20180717095617.12240-1-jbrunet@baylibre.com> In-Reply-To: <20180717095617.12240-1-jbrunet@baylibre.com> From: Martin Blumenstingl Date: Sat, 21 Jul 2018 22:17:25 +0200 Message-ID: Subject: Re: [PATCH 0/3] clk: meson: clk-pll driver update To: jbrunet@baylibre.com Cc: Neil Armstrong , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jerome, On Tue, Jul 17, 2018 at 11:56 AM Jerome Brunet wrote: > > This patchset is yet another round of update to the amlogic pll driver. > > 1) Enable bit is added so we don't rely on the bootloader or the init > value to enable to pll device. > 2) OD post dividers are removed from the pll driver. This simplify the > driver and let us provide the clocks which exist between those > dividera. Some device are actually using these clocks. > 3) The rates hard coded in parameter tables are remove. Instead, we > only rely on the parent rate and the parameters to calculate the > output rate, which is a lot better. > > This series has been tested on the gxl libretech cc and axg s400. > I did not test it on meson8b yet. I had some comments on patch #2 once that is fixed I can help testing on Meson8b (if you give me a few days...) Regards Martin