Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 21 Jul 2018 16:21:51 -0700 (PDT)
Message-Id: <20180721.162151.2056706808480433302.davem@davemloft.net>
To:     daniel@iogearbox.net
Cc:     kafai@fb.com, yuehaibing@huawei.com, ast@kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function
 argument types
From:   David Miller <davem@davemloft.net>
In-Reply-To: <9c9f981b-7d1e-1bb2-6771-727fc762c7c5@iogearbox.net>
References: <20180719075659.9800-1-yuehaibing@huawei.com>
        <20180719154817.ycwupljsx4ghkhom@kafai-mbp.dhcp.thefacebook.com>
        <9c9f981b-7d1e-1bb2-6771-727fc762c7c5@iogearbox.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Daniel Borkmann <daniel@iogearbox.net>
Date: Thu, 19 Jul 2018 17:51:41 +0200

> On 07/19/2018 05:48 PM, Martin KaFai Lau wrote:
>> On Thu, Jul 19, 2018 at 03:56:59PM +0800, YueHaibing wrote:
>>> Fix following warning:
>>> net/ipv4/bpfilter/sockopt.c:28:5: error: symbol 'bpfilter_ip_set_sockopt' redeclared with different type
>>> net/ipv4/bpfilter/sockopt.c:34:5: error: symbol 'bpfilter_ip_get_sockopt' redeclared with different type
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> LGTM.  Missing a Fixes tag though.
>> 
>> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
>> Acked-by: Martin KaFai Lau <kafai@fb.com>
> 
> (Should go to -net tree.)
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Applied.