Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5180189imm; Sun, 22 Jul 2018 15:25:12 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdyMd1n508+Ljq1kWfgB3/ZppzWqWn+zOHSuwN6d331E3uMvMIsrHDi1x1skJxwpZhofZau X-Received: by 2002:a63:f18:: with SMTP id e24-v6mr9973619pgl.320.1532298312210; Sun, 22 Jul 2018 15:25:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532298312; cv=none; d=google.com; s=arc-20160816; b=ImoJCKdh27hfd+3jg9tCR9kNN4pfWacWtgNwHtG6b7LboyqFVquCq4qvD2ILhuv2wn GOGWSglsOJthAzT2G9MBxuPJo7IKFCj8gULqldoMULlV47FnoWXoD7IAtXEWZ0ZMpH4o A8mSPDQLeVrNUNdloB5/i1nSZKSYw2na1FEwi3YMAyltVUPTcqNR71YWJISu868xvUkk mzJItawTcYPFzOIWcnGkIngN596OpMbZGKyLhDPtCXUiQzrMT0d/mALMyiepIotpnXiw ssgAHGVzj7tW7+EPJTGgEXA8F9+CFzArua+19rwAxsWbEN3uUtLP5vipI4LIbjFl1mdb xq/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=0MMzdCmbKVmPeabgHjrL7CvtSp8+eDTIEoCSsL4OgBQ=; b=czdhgZI1CEEVt2Aj3GDX6SMJoccxTDT6aT4xplxEixHBibZ8exbIGrsSq55Fw3bcN5 RN9m5s3h/OXrfAFD8t/4cw0sKrfD2mUIbkLb5TKFZ6//WrELCogNm/faf/W45/f5PoZA Rd2zJXfC0PeqJKVIan/PMlsVBErm4OYj/4LgX8g4CLQiiR3dMjRDA1YA25rf2F7bz7qO ISmoEzYKdEhZ+IjphiPm3MraLTQZkvRsskBgODbBB8929GGEMcS/7gaHwag6NRuh6TLm jivqVLK4HXKh0c+O6OAUB+eN10r04xG/BppXcG0WIUH6wGKr4xHfSBMDMeyUVIcqDqee o7dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=Ln+6vaGQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16-v6si6970600pfy.169.2018.07.22.15.24.57; Sun, 22 Jul 2018 15:25:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=Ln+6vaGQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731031AbeGVXWP (ORCPT + 99 others); Sun, 22 Jul 2018 19:22:15 -0400 Received: from imap.thunk.org ([74.207.234.97]:43726 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730317AbeGVXWP (ORCPT ); Sun, 22 Jul 2018 19:22:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0MMzdCmbKVmPeabgHjrL7CvtSp8+eDTIEoCSsL4OgBQ=; b=Ln+6vaGQazd6AGVE0P7FJHXve9 1KtS8d2ietxHWVHcxux5y0wOxpNVI261TM8iUsZbyiz8wbbttA0gLzbXGGsbVFFtzNTwOg8q//Q79 jo6HLmrTPTaOo0WTJAbrslWJCOS7TEFrkG40Gn0+Jy8ChrUND/0MqKGFYmDiHgXbM1Ns=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1fhMlk-0005Xp-Ph; Sun, 22 Jul 2018 22:24:01 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 2DF817A6463; Sun, 22 Jul 2018 18:23:56 -0400 (EDT) Date: Sun, 22 Jul 2018 18:23:56 -0400 From: "Theodore Y. Ts'o" To: Junichi Uekawa Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: fix warning message to output correct type. Message-ID: <20180722222356.GD3358@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Junichi Uekawa , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180713091547.231108-1-uekawa@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180713091547.231108-1-uekawa@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 13, 2018 at 06:15:47PM +0900, Junichi Uekawa wrote: > Output the warning message before we clobber type and be -1 all the time. > The error message would now be > > [ 1.519791] EXT4-fs warning (device vdb): ext4_enable_quotas:5402: > Failed to enable quota tracking (type=0, err=-3). Please run e2fsck to fix. > > Signed-off-by: Junichi Uekawa Thanks, applied. - Ted