Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5501525imm; Mon, 23 Jul 2018 00:19:21 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfYkPIIAJIIDNP0+jl5pZzi9cDN2QUjU2SCOlUx4zydWcB1I9BiqxSvFzIqm16+rEej9SO5 X-Received: by 2002:a62:3d86:: with SMTP id x6-v6mr12095481pfj.192.1532330361180; Mon, 23 Jul 2018 00:19:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532330361; cv=none; d=google.com; s=arc-20160816; b=EhFzt/gKqdoitJq/0Fu5UOE69O9vQKi5lLoblWu+yaJBEEhQRU5cRhArlKD2rm25iV lDnPmSiFZg1DN8HNgn3SbFqKZ0BQjKN/u8YUVrStIYQq07+fAb2GEfL1UmufH21MOwDr 63WMfeRWvNrgEIzViwjF3/UFR0CdRdn+ivS+0eQ4g9dCYLh4V8AHUALpONnQmQq9/7gX ZIv+slLrSLCQFin7OaRQwl5GQ0N0By4ogD1rw8V1vm21/+8G+S8yxTgxrCE7h5rpmnod 8ccc2VZy42vgfXNRJU+hWjBzU6x5zos31FPrTOpcRWio3/rq7mYIH4ILRLtYCiFOqo5X HGwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=iDjqOt76yFHHmjMCxgX5DmAwJJV8hrhIBswSeq5aj/k=; b=cMoU67rEvcGmt8EEinqQ6kpufhU+twf6IqJZFo04RI9lCaMDBODJm2EjEIgW5eqUEd VVuYu9cRfXA6diy3Xcq+el6Czfk0Mez0ts13jtxdtGH6T2X9hVYEC0GzVaaYQ7AoDlDD 7iSYILKOCoIBUocukiEXGhzxvowMSEKlVOBADEBEewqY/ZAXuk3plDxOltM51p32QbN6 Vq9TuuS8loMD2hT1uSu8cb/owuuc2dZ4ec5mt+I8MOC5SaAvA3eS6hu5lPTsknT/OqhU iUnzOQsfKORXhjZOGIIFR9ydsG2fWv1NHfuyXZD7bOmUnPS8kowdI5EJIrpj+luTC+Om 4P3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=oRwxsVwU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19-v6si8270742pgb.196.2018.07.23.00.19.06; Mon, 23 Jul 2018 00:19:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=oRwxsVwU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387962AbeGWIR6 (ORCPT + 99 others); Mon, 23 Jul 2018 04:17:58 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:43298 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387805AbeGWIR6 (ORCPT ); Mon, 23 Jul 2018 04:17:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iDjqOt76yFHHmjMCxgX5DmAwJJV8hrhIBswSeq5aj/k=; b=oRwxsVwU8fs3ar4pymxHIElpn p90uX0Vff0+O7Ict9ZuWCWfGasdE7CZAv5eVgFYw7dsjQ+h7qaVQXP+zwRvJTzf+nfzQZHPjPm4DC 0HWNFHjQlIH7FiJOtkv5OUgnyruEJzKovvZHoEdDmEldF9YDPieD2ZR6ImycVPboutn8ec6G4V2Tp TtskiXCXaa0UNkvfMA5QLgK0aEw2desgqbGJ0HdqbS2EJ34gbqZGcf0Nj251SAnv/iJFBUxsNFHV0 rO+zcP2IAOLA60uztoJr8dWX23THwyCYdKCJwPkNrJ8/YTEuFosYu98RyiM3n2eK610fG56MriEZH Uf8/CULjA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fhV6a-000143-G2; Mon, 23 Jul 2018 07:18:04 +0000 Date: Mon, 23 Jul 2018 00:18:04 -0700 From: Christoph Hellwig To: Jia-Ju Bai Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task_ioprio() Message-ID: <20180723071803.GA30817@infradead.org> References: <20180723022116.6919-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723022116.6919-1-baijiaju1990@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig But to me it seems that btrfs and maybe ext4 as well would be much better off just setting a per-IO priority in the bio. Any chance yo could look into that?