Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5595175imm; Mon, 23 Jul 2018 02:32:26 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeJt5Fbp2fjlOeWEtK+d6EbTvbUD/CUfi5CmWiZoJbOZgcoy3irtyf24QqJmhUlDHxKrHaf X-Received: by 2002:a63:ae02:: with SMTP id q2-v6mr11336586pgf.189.1532338345967; Mon, 23 Jul 2018 02:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532338345; cv=none; d=google.com; s=arc-20160816; b=nbdly1XvgUUv/a7ARx0PvqV6rKEla5OetSUjcucPIdCmEtaO/01s7F4XWHEd+HLrnk 8gOXi879g//W91al6V1NnoMD1iCfi8JSk9vzj3l/wvhEXmN49YMolHmslt6nURC3lYVt pCAvoaeuEEpGasLVQOPvjCsosExyCw0gtbOfGF7a6Zxz0WdsDaN5z+JYdzEFFLn9j8GW 2j283su0achYU/8/mVbJlxdJWMl7B4OKKdDbTdQHqU8fM1ipzPcIatkMh0q3ZpeJMzIY LQ+8q483BNP1rGFmBhhNSx2PqyUb80TW8aiDS4CsbNYF/LImOyESJhf6rCW3V4zb5I6w nlOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=WG3fmAe8Oamw6J011ucy5lfFOQq0LxhefJ5PmCAscwI=; b=UgBC0cRZC6PXAG6Ezyenfsa1hChxiuBrrrWL8hPm2hvcGgWizPPg4hWD3JeWx9eLF3 2hVKEO2kWHi6TThLQ5Zw1sy5BqabY30d1HAhmUnAWivI0uXrk5InSp4wrsgVcU6E2Jq9 1PEMQH6XUoUpw+CWRPySsePgTGE8ZwV/h2ymycNPqxkPnws0IVUgf2w4+BnNTPC/XkEu /UgebX0d/3W/aLpP+KM50tR2YiQTYBrsLKZ7ty7ZYO5C19ai1QBpi4BZiWiA9tPFnuRI SOTuisLQWBI0FpjF4uWQ8uugsyIott/lL24kpD65WKJ73XpfUNoIiuIJY6RiDlG0ohpP 7gYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="mXvRL1P/"; dkim=pass header.i=@codeaurora.org header.s=default header.b="mXvRL1P/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11-v6si8056105plb.195.2018.07.23.02.32.11; Mon, 23 Jul 2018 02:32:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="mXvRL1P/"; dkim=pass header.i=@codeaurora.org header.s=default header.b="mXvRL1P/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388229AbeGWKbD (ORCPT + 99 others); Mon, 23 Jul 2018 06:31:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43628 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387933AbeGWKbC (ORCPT ); Mon, 23 Jul 2018 06:31:02 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 88DD2608C8; Mon, 23 Jul 2018 09:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1532338245; bh=eyPZBKYyw5DjI1yU0ayEpF4rCW9aMA4o+8b7Ffe9d4A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mXvRL1P/Bx/8b4PBSHHe9jCM/u/GO0ig+Y2FRhFf6murthI43rknVMr5B1T0uynbw W1rN7tXuiFcm/srd6y4cSgXvV/GSGG2rKomsP+XZLf4S+/59YLE+J/PKldb2agRxvq b9ICEzE9NDGVhj733033oij3D/wGzVV/8Sskc0Sw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2466360481; Mon, 23 Jul 2018 09:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1532338245; bh=eyPZBKYyw5DjI1yU0ayEpF4rCW9aMA4o+8b7Ffe9d4A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mXvRL1P/Bx/8b4PBSHHe9jCM/u/GO0ig+Y2FRhFf6murthI43rknVMr5B1T0uynbw W1rN7tXuiFcm/srd6y4cSgXvV/GSGG2rKomsP+XZLf4S+/59YLE+J/PKldb2agRxvq b9ICEzE9NDGVhj733033oij3D/wGzVV/8Sskc0Sw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2466360481 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Bernd Edlinger Cc: Johannes Berg , "David S. Miller" , "linux-wireless\@vger.kernel.org" , "netdev\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH] Add a missing break in parse_station_flags References: Date: Mon, 23 Jul 2018 12:30:41 +0300 In-Reply-To: (Bernd Edlinger's message of "Sun, 8 Jul 2018 09:57:22 +0000") Message-ID: <87r2juti2m.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bernd Edlinger writes: > I was looking at usually suppressed gcc warnings, > [-Wimplicit-fallthrough=] in this case: > > The code definitely looks like a break is missing here. > However I am not able to test the NL80211_IFTYPE_MESH_POINT, > nor do I actually know what might be :) > So please use this patch with caution and only if you are > able to do some testing. > > Signed-off-by: Bernd Edlinger > --- > net/wireless/nl80211.c | 1 + > 1 file changed, 1 insertion(+) You should use prefix "nl80211: " in the title. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject -- Kalle Valo