Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 23 Jul 2018 11:31:21 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     =?utf-8?B?546L6LSH?= <yun.wang@linux.alibaba.com>
Cc:     Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tg: show the sum wait time of an task group
Message-ID: <20180723093121.GA2494@hirez.programming.kicks-ass.net>
References: <5c4c978d-e8fb-4bcb-b942-3c6d3dcfc13e@linux.alibaba.com>
 <b9e74571-87d0-ef27-3f14-ebd21d72ee15@linux.alibaba.com>
 <ff7dae3b-e5f9-7157-1caa-ff02c6b23dc1@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ff7dae3b-e5f9-7157-1caa-ff02c6b23dc1@linux.alibaba.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 04, 2018 at 11:27:27AM +0800, 王贇 wrote:

> @@ -6788,6 +6790,12 @@ static int cpu_cfs_stat_show(struct seq_file *sf, void *v)
>  	seq_printf(sf, "nr_throttled %d\n", cfs_b->nr_throttled);
>  	seq_printf(sf, "throttled_time %llu\n", cfs_b->throttled_time);
> 
> +	if (schedstat_enabled() && tg != &root_task_group) {

I put the variables here.

> +		for_each_possible_cpu(i)
> +			ws += schedstat_val(tg->se[i]->statistics.wait_sum);

This doesn't quite work on 32bit archs, but I'm not sure I care enough
to be bothered about that.

> +		seq_printf(sf, "wait_sum %llu\n", ws);
> +	}