Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5653227imm; Mon, 23 Jul 2018 03:45:53 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcHgW6XHJeylWOU/JG/y8Kc0s8DOOFTj7SYiMDvaj09nu9o2pOqNqBSQF4MWlk+vmbyWg7E X-Received: by 2002:a62:20d8:: with SMTP id m85-v6mr12847304pfj.74.1532342753448; Mon, 23 Jul 2018 03:45:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532342753; cv=none; d=google.com; s=arc-20160816; b=e/Xxf7Q/ogoxrSUcCOq7GnwTDTNRIcQxzC1k31bsmZe6PTHL+QZr/kEqlhrYwtgpNy he7HkFOwdmpQd217+GjQuYU5AOQgLpT41/fwOxKkCLw6l7yWZ1a7PtYmJ+HlUHcD13Us SdfvbLXB/Svh9Yv/uJs0WcBN91deMHvm7p1tzmDpnMCD7iMASTHhSB3GYCfqNqIvffU0 D/WJqPl5cbLfnIUNB6IJgGuNgSXl1bdAYD2WSjROWVD342h38nPDfwEUo+b+EfwHgQFI pMMrTcYckA6dIEQMzosFGZxtBvoU2IskZYksfexuKtAc/zchWeHY4Nzz5adSBUVEBaUn cmJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Nl9b3MXHZhZ5P2g2MvhNbFuSFxR0+JBPJSxgN6oipkI=; b=rJ/iL0RBw1VobzS6w3hmn5gT7Y9G4oA2uTwjyH2rYqc3ZdP+jSBzw7gIHLHHeg7F/1 nU2w3prwoRH94YSW5dg+8JriTP9dPWI1vLicqgkuLC1IvXnc+e0F7zKNWLLVhhWOJ85Y MJX8Z5QRAkMx9QpaGiMxry5CXR930Ou5Lspd/JwC7ix4kDGG6NVuhZQvHoAsLkyGd6EZ I7iDtWzkU7vSCgpAIv7ws8IP7GeHQsFDXEyUn8Y229EORxmrHs8XEqdUEQgrwuUh9WKn M+1IowbdqibKGkAU/LYCEEr132ksqMMg/joD6rYCPTjYIQ6ZJh1+eRA6ANUXI6j+W/ur RyKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 185-v6si8725235pgj.511.2018.07.23.03.45.38; Mon, 23 Jul 2018 03:45:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388234AbeGWLoG (ORCPT + 99 others); Mon, 23 Jul 2018 07:44:06 -0400 Received: from mail.us.es ([193.147.175.20]:58996 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388021AbeGWLoF (ORCPT ); Mon, 23 Jul 2018 07:44:05 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4C1474B0FA for ; Mon, 23 Jul 2018 12:41:31 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3DA25DA4CC for ; Mon, 23 Jul 2018 12:41:31 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 25188DA4D6; Mon, 23 Jul 2018 12:41:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 049B1DA4C1; Mon, 23 Jul 2018 12:41:29 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 23 Jul 2018 12:41:29 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id B2AE64265A5C; Mon, 23 Jul 2018 12:41:28 +0200 (CEST) Date: Mon, 23 Jul 2018 12:43:27 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: shaochun chen Cc: Florian Westphal , David Miller , kadlec , "johannes.berg" , jason , ktkhai , "lucien.xin" , "xiyou.wangcong" , dsahern , netfilter-devel , tom , netdev , linux-kernel Subject: Re: [PATCH] netlink: fix memory leak of dump Message-ID: <20180723104327.rmptoqx7gzvwvbra@salvia> References: <20180722143354.23722-1-cscnull@gmail.com> <20180722163925.gdfkndldatsoae6x@breakpoint.cc> <20180722.100755.19840167505550163.davem@davemloft.net> <20180722180910.wcwhantwpm2nfxet@breakpoint.cc> <20180723091551.mwhltw4ujm4bylvj@salvia> <20180723092818.ztsfsnqzxgzrauim@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 23, 2018 at 06:34:36PM +0800, shaochun chen wrote: > I have a question: we will try_module_get in __netlink_dump_start(), > but why we need to call try_module_get again in nft_netlink_dump_start ?? Because they refer to two different modules. nfnetlink is multiplexing all netfilter subsystem through one single netlink bus. At the time that decision was made, there were concerns about netlink running out of busses.