Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Xidong Wang <wangxidong_97@163.com>
To:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>,
        Michal Nazarewicz <mina86@mina86.com>,
        Vincent Pelletier <plr.vincent@gmail.com>
Cc:     wangxidong_97@163.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] usb:gadget:function:fix memory leak
Date:   Mon, 23 Jul 2018 19:09:46 +0800
Message-Id: <1532344186-30505-1-git-send-email-wangxidong_97@163.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function f_audio_set_alt(), the memory allocated by
usb_ep_alloc_request() is not released on the error path
that req->buf, which holds the return value of kzalloc(),
is NULL. This will result in a memory leak bug.

Signed-off-by: Xidong Wang <wangxidong_97@163.com>
---
 drivers/usb/gadget/function/f_uac1_legacy.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 24c086b..2fcdade 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -630,8 +630,11 @@ static int f_audio_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 							ERROR(cdev,
 							"%s queue req: %d\n",
 							out_ep->name, err);
-					} else
+					} else {
+						usb_ep_free_request(
+							out_ep, req);
 						err = -ENOMEM;
+					}
 				} else
 					err = -ENOMEM;
 			}
-- 
2.7.4