Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5775781imm; Mon, 23 Jul 2018 06:00:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpccAETEs39DE7zlWUBi/edxCQmzbQGdYKE/ts+jFuSICB0Wd5MC5v470o2iPSL653T2qcS/ X-Received: by 2002:a63:1546:: with SMTP id 6-v6mr12231808pgv.271.1532350835757; Mon, 23 Jul 2018 06:00:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532350835; cv=none; d=google.com; s=arc-20160816; b=jnh7L7qcTnYUJ7oo1dqTKsnQxbq+DYWc7g5Jo5WP2hLIXEtzKH3+lPy4cF/BdeXTLv 2ZnArCdlIAUVveLjCvAq2uyO7sjdO+Oa/kp9qC3jia+oB6vmX5PdqbPbXdD8vkswemgc rfjOwgNa0+XgqiaV8qYkd4ByG5HfyFsjc6DQ/SLYskoQ+3lo8i1kXpxjE0V2Rw0tJsYD jflm5gWy2VSdwlB1KdOtOLIZm2Swp+tW3udd1n3nbp6J+eLfHVyV0ASwbuaUTGgUOtHn nUb5WlI/TAPixJWMQfQAST2BuGCfmUCoh7fXZyWQBMDlBist8VDDZodmEj6Xlf0Zgu53 XZ/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=E7Msz+qgDSES4Lwo0Oub7SQkLrkl8nKH7KIUjvPJ6Js=; b=rGWaXS4Ag8yBda4HuyPJxD9nJuuJRiUwjXptyefGlI8zWPzZedfCaHJ7VoOfjT2RBb uB+i3f3/20m7IRphXFy6DGx0vxmioD0E/D40Wnz5XBzPXw8cSnb5v25YFEsPa2i69VJV rCQANT8l3/IF3j1tKlsLUH9vLmL2tSeGfJw/RnuMYVGyu1D6h/NqNytb3rAgjIgEDU79 fSKOBIiszj8YC+m0L95hyHHov67hK+CFR8H+CRvcyX17RCW18MXqS6VtxJsHniSJjqP3 mEQ2l+p2qQzY8+tkohxgQsh5VGgVUQ8etnrL88pPnwkhKneEjox7MekWetfQtjxbVq3H ypXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=raqxfohp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73-v6si8214755pgh.343.2018.07.23.06.00.20; Mon, 23 Jul 2018 06:00:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=raqxfohp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388452AbeGWOAY (ORCPT + 99 others); Mon, 23 Jul 2018 10:00:24 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:39699 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388245AbeGWOAX (ORCPT ); Mon, 23 Jul 2018 10:00:23 -0400 Received: by mail-pl0-f65.google.com with SMTP id m1-v6so198624plt.6; Mon, 23 Jul 2018 05:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=E7Msz+qgDSES4Lwo0Oub7SQkLrkl8nKH7KIUjvPJ6Js=; b=raqxfohpJnpCs0RJkm6jiCyhQfLuBYGPYz6Tc1xFXsxGsGpv26o6FZj3VtzmWc2lwC 2hc/89JGObAFyy2f93A8kBMYozh9IhQQKll5E+rKTf1dhCOtOYhWq+fBlfhcoHEsIuTi V4+IRiIxgG0pNmPMBnYNVtiZj3eLLR8L1Tc86B5+LiDCYZljTFiDDH19MigmrKK8amhR EpsZXbHR4ivECtzmJfpQnZFN9Fh2gH1v76CnSabywh3zRSbCsJzWzydLqJ9o6JkkBs1R YQBjQuz87J8ABxpeXpwY5vJTKDu8Z5oFuiajfeRAeG12025mqE8bMhoFKpSNxF9ld/Mz iQFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=E7Msz+qgDSES4Lwo0Oub7SQkLrkl8nKH7KIUjvPJ6Js=; b=Ci2dp4JI1mcR071XYevToxV/MrWX6D0SNp0JrGOkHBGzm9hYhqGc8K5jPHqnL/VUpd wd8/5L/SFAIZmSnwwxiAIkKesjZkpyymqtlVJOoqslZUJ7Chl4sidpLjKxWZGUe6nG6x dDCMeP3i88Bn7T1uAklC9FLxthftOq2IkW8eG7DTkn4RHDza/spVah148twOIySdmrxG 0YXPJHABYzndqOoPCAHYLjdhMA0pJW+dLoERLn441aiRkLZJltp0qSCKTYgBynUMXKiU c+Zhd4WPZk0WumLXCCmdVcImqba7NUroZoFGNXmWt1hfzvzkU27FPJgAN7EHXLO3biZA Dj4w== X-Gm-Message-State: AOUpUlET4xefZABa0oSDYths+j3Nu/5qjV3etohKURP+nyk/nVNrhoKH XQlt11EirdcEp4PH16cqBfqrrmVa X-Received: by 2002:a17:902:8e81:: with SMTP id bg1-v6mr12790927plb.129.1532350755151; Mon, 23 Jul 2018 05:59:15 -0700 (PDT) Received: from ?IPv6:2402:f000:1:1501:200:5efe:101.5.211.5? ([2402:f000:1:1501:200:5efe:6505:d305]) by smtp.gmail.com with ESMTPSA id g7-v6sm9378363pfi.175.2018.07.23.05.59.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 05:59:14 -0700 (PDT) Subject: Re: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task_ioprio() To: Christoph Hellwig Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180723022116.6919-1-baijiaju1990@gmail.com> <20180723071803.GA30817@infradead.org> From: Jia-Ju Bai Message-ID: <4517e5f9-84db-aa1f-609f-a01f1d4f5d79@gmail.com> Date: Mon, 23 Jul 2018 20:59:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180723071803.GA30817@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the reply :) On 2018/7/23 15:18, Christoph Hellwig wrote: > Looks good, > > Reviewed-by: Christoph Hellwig > > But to me it seems that btrfs and maybe ext4 as well would be much > better off just setting a per-IO priority in the bio. > > Any chance yo could look into that? In fact, my tool does not report any defects in btrfs and ext4. Best wishes, Jia-Ju Bai