Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] memory: jz4780-nemc: build depend on OF
To:     Corentin Labbe <clabbe@baylibre.com>, Zubair.Kakakhel@imgtec.com,
        gregkh@linuxfoundation.org, alex@alex-smith.me.uk
Cc:     linux-kernel@vger.kernel.org
References: <1532345923-28811-1-git-send-email-clabbe@baylibre.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <3660b849-930f-8771-21d7-9f3e63789d13@infradead.org>
Date:   Mon, 23 Jul 2018 08:35:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1532345923-28811-1-git-send-email-clabbe@baylibre.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/23/2018 04:38 AM, Corentin Labbe wrote:
> jz4780-nemc use of_ functions, so it needs to depend on OF
> 
> This fix the following build failure on x86
> drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
> drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  drivers/memory/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index a642552..faa1a23 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -124,6 +124,7 @@ config JZ4780_NEMC
>  	default y
>  	depends on MACH_JZ4780 || COMPILE_TEST
>  	depends on HAS_IOMEM
> +	depends on OF
>  	help
>  	  This driver is for the NAND/External Memory Controller (NEMC) in
>  	  the Ingenic JZ4780. This controller is used to handle external
> 

Duplicate of https://lore.kernel.org/lkml/20180721200049.7553-1-anders.roxell@linaro.org/


-- 
~Randy