Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        "rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: phy: use generic clause 45 autonegotiation done
Thread-Topic: [PATCH] net: phy: use generic clause 45 autonegotiation done
Thread-Index: AQHUHpkhRppx3uTn+EqPQRQZK8PlPqSVDQWAgAFxzNCABnHsYA==
Date:   Mon, 23 Jul 2018 15:14:31 +0000
Message-ID: <VI1PR04MB4799222839701D318B3483FBF2560@VI1PR04MB4799.eurprd04.prod.outlook.com>
References: <1531919535-20269-1-git-send-email-camelia.groza@nxp.com>
 <20180718143919.GA10856@lunn.ch>
 <VI1PR04MB4799F126865F4A5C115D1B16F2520@VI1PR04MB4799.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB4799F126865F4A5C115D1B16F2520@VI1PR04MB4799.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d54351a-d8dd-4bf0-b80d-08d5f0aefdda
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2018 15:14:31.5357
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3054
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Camelia Alexandra Groza
> Sent: Thursday, July 19, 2018 15:47
> To: Andrew Lunn <andrew@lunn.ch>
> Cc: rmk+kernel@armlinux.org.uk; f.fainelli@gmail.com;
> davem@davemloft.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH] net: phy: use generic clause 45 autonegotiation done
>=20
> > -----Original Message-----
> > From: Andrew Lunn [mailto:andrew@lunn.ch]
> > Sent: Wednesday, July 18, 2018 17:39
> > To: Camelia Alexandra Groza <camelia.groza@nxp.com>
> > Cc: f.fainelli@gmail.com; davem@davemloft.net; netdev@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] net: phy: use generic clause 45 autonegotiation
> > done
> >
> > On Wed, Jul 18, 2018 at 04:12:15PM +0300, Camelia Groza wrote:
> > > Only Clause 22 PHYs can use genphy_aneg_done(). Use
> > > genphy_c45_aneg_done() for PHYs that implement Clause 45 without
> the
> > > Clause 22 register set.
> > >
> > > This change follows the model of phy_restart_aneg() which
> > > differentiates between the two implementations in a similar way.
> >
> > Hi Camelia
> >
> > What about phy_config_aneg()? I would assume any sort of auto-neg
> > action needs to check for c45 without c22, before calling a genphy_
> > function. Do you think it is possible to write a
> > genphy_c45_config_aneg()? If not, we might want to return -
> EOPNOTSUPP.
>=20
> Hi Andrew,
>=20
> Adding Russell to the thread as well, since he wrote the c45 helpers.
>=20
> Sure, I'll send a v2 with an additional generic phy_config_aneg(). I'll s=
tick to
> returning -EOPNOTSUPP for c22-less PHYs for now.

Since the phy_config_aneg() call isn't synced on the net tree yet, I sent t=
he second patch independently on net-next [1]. Please review this patch sep=
arately if it's ok.

[1] https://patchwork.ozlabs.org/patch/947831/

Thank you,
Camelia