Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6062136imm; Mon, 23 Jul 2018 10:43:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfkrEDdtZ/pUXoS+ds3qjLxffSb8/NMOPTyPIOq8PfhWWiC0ejosKStW70pTWINsDCUSNp+ X-Received: by 2002:a62:1d97:: with SMTP id d145-v6mr14358765pfd.101.1532367805577; Mon, 23 Jul 2018 10:43:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532367805; cv=none; d=google.com; s=arc-20160816; b=L/uOIbswqKIKoiDibhBGwAk7tnMtoj63Ufi3tHbA56YntEBzessh+si1CLyLtFTLQE pwwnB+N1BDGBdhFbRfe67KlyFxlklJQc72dR5NTQX5HRTqVuk1LUBHIn+6clw5xvHCGx +oioxNaqHR9/IjGEVn/+rvQEkPoGyqzb+r/1xJthbJZo5tLGYV3O3rKFvjCc/lgF3I7J 6un8Fjc8kLGld8RmtJVN5TltvAlrwsxTxKLc1kCq9VxO4+nIgQKSzJpRLto86k7XpwM3 uMIKCSHFBRQP3eDuxWjed2HpsZaEEfLKG78yLzDPFEX+MnDx8zJu/sW/bSdomdO2Kq6j kRaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:references:subject:cc:to :from:arc-authentication-results; bh=JB+Wxh9wjJmqlcXveGGxpG3RCyz5kYNugY0F/vADyoI=; b=EMwN8gaFXM3R44GbK54v8uCfmMF4tD2T/YIqfdEGPGpcZUsbxWW8iABhzhAAZO8jD9 t+0Kg/lkI57MeMtoSqcYMnocJUq5iTBdqO49VYtp9b9aApqp2KI+ekHKHe54M5KFz4pO macnCxYjJOJ0lapKJDkbo9l8wFOSLZalxPbkaA9VoP7prF6KGROODbEtV3xXcNSbCWHy BclFWxaNcsrR1VpKq4YzL5XyRxxZEwY4rww7EtWXYB22kusZN4P9yCMRRx0ypDEezdby C0Sf9wmsjHMb0/33GqcuxZWlZ/jCAKd8qhYF1JzHAWFN5/YKjPBiqf/g2PcJC9Ryd6I/ Bk+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o11-v6si8194173plk.421.2018.07.23.10.43.10; Mon, 23 Jul 2018 10:43:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388249AbeGWSn4 (ORCPT + 99 others); Mon, 23 Jul 2018 14:43:56 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40353 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388037AbeGWSn4 (ORCPT ); Mon, 23 Jul 2018 14:43:56 -0400 X-Originating-IP: 79.86.19.127 Received: from [192.168.0.11] (127.19.86.79.rev.sfr.net [79.86.19.127]) (Authenticated sender: alex@ghiti.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B3582FF809; Mon, 23 Jul 2018 17:41:26 +0000 (UTC) From: Alex Ghiti To: Michael Ellerman Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, tony.luck@intel.com, fenghua.yu@intel.com, ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, jejb@parisc-linux.org, deller@gmx.de, benh@kernel.crashing.org, paulus@samba.org, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Naoya Horiguchi , Mike Kravetz , Michal Hocko Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives References: <20180705110716.3919-1-alex@ghiti.fr> <20180709141621.GD22297@dhcp22.suse.cz> <2173685f-7f85-7acb-4685-2383210c5fa2@ghiti.fr> <87d0vehx16.fsf@concordia.ellerman.id.au> Message-ID: <2d4c19e1-f622-7747-3ba1-ff3243337b93@ghiti.fr> Date: Mon, 23 Jul 2018 17:41:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <87d0vehx16.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: * Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ok will do and report when done. Thanks for your feedback, Alex On 07/23/2018 02:00 PM, Michael Ellerman wrote: > Alex Ghiti writes: > >> Does anyone have any suggestion about those patches ? > Cross compiling it for some non-x86 arches would be a good start :) > > There are cross compilers available here: > > https://mirrors.edge.kernel.org/pub/tools/crosstool/ > > > cheers > >> On 07/09/2018 02:16 PM, Michal Hocko wrote: >>> [CC hugetlb guys - http://lkml.kernel.org/r/20180705110716.3919-1-alex@ghiti.fr] >>> >>> On Thu 05-07-18 11:07:05, Alexandre Ghiti wrote: >>>> In order to reduce copy/paste of functions across architectures and then >>>> make riscv hugetlb port (and future ports) simpler and smaller, this >>>> patchset intends to factorize the numerous hugetlb primitives that are >>>> defined across all the architectures. >>>> >>>> Except for prepare_hugepage_range, this patchset moves the versions that >>>> are just pass-through to standard pte primitives into >>>> asm-generic/hugetlb.h by using the same #ifdef semantic that can be >>>> found in asm-generic/pgtable.h, i.e. __HAVE_ARCH_***. >>>> >>>> s390 architecture has not been tackled in this serie since it does not >>>> use asm-generic/hugetlb.h at all. >>>> powerpc could be factorized a bit more (cf huge_ptep_set_wrprotect). >>>> >>>> This patchset has been compiled on x86 only. >>>> >>>> Changelog: >>>> >>>> v4: >>>> Fix powerpc build error due to misplacing of #include >>>> outside of #ifdef CONFIG_HUGETLB_PAGE, as >>>> pointed by Christophe Leroy. >>>> >>>> v1, v2, v3: >>>> Same version, just problems with email provider and misuse of >>>> --batch-size option of git send-email >>>> >>>> Alexandre Ghiti (11): >>>> hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h >>>> hugetlb: Introduce generic version of hugetlb_free_pgd_range >>>> hugetlb: Introduce generic version of set_huge_pte_at >>>> hugetlb: Introduce generic version of huge_ptep_get_and_clear >>>> hugetlb: Introduce generic version of huge_ptep_clear_flush >>>> hugetlb: Introduce generic version of huge_pte_none >>>> hugetlb: Introduce generic version of huge_pte_wrprotect >>>> hugetlb: Introduce generic version of prepare_hugepage_range >>>> hugetlb: Introduce generic version of huge_ptep_set_wrprotect >>>> hugetlb: Introduce generic version of huge_ptep_set_access_flags >>>> hugetlb: Introduce generic version of huge_ptep_get >>>> >>>> arch/arm/include/asm/hugetlb-3level.h | 32 +--------- >>>> arch/arm/include/asm/hugetlb.h | 33 +---------- >>>> arch/arm64/include/asm/hugetlb.h | 39 +++--------- >>>> arch/ia64/include/asm/hugetlb.h | 47 ++------------- >>>> arch/mips/include/asm/hugetlb.h | 40 +++---------- >>>> arch/parisc/include/asm/hugetlb.h | 33 +++-------- >>>> arch/powerpc/include/asm/book3s/32/pgtable.h | 2 + >>>> arch/powerpc/include/asm/book3s/64/pgtable.h | 1 + >>>> arch/powerpc/include/asm/hugetlb.h | 43 ++------------ >>>> arch/powerpc/include/asm/nohash/32/pgtable.h | 2 + >>>> arch/powerpc/include/asm/nohash/64/pgtable.h | 1 + >>>> arch/sh/include/asm/hugetlb.h | 54 ++--------------- >>>> arch/sparc/include/asm/hugetlb.h | 40 +++---------- >>>> arch/x86/include/asm/hugetlb.h | 72 +---------------------- >>>> include/asm-generic/hugetlb.h | 88 +++++++++++++++++++++++++++- >>>> 15 files changed, 143 insertions(+), 384 deletions(-) >>>> >>>> -- >>>> 2.16.2