Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] IB/mlx5: avoid excessive warning msgs when creating
 VFs on 2nd port
To:     Qing Huang <qing.huang@oracle.com>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org
Cc:     jgg@ziepe.ca, dledford@redhat.com, leon@kernel.org,
        gerald.gibson@oracle.com, sharon.s.liu@oracle.com
References: <20180723211508.7078-1-qing.huang@oracle.com>
From:   Daniel Jurgens <danielj@mellanox.com>
Message-ID: <be7536a3-3548-3e89-fad4-71180511a5ce@mellanox.com>
Date:   Mon, 23 Jul 2018 16:17:23 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180723211508.7078-1-qing.huang@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Received-SPF: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2018 21:17:36.0492 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ebc7615a-b4b9-4bf9-2b9f-08d5f0e1b76f
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2265
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/23/2018 4:15 PM, Qing Huang wrote:
> When a CX5 device is configured in dual-port RoCE mode, after creating
> many VFs against port 1, creating the same number of VFs against port 2
> will flood kernel/syslog with something like
> "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 already
> affiliated."
>
> So basically, when traversing mlx5_ib_dev_list, mlx5_ib_add_slave_port()
> repeatedly attempts to bind the new mpi structure to every device
> on the list until it finds an unbound device.
>
> Change the log level from warn to dbg to avoid log flooding as the warning
> should be harmless.
>
> Signed-off-by: Qing Huang <qing.huang@oracle.com>
> ---
>   v1 -> v2: change the log level instead
>
>  drivers/infiniband/hw/mlx5/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index b3ba9a2..f57b8f7 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -5127,8 +5127,8 @@ static bool mlx5_ib_bind_slave_port(struct mlx5_ib_dev *ibdev,
>  
>  	spin_lock(&ibdev->port[port_num].mp.mpi_lock);
>  	if (ibdev->port[port_num].mp.mpi) {
> -		mlx5_ib_warn(ibdev, "port %d already affiliated.\n",
> -			     port_num + 1);
> +		mlx5_ib_dbg(ibdev, "port %d already affiliated.\n",
> +			    port_num + 1);
>  		spin_unlock(&ibdev->port[port_num].mp.mpi_lock);
>  		return false;
>  	}
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>