Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6442593imm; Mon, 23 Jul 2018 18:44:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcWKuSqxmIP5gIFWGcfV4/UWZcy5/4Gnm4pF6l3twQDOCUrEHC1FJghEofMACmMdqWpZALC X-Received: by 2002:a65:6211:: with SMTP id d17-v6mr14704165pgv.450.1532396655633; Mon, 23 Jul 2018 18:44:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532396655; cv=none; d=google.com; s=arc-20160816; b=y4CgLqD/EZIeqVX5Cg9xZlQ7i0AAxEOIjM1VbRWwL+fHVwUI0BjMS5MWg9fbGmKVD+ 7PmVX/vRPZfe058UGzWm4LhqVy0FI3+WOhHR3A3qXdKO4kyWL/u8rbia+4X3eoXTn0hc 01Hl5GE09Q2bId/7hpmod5TItqHVfjcwaznchj/Rdncrc/KuzZw8gUgh6jDLPy0zPHs9 0f8rZ9a0dHsA9qdwi4KvnOG3q1eUymsguu99p6ybPAzICJeYQcuU7RT79fjomhmtxgWK ez7USkcTJux0HNX/UWu0zoU/NvPuDJeyv0UIAuvMx+TwlH1PAw018FDAcMdjAZL3V77/ r9bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=1EYjYgyCmvJ5V7OgwzHMHiRu3AN7mFz2MQ8kepnXbdc=; b=j7HsZuug/lASYCruHroteEf1wP98PQuEfauKGpcGRGJm7U9OB/sl5Xoh/1M+rK9lig Ksn6L+3MV5KwTVfibVPbG8td76FuFV0qfSMgjpXlTUlN6+hQHr0gdEG8LLGeyDvwNzio 1Yxw0qZ6rBD6wB4UmR4437VS2speRLFJy9iytOSM5mz725TbcaHOtCq1vVyGt9Kn4WJD jCNDXELPIAdDdNP0TI8eJxjBVZkA7084woPPOz9mtpyYEKxW0YH0ayk6Nx4hcgC+lbZ7 BQLofJbtA2WSo+Js8jfglC80eY8cshfdymYOdFfN9+gT4iF36FMe9nY45T8ZMhCkf+LY ay3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="SL/ZyiW0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5-v6si9719534pfo.54.2018.07.23.18.44.01; Mon, 23 Jul 2018 18:44:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="SL/ZyiW0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388370AbeGXCq3 (ORCPT + 99 others); Mon, 23 Jul 2018 22:46:29 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:41447 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388267AbeGXCq3 (ORCPT ); Mon, 23 Jul 2018 22:46:29 -0400 Received: by mail-pf1-f195.google.com with SMTP id y10-v6so452488pfn.8; Mon, 23 Jul 2018 18:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1EYjYgyCmvJ5V7OgwzHMHiRu3AN7mFz2MQ8kepnXbdc=; b=SL/ZyiW0YqLjUoCZFQd2y4wo653LhJjatA1XNreJEgzznAn11XTgyi3xjuCAMXk0XJ cfs0eW6nZBwJ53btPaIfPjYaCwx74lnXOPjOUaT/e5lZ+a5pu7jFvS5Pr37JVDnwpd2f iTJQ8yi8kUEWimXhgGPElR2VjrF1/4KROSbztqrD+vlBzoQZYxsY+zW3pApzKq5ZoM8z f8eg/75gEdnV+wcpXqThYpTGhsagUFbF/CyXPYETGL/Ox6CF44PoZXm7/0RNiepHYOeQ FjVO+p0CCzaAv1zKr/vRaa03sWQbjpbSjlQBSujruVzBg/ZbO0GyaCHHTuOiQ9Su5ZD8 Tnjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1EYjYgyCmvJ5V7OgwzHMHiRu3AN7mFz2MQ8kepnXbdc=; b=nBfLj2ifE4uyV0Qa8Vq4qDdgqZht4sqC+v3sZgwtq4ljDq0daqvlGkRNvDbsCu+9jK 8dP3ZddY1azkFUkWoNsbVJDZJADb20GwRhs/6F3w9cw+LK39YLzQxo4QXVEcMzlZOEEh Ip21lnyWw4EB7MqZ103UCKVX2W6N+9W2b+jZlULxKVLL2k8Rbke4WZxXJOkEwHXBmRJz hgfZ3juYFxnKnxnArwBLupUaTbPUHXniRnM0+LeKu4ZTecNH4Q0kiAveRUqeNEEloAfA mAxwgGyvRAKATg+20QDzYQeTTI9Lfv0qteIImDpb6GiD92TIbGMpWnpqWg7m3tUqhoGp zWpQ== X-Gm-Message-State: AOUpUlFK07cYinil2K29zlqdy8jxoVkMO6pyVr2Qj+ZihlMF+6aV14sc v7RHT+vUY31fj6iO40yZulmLQS2t X-Received: by 2002:a63:9311:: with SMTP id b17-v6mr14412433pge.261.1532396551837; Mon, 23 Jul 2018 18:42:31 -0700 (PDT) Received: from ?IPv6:2402:f000:1:1501:200:5efe:101.5.211.5? ([2402:f000:1:1501:200:5efe:6505:d305]) by smtp.gmail.com with ESMTPSA id 22-v6sm18040178pfl.126.2018.07.23.18.42.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 18:42:31 -0700 (PDT) Subject: Re: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task_ioprio() To: Tetsuo Handa , Christoph Hellwig Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180723022116.6919-1-baijiaju1990@gmail.com> <20180723071803.GA30817@infradead.org> <8dab79c6-eb75-b013-1f83-3af43a7052cb@I-love.SAKURA.ne.jp> From: Jia-Ju Bai Message-ID: <00149ccf-71d7-14e9-fb64-9b8b2ca1e74e@gmail.com> Date: Tue, 24 Jul 2018 09:42:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <8dab79c6-eb75-b013-1f83-3af43a7052cb@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/7/24 5:49, Tetsuo Handa wrote: > On 2018/07/23 16:18, Christoph Hellwig wrote: >> Looks good, > Looks bad. :-( > > SYSCALL_DEFINE3(ioprio_set, int, which, int, who, int, ioprio) > { > (...snipped...) > rcu_read_lock(); > (...snipped...) > ret = set_task_ioprio(p, ioprio); > (...snipped...) > rcu_read_unlock(); > (...snipped...) Oops, my tool does not handle SYSCALL_DEFINE3()... Sorry for my incorrect report. Best wishes, Jia-Ju Bai