Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: m68k allmodconfig build errors
To:     Finn Thain <fthain@telegraphics.com.au>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-m68k@lists.linux-m68k.org
References: <28ebe45d-3dbd-2a82-f537-b0725f7a2bcf@infradead.org>
 <alpine.LNX.2.21.1807201454590.8@nippy.intranet>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <8991ac62-0239-ddfd-6378-95c4ec2fe42b@infradead.org>
Date:   Mon, 23 Jul 2018 18:49:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.21.1807201454590.8@nippy.intranet>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/19/2018 10:17 PM, Finn Thain wrote:
> On Thu, 19 Jul 2018, Randy Dunlap wrote:
> 
>> Hi Geert,
>>
>> I am seeing a few errors when cross-building m68k on x86_64, using the 
>> toolchain at https://mirrors.edge.kernel.org/pub/tools/crosstool/ 
>> (thanks, Arnd). (so this is gcc 8.1.0)
>>
>> block/partitions/ldm.o: In function `ldm_partition':
>> ldm.c:(.text+0x1900): undefined reference to `strcmp'
>> ldm.c:(.text+0x1964): undefined reference to `strcmp'
>> drivers/rtc/rtc-proc.o: In function `is_rtc_hctosys':
>> rtc-proc.c:(.text+0x290): undefined reference to `strcmp'
>> drivers/watchdog/watchdog_pretimeout.o: In function `watchdog_register_governor':
>> (.text+0x142): undefined reference to `strcmp'
>>
>>
>> Adding #include <linux/string.h> does not help.
>>
>> Is this a toolchain problem or drivers or something else?
>>
> 
> This gcc build was apparently configured like so:
> 
> /home/arnd/git/gcc/configure --target=m68k-linux --enable-targets=all 
> --prefix=/home/arnd/cross/x86_64/gcc-8.1.0-nolibc/m68k-linux 
> --enable-languages=c --without-headers --disable-bootstrap --disable-nls 
> --disable-threads --disable-shared --disable-libmudflap --disable-libssp 
> --disable-libgomp --disable-decimal-float --disable-libquadmath 
> --disable-libatomic --disable-libcc1 --disable-libmpx 
> --enable-checking=release
> 
> In my own cross toolchain builds strcmp comes from glibc but this 
> toolchain has no libc at all.
> 
>> help?
>>
> 
> Linux will use the strcmp in lib/string.c unless __HAVE_ARCH_STRCMP is 
> defined in the arch headers. Grep suggests that m68k, mips, x86, xtensa, 
> arc, sh, arm64, s390 all define that macro. But maybe you could just patch 
> out that definition for build testing.

Sure, that works.  Thanks.

-- 
~Randy