Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6513762imm; Mon, 23 Jul 2018 20:41:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfkLyIaQrl9ep4VuNgR0RDy/riQcFF5kd2/hsn/bs4OpjSJwi6Z5LbIAk3K1LKbABvMk4ZT X-Received: by 2002:a63:4924:: with SMTP id w36-v6mr14797093pga.143.1532403688796; Mon, 23 Jul 2018 20:41:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532403688; cv=none; d=google.com; s=arc-20160816; b=JVpy346q9/JsANF5Fb8GM+Wwf3VJui2D4sF/KxmGNIwU12W1X9qoICmH7x0V8N6Lum CUGGl70hykBtvKAOcD7btAtvAe0zOEfxFb80qKAJUi98vCH0Z2wkWJVRc5ho1P2O5UYM 1qRQkArWpFVa+xgOtg7BYtOW/NfiGBJ8exSYGccCZRqz8qOnrDoQ4mkO6NXB01YmcrS0 7KI9wIDg7gPouyQ8a2SnrBcrYB+XsR7rhl0/yQ7crpY6c1kvCtem2ABjNnjwsCz9xC+0 3+AwUsnrwKIAKdvVW4lO9G7KEHrU/nIXR0CIJUl2c75NzyfCBXZc7pVA4UWbqmI077ra HBEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature:arc-authentication-results; bh=DrbTyXy1O78Cpgpso8MkdBnIbR7lqRMcVlE+5Mfl7lw=; b=dTB82RJGfqiP9yYvGlnyNzMIgxX0yfPUqca+6uT4DqBdKvVYugMy6fCqHFw6Z1myiL 5RmdojHuamE7q4moMiOQvkj2y/9EihTCwHV6YsJzIUO4boa/VL04UIRWtluyZsa5gx4q wkwRJtzy7Rmx+oMr0hHzmezKw3G5h6KF+CFRp97kcC63tVs7qo60Szz9TgaxWaDgSXyK AI2tuKMPiEAFs2bUwkDDVGfE/ujCg51l6dphTooIsYv6nbQPIxDx5Zka2pCYF/vZfXOI iirbsh3v87YGn0jJOynlugh3n5AlxTRKi8PZkpdyiF5xAvfwlVeR1AengVwy7rbgUQOU sOHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=UqbhDM5T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p129-v6si10103615pfb.145.2018.07.23.20.41.13; Mon, 23 Jul 2018 20:41:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=UqbhDM5T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388315AbeGXEoq (ORCPT + 99 others); Tue, 24 Jul 2018 00:44:46 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:41872 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388130AbeGXEop (ORCPT ); Tue, 24 Jul 2018 00:44:45 -0400 Received: by mail-qt0-f193.google.com with SMTP id e19-v6so2839116qtp.8 for ; Mon, 23 Jul 2018 20:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=DrbTyXy1O78Cpgpso8MkdBnIbR7lqRMcVlE+5Mfl7lw=; b=UqbhDM5Twc4PbzCYsNo70TghfE34QGkYDU6lFXspDkoullbKKEMC7/jsTCX++w4yD8 aWlpWQ4z5k8yJhRLJpBHVcqguNcqO7rG7CawCqXNlWEZc6d4f224xE10uIjCca9/JODN OcCNHaAaXmVLOwSxhas6GC1A60CLWKhosp/DIxuskaQTODzFjuocdGnqhTsS4Pnm7e6O uQ1GdYJmdOS9C7qfgnIhAFEJhN8+nzqFUTV9usdyiLux/F8mZhAmzy6rMTdyJ+Vx0ia0 Jw7+FqiJ38XLyHu1YMPr4n4LMr3HkzFzKDiRGT9CZ3uhNIxiTtnnq81PegEWOoIWTNYh YClQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=DrbTyXy1O78Cpgpso8MkdBnIbR7lqRMcVlE+5Mfl7lw=; b=h1FC61fLawFF2TwzN3vDH5aQ7/ehaz2y7uUVyep7cpaHBidTZXi0d8Mu8Fw0ly3eq7 aFKFoBUwShTK3xQZ7ITTVMxbu50HUe550TVQY23Enp7+rNmOos7posiACw2m4jHqIrcr ggKXuZFsSMiEAoVS4WvLDOQu4mnMf9eYvERwl9S65FRqeJsqK0vjCjq2cUpScWuYIC7J UDVHFJnPF9jH2GOIOMib0kpJ+NQxOOXlyiubko1zr4m3GNZjpJeqQ6qcc12nIyZ4cZec MeJ3REDoMmlYCPM2bC5YpN4GMMw8a007ty0TOu6if9p8cYo0fYp/8xtLQ1wy3/Qz+iDr YetA== X-Gm-Message-State: AOUpUlEXzUE3nnd7IYTnKO8DAI7dgl6j28BKCcJ47qA3qceodntPR/To IXPuV6mstJmoUqA8SHtdJ9CxbQ== X-Received: by 2002:aed:36a9:: with SMTP id f38-v6mr15252947qtb.64.1532403623702; Mon, 23 Jul 2018 20:40:23 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d12-v6sm6955085qtp.6.2018.07.23.20.40.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 20:40:23 -0700 (PDT) Date: Mon, 23 Jul 2018 20:40:19 -0700 From: Jakub Kicinski To: YueHaibing Cc: , , , , , , , Subject: Re: [PATCH bpf-next] bpf: btf: fix inconsistent IS_ERR and PTR_ERR Message-ID: <20180723204019.5cb5e753@cakuba.netronome.com> In-Reply-To: <20180724025524.22012-1-yuehaibing@huawei.com> References: <20180724025524.22012-1-yuehaibing@huawei.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jul 2018 10:55:24 +0800, YueHaibing wrote: > Fix inconsistent IS_ERR and PTR_ERR in get_btf, > the proper pointer to be passed as argument is '*btf' > > This issue was detected with the help of Coccinelle. > > Fixes: 2d3feca8c44f ("bpf: btf: print map dump and lookup with btf info") > Signed-off-by: YueHaibing FWIW: Acked-by: Jakub Kicinski Thanks!