Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6582520imm; Mon, 23 Jul 2018 22:32:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpePqbLKrtvUsHSA543R+bU0LtcPLuXIaDamDdIDg7IPjmV3T9lbRq5bgwkfNDjWmMS4w47o X-Received: by 2002:a63:e516:: with SMTP id r22-v6mr3756334pgh.170.1532410335847; Mon, 23 Jul 2018 22:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532410335; cv=none; d=google.com; s=arc-20160816; b=g5T6k8ZCtcgRt1z3HONlPFG9M9hZfKlwTkoTdHQUNsmH8hX4JpKXZyZ39q2sFSHe8q A7HrvU/F41ax9RkZmbav8LWNpr2xfgnAfwWiN2Sy37rJZosBAfhfuZttJyRxQIGieech n8L+IVnZuDO9sko1OavUUyzudqXTua+gTDn+62Ji/kM3gQU9/cmQnskcL9LAZ71fFhvN W/Wl1Qu/pgCFz561dQ/N6/uMBMYcQQDD5iSLC1VtH0Q8LajP5y/kxQNQmCbghEPdvhVS ngFvQhhjS1l7U4QGtvfj7ovBus5ClFx82BNpzDZJItvxSBAXiQHdwwY1fnowiw15uF8s MTlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=3JmLs8kOndAfAA+Yg25L9NABckKvljFA6zCDZdb63eg=; b=LLGxmrZTghFLxJQwvVqj91PYmL1QLn57zGOBaVqHjcF6k44cFRWpSuN+DcABLmysz6 mrtsw5Dyc8FG9sUcRH2Op7u6yP9ICxof1PfagGdHmEJbEIcB1c+80qOF2A892pkrlnlj mSujsqvaTfaUmniffeXXcZIkokxriHtznklsnarcj88f8HdaH7RoeCcbzabTAnKCiMov o88ReCsxHg5bOc3ntnUSSZ5NWlsLkWW4tyHIn8VrCKTbdX3JE3palFaHccwAs5SITfo8 m8rMUxV40Qdywm9BSqJary6Gbo3hzIORF+Vm6p9YBLV6XYQ5S22/aP5rHU7oVrMDtL9B jG2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d34-v6si9565143pld.252.2018.07.23.22.32.01; Mon, 23 Jul 2018 22:32:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388264AbeGXGf2 (ORCPT + 99 others); Tue, 24 Jul 2018 02:35:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:32922 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388146AbeGXGf1 (ORCPT ); Tue, 24 Jul 2018 02:35:27 -0400 Received: from localhost (LFbn-1-12238-233.w90-92.abo.wanadoo.fr [90.92.53.233]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 0655B516; Tue, 24 Jul 2018 05:30:45 +0000 (UTC) Date: Tue, 24 Jul 2018 07:30:42 +0200 From: Greg KH To: Georgios Tsotsos Cc: devel@driverdev.osuosl.org, jhogan@kernel.org, linux-kernel@vger.kernel.org, aaro.koskinen@iki.fi Subject: Re: [PATCH] Staging: octeon: Apply Licence and resolves warnings according to TODO list. There are also a few "checks" that probably should revised but i think most of them could be resolved by breaking down cvmx_usb_poll_channel() Message-ID: <20180724053042.GA13338@kroah.com> References: <20180723222117.542-1-tsotsos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723222117.542-1-tsotsos@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 01:21:17AM +0300, Georgios Tsotsos wrote: > Signed-off-by: Georgios Tsotsos > --- > drivers/staging/octeon-usb/octeon-hcd.c | 55 ++++++++++++++++++--------------- > drivers/staging/octeon-usb/octeon-hcd.h | 1 + Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot