Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 24 Jul 2018 07:55:58 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <228cdf6fe37298223d77b52fd4cdb821b0da7d11.camel@lynxeye.de>
References: <20180720075515.26852-1-marcel@ziswiler.com> <228cdf6fe37298223d77b52fd4cdb821b0da7d11.camel@lynxeye.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH] drm/tegra: hdmi: probe deferral error reporting
To:     Lucas Stach <dev@lynxeye.de>, linux-tegra@vger.kernel.org
CC:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Jonathan Hunter <jonathanh@nvidia.com>,
        David Airlie <airlied@linux.ie>,
        Thierry Reding <thierry.reding@gmail.com>
From:   Marcel Ziswiler <marcel@ziswiler.com>
Message-ID: <537EF05F-3718-45F6-B536-11CAC5BE82C5@ziswiler.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On July 23, 2018 10:49:15 PM GMT+02:00, Lucas Stach <dev@lynxeye.de> wrote:
>Am Freitag, den 20.07.2018, 09:55 +0200 schrieb Marcel Ziswiler:
>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>> 
>> Actually report the error code from devm_regulator_get() which may as
>> well just be a probe deferral.
>
>This is still noisy, so while you are changing this I would prefer if
>this wouldn't print the error message if it's a simple probe deferral.

Yeah, trust me, I'm not the inventor of this probe deferral disaster!

>Suppressing the log message in that case gets us much cleaner kernel
>logs, where real errors stand out.

Ok, agreed. Will send a v2.

>Regards,
>Lucas
>
>> 
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>> 
>> ---
>> 
>>  drivers/gpu/drm/tegra/hdmi.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/tegra/hdmi.c
>b/drivers/gpu/drm/tegra/hdmi.c
>> index 0082468f703c..94c182dbb6d0 100644
>> --- a/drivers/gpu/drm/tegra/hdmi.c
>> +++ b/drivers/gpu/drm/tegra/hdmi.c
>> @@ -1693,14 +1693,16 @@ static int tegra_hdmi_probe(struct
>platform_device *pdev)
>>  
>>  	hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi");
>>  	if (IS_ERR(hdmi->hdmi)) {
>> -		dev_err(&pdev->dev, "failed to get HDMI regulator\n");
>> -		return PTR_ERR(hdmi->hdmi);
>> +		err = PTR_ERR(hdmi->hdmi);
>> +		dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", err);
>> +		return err;
>>  	}
>>  
>>  	hdmi->pll = devm_regulator_get(&pdev->dev, "pll");
>>  	if (IS_ERR(hdmi->pll)) {
>> -		dev_err(&pdev->dev, "failed to get PLL regulator\n");
>> -		return PTR_ERR(hdmi->pll);
>> +		err = PTR_ERR(hdmi->pll);
>> +		dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", err);
>> +		return err;
>>  	}
>>  
>>  	hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");