Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6605221imm; Mon, 23 Jul 2018 23:04:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeUzDq/j1aRhyfVSoXuBWyHKBS/XJGXQccxNYej7aiBxe3EuilFErzmyUxAWH5lOR3sOI5M X-Received: by 2002:a63:9311:: with SMTP id b17-v6mr15036728pge.261.1532412246082; Mon, 23 Jul 2018 23:04:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532412246; cv=none; d=google.com; s=arc-20160816; b=Vqhr3NPkMfxM0eWm5aSryh7Wa/YbZt4F2DyF+zv30Luv//2oYhr5YljCIswrUKBkDQ uZ7tTxAybY+WY/zeO5RtjMF3sxm8dE2aNQwMpGaPMdi0U5FtWOHPduUOAZY04fhKBund DFeEQHqe1UhSPYQkcL0801ckzQSSJ0/EWEpARfbpJRuLs8glgc20b3pcQoliBXydamrp J6MhSkevomkThZVy6E3e2XyVYeFeeQhSVvD9ol3t7Zql8TrhyQtx63XAQGamISW601Q/ oZfiEDgOx/DFyFlyOOZAF738PMEjEcCA6Jl0MJB5lp96sC9da5L69QGMpM4RBJLeflFM 6yDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=X9TSpa+yZLOyVCcyylX0Iyd952jKY2lVmGA4ceu3P/8=; b=vJj+NmxfULys7zSBmzVexP0gu5sl5vVjWjb7WHIzPoi2uLOVX7FwBpXo+pobRuhLyc GC218nvzvvbj3AKt20GyHlQWeEg6T702LuTSdOdi464zfyLD64cwzTizS6Gft6crm88g DXTIphYUbzW0Eiey/QquJRMO9KtOpmDA7a6Hp19OhjviBGM63YrtVIqfzbvo8TRImV6l AT0+/CqoiEiWxytyH/7H1BhXgy+yiMW8ibIWK9cM/sC4ttJnH72TI78p7Iq5NVnqULMq utAoA5DOZ+MnXaQHOtlLftrRZOEP1z70WpyrC4LxxLc1nwBw8Ozy0atm/eXAD6YPvJZt 2xKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14-v6si11048557pfk.275.2018.07.23.23.03.51; Mon, 23 Jul 2018 23:04:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388284AbeGXHHt (ORCPT + 99 others); Tue, 24 Jul 2018 03:07:49 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50506 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388207AbeGXHHt (ORCPT ); Tue, 24 Jul 2018 03:07:49 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 431BC40201A3; Tue, 24 Jul 2018 06:03:02 +0000 (UTC) Received: from localhost (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 609D616871; Tue, 24 Jul 2018 06:03:01 +0000 (UTC) Date: Tue, 24 Jul 2018 14:02:57 +0800 From: Baoquan He To: Chao Fan Cc: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, keescook@chromium.org, yasu.isimatu@gmail.com, indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com, douly.fnst@cn.fujitsu.com Subject: Re: [PATCH v4 1/4] x86/boot: Add acpitb.h to help parse acpi tables Message-ID: <20180724060257.GE6480@MiWiFi-R3L-srv> References: <20180723092908.32656-1-fanc.fnst@cn.fujitsu.com> <20180723092908.32656-2-fanc.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723092908.32656-2-fanc.fnst@cn.fujitsu.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 24 Jul 2018 06:03:02 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 24 Jul 2018 06:03:02 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi chao, On 07/23/18 at 05:29pm, Chao Fan wrote: > In order to parse ACPI tables, reuse the head file linux/acpi.h, > so that the files in 'compressed' directory can read ACPI table > by including this head file. > > Signed-off-by: Chao Fan > --- > arch/x86/boot/compressed/acpitb.h | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 arch/x86/boot/compressed/acpitb.h > > diff --git a/arch/x86/boot/compressed/acpitb.h b/arch/x86/boot/compressed/acpitb.h > new file mode 100644 > index 000000000000..f8ab6e5b3e06 > --- /dev/null > +++ b/arch/x86/boot/compressed/acpitb.h > @@ -0,0 +1,7 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#include > + > +#define ACPI_MAX_TABLES 128 > + > +/* Function to get ACPI SRAT table pointer. */ > +struct acpi_table_header *get_acpi_srat_table(void); Since acpitb.h includes so few lines of code, not sure if we can move them into .c files directly. By the way, you might need to rebase this patchset on top of tip/x86/boot. Thanks Baoquan