Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6719151imm; Tue, 24 Jul 2018 01:40:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdy/EMRHwRizgVtQl9PM1xv1HUdFgt7GfL3HqUm9C4VYyy05NBTQHBb5/bP2NQDdtzO+MuC X-Received: by 2002:a63:1e66:: with SMTP id p38-v6mr15305493pgm.376.1532421616285; Tue, 24 Jul 2018 01:40:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532421616; cv=none; d=google.com; s=arc-20160816; b=T7nU/n6Ywpj3a2RfRHWOJ1ONd8iRicJq3Rh92DmuI/XIUO6NbakME2VAfjOqqXBLj/ 40j0VsqwIZgyvsA8GEVujgjp56O1MCij/ZBV9l3OT17ouA9DDqi3C0Cs6CrMt80aHb7U cEKz3Q3RS1ft2fQm3JLCU85TjkBuA1TDmz/52JXUDTGpt4QX+2HFE+EwwzfvJsCMR4uP TBuaiCDWedGvBYYBGIc6g30tM0HUCT0djm+JAP2BYfDb2rIv4jhNwpDwD7Alk2n5Ipdp e+QVgwAaWbpUyk8zm5dcoYQgfwDHsoek2V6Ft+uTkoBv6+xqrDXHQKZeXxDINNqG1PsP Szgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=gUaizZNkqGkglD9r7IFWhoN6GTl3LF8B3OWYfvSTx1k=; b=CjW6SSvLvdA8HaUIj6grXXfsmfSHNASlSQUnyMGQTDqVA2O3xJEmRLyb+nvXd0zPri NR0YieuLaRDlFgyVjtpw0g4PzBbPySOE6Z8yKRPH7GoYfQG9IEtRZ8vdCN7vJaIhZJqm 1cYLSScG0npkWL3P0yyWXuOdk2uxkHojO6UTCJWEXt8CTbaO5fFoqxSAXWdYdkaXkkbg Ze874KZ1XYWJkpBxLcNgEh4IYtJ+crx1dfOg5mLTWiNlQ9NMsbdMHajRsmObRKdT85P7 Ix1YcIEBWds+pKplM1WP5D2qwoPq63TtpLDhTW3NzEPAvKqhy8sqQxhptuCc3g5L0CqM DXaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x4-v6si11033979pga.320.2018.07.24.01.40.01; Tue, 24 Jul 2018 01:40:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388609AbeGXJo1 (ORCPT + 99 others); Tue, 24 Jul 2018 05:44:27 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:12480 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388559AbeGXJo1 (ORCPT ); Tue, 24 Jul 2018 05:44:27 -0400 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="42590124" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 24 Jul 2018 16:39:01 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 283FE4B66A39; Tue, 24 Jul 2018 16:38:59 +0800 (CST) Received: from localhost.localdomain (10.167.225.56) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.399.0; Tue, 24 Jul 2018 16:38:57 +0800 Date: Tue, 24 Jul 2018 16:36:57 +0800 From: Chao Fan To: Baoquan He CC: , , , , , , , , , Subject: Re: [PATCH v4 1/4] x86/boot: Add acpitb.h to help parse acpi tables Message-ID: <20180724083657.GB818@localhost.localdomain> References: <20180723092908.32656-1-fanc.fnst@cn.fujitsu.com> <20180723092908.32656-2-fanc.fnst@cn.fujitsu.com> <20180724060257.GE6480@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180724060257.GE6480@MiWiFi-R3L-srv> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [10.167.225.56] X-yoursite-MailScanner-ID: 283FE4B66A39.AB313 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 02:02:57PM +0800, Baoquan He wrote: >Hi chao, > >On 07/23/18 at 05:29pm, Chao Fan wrote: >> In order to parse ACPI tables, reuse the head file linux/acpi.h, >> so that the files in 'compressed' directory can read ACPI table >> by including this head file. >> >> Signed-off-by: Chao Fan >> --- >> arch/x86/boot/compressed/acpitb.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> create mode 100644 arch/x86/boot/compressed/acpitb.h >> >> diff --git a/arch/x86/boot/compressed/acpitb.h b/arch/x86/boot/compressed/acpitb.h >> new file mode 100644 >> index 000000000000..f8ab6e5b3e06 >> --- /dev/null >> +++ b/arch/x86/boot/compressed/acpitb.h >> @@ -0,0 +1,7 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#include >> + >> +#define ACPI_MAX_TABLES 128 >> + >> +/* Function to get ACPI SRAT table pointer. */ >> +struct acpi_table_header *get_acpi_srat_table(void); > >Since acpitb.h includes so few lines of code, not sure if we can move >them into .c files directly. > >By the way, you might need to rebase this patchset on top of >tip/x86/boot. Sorry Baoquan, I tried to add this patcheset to the tip/x86/boot branch using both 'patch' command and 'git am'. I found no problem and no offset. So is there some problems when you use them? Thanks, Chao Fan > >Thanks >Baoquan > >