Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions
To:     Lee Jones <lee.jones@linaro.org>,
        Daniel Schultz <d.schultz@phytec.de>,
        linux-rockchip@lists.infradead.org
Cc:     zyw@rock-chips.com, zhangqing@rock-chips.com, xsf@rock-chips.com,
        tony.xie@rock-chips.com, linux-kernel@vger.kernel.org
References: <1522335000-23057-1-git-send-email-d.schultz@phytec.de>
 <20180416093821.sqrcc6mmnc23njul@dell>
From:   Wadim Egorov <w.egorov@phytec.de>
Message-ID: <ac1420fa-7916-813e-a4ef-b7ea403e275b@phytec.de>
Date:   Tue, 24 Jul 2018 11:39:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180416093821.sqrcc6mmnc23njul@dell>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Am 16.04.2018 um 11:38 schrieb Lee Jones:
> On Thu, 29 Mar 2018, Daniel Schultz wrote:
>
>> Since all three shutdown functions have almost the same code, all logic
>> from the shutdown functions can be refactored to a new function
>> "rk808_update_bits", which can update a register by a given address and
>> bitmask.
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>> Changes:
>> 	v2: Re-submit with recipients from Rockchip.
>> 	v3: - Added devicetree property to enable the PMIC reset seperate from 
>> 	      "rockchip,system-power-controller".
>> 	    - Dropped the first patch of this serie.
>> 	v4: Splitted refactoring and the new reset feature.
>> 	v5: Removed null pointer from rk808_update_bits.
>>
>>  drivers/mfd/rk808.c | 46 +++++++++++++---------------------------------
>>  1 file changed, 13 insertions(+), 33 deletions(-)
> I'd still like an Ack/Review from the Rockchip guys please.
>
can someone from Rockchip reply to this?