Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6846719imm; Tue, 24 Jul 2018 04:16:04 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdTJeDf5Fsya3TNjRUrUvgwNJ2dGNXWFMHcqGMlKpeKvrDQfNdue/Bgt9J44DQ4qlg+lpeq X-Received: by 2002:a62:9645:: with SMTP id c66-v6mr17408785pfe.56.1532430964367; Tue, 24 Jul 2018 04:16:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532430964; cv=none; d=google.com; s=arc-20160816; b=Lhm5jVXFuGH023VTE0ET8krjNFa1TgK2OX3zBKq/mL4g9QVecJkg5UoDi1+lS65ZN3 pR/7XmIaYGHIqQBS0WuM1cBkrofKHK9aPVWVZBYNanBeSzmV0qyJ0fYrIRestvkrvXo5 5CU60Wfes4RfwUFGzrOgarS0OkzWYwsfO5ImQxNTKomSarO9PI1+KoK5CWKYkcyRxcX6 LF1DhnMSL1jB8q3pW73EpJKvd51ZXKNpbh45/rc5FpqSgP4xh2EXQcrgNB3i1Wseec3q dekVp87+VvjLP+sZOq2agXQCnHGJ/EhRd5WjvcfCV0t3rXxgLH6+0GU4dNSV+sc8I8OD /XnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=LGHltUa+4XbgFnAGSYQ8WjuLRULtr9GAkTv5DlGLJ0w=; b=VX0wJHme4/K9jZcYA+Nz23yC4X2m15EKas2Z7EqeF9Bhy7zMiHm7aMdNDx5/XyOY4r hOvy8iMnGvqwmkjB1u01dJb+NeIufQM6iDCHcIILV9YPsoLbZjJL8eeb24w5IYrargDq f2Mwmxh9sUAgRgkU5LFWepbUQW7fimtTvTPI5y3iHb/famZwrBn8Oj+vKsFqP9wejxdj GUelLH3+CdYP97kQPPu9zI/DuigC09wVtPv3qNZlTZorS6e1Hkdll8qld+k9CNzQokDF 4BlM/dUjbQd1dTYyC91irnSjGZznz9qYest8HCZEn/1f7kQkzFOHSc9BhokGIVIqGIQC vH1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=OugJTgFr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj4-v6si10537025plb.119.2018.07.24.04.15.50; Tue, 24 Jul 2018 04:16:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=OugJTgFr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388677AbeGXMUr (ORCPT + 99 others); Tue, 24 Jul 2018 08:20:47 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:55455 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388360AbeGXMUr (ORCPT ); Tue, 24 Jul 2018 08:20:47 -0400 Received: by mail-wm0-f68.google.com with SMTP id f21-v6so2123184wmc.5; Tue, 24 Jul 2018 04:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LGHltUa+4XbgFnAGSYQ8WjuLRULtr9GAkTv5DlGLJ0w=; b=OugJTgFrOv2EJl+8G5l9My+J7L5mjGneUeCM6VLc9PBDgKbHrOhAqMBkwM3NkQ5Nmu BmB93U1qo75dv5KIl/ef9T6hewwfU87n5m1hoiu7cHPcNbtgd2b03eConPakZsTKpD1T eVoS7QVCSH+SlOF4DxXjBMH5uzJgWWS3hJAUSiFFWRgrBpNIUFAPO/pdvGSdXICKxqle 9LG081VRGBqi8l2lH0orBApb1Hr3eCoBlQVNwopF96LW/7CUzzP6ULqUy5m/ec8iIJYH H81uYIe6SBGk6WEE/33RNl9G0uJqi4S+TgQBhe4dH3no7qHE/l/9LxV5DsZ6OBe5kbXF 9HjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=LGHltUa+4XbgFnAGSYQ8WjuLRULtr9GAkTv5DlGLJ0w=; b=VLp2VvP2xj62utGBIhs2YM1S21IRoRt7bsLTRis2Uq8LHk2JSlqG1lXeWjJmgKFKo9 yQN+qhBDPzDUtPEO+hZbesG+HrnmtXTUS+xQvSUtzZq2wWM66tM+icppvyzLx8Gg4gm9 5V0gKGHYzUznxuGaEoHB8Xd6v/3W5b2EgAquufktGTyPwmHNvCpwWA4ssKb/d8cofrwu abnDa8ha8Cd42mZDsHvYD2I0KCWt+vV3Niv2UVpPBeQc3+R3bOK89iyoxLz4CQKrynZQ eeA2GAQHEtBcreuHQGNup2FG9AcfPBHAXkD8YaaSg4cPuWBxGxNBLXScGUjGOGpJn+Ha utwg== X-Gm-Message-State: AOUpUlFXsAhQ6ZbpdaVXloa0tZZOECMVeajfuJYLEEUaHozZEGfy8BaA NCrxUBfRYnYITMZWqwJgFWU= X-Received: by 2002:a1c:b586:: with SMTP id e128-v6mr1573907wmf.141.1532430888542; Tue, 24 Jul 2018 04:14:48 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id z3-v6sm9228192wru.27.2018.07.24.04.14.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 04:14:47 -0700 (PDT) Date: Tue, 24 Jul 2018 13:14:45 +0200 From: Ingo Molnar To: Masahiro Yamada Cc: Nadav Amit , Linux Kernel Mailing List , X86 ML , Sam Ravnborg , Michal Marek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kbuild mailing list Subject: Re: [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm Message-ID: <20180724111445.GB14212@gmail.com> References: <20180622172212.199633-1-namit@vmware.com> <20180622172212.199633-2-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Masahiro Yamada wrote: > 2018-06-23 2:22 GMT+09:00 Nadav Amit : > > Using macros for inline assembly improves both readability and > > compilation decisions that are distorted by big assembly blocks that use > > alternative sections. Compile macros.S and use it to assemble all C > > files. Currently, only x86 will use it. > > > > Cc: Sam Ravnborg > > Cc: Masahiro Yamada > > Cc: Michal Marek > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: x86@kernel.org > > Cc: linux-kbuild@vger.kernel.org > > Acked-by: Peter Zijlstra (Intel) > > Signed-off-by: Nadav Amit > > --- > > > > Acked-by: Masahiro Yamada > > > > > > Makefile | 9 +++++++-- > > arch/x86/Makefile | 11 +++++++++-- > > arch/x86/kernel/macros.S | 7 +++++++ > > scripts/Kbuild.include | 4 +++- > > scripts/mod/Makefile | 2 ++ > > 5 files changed, 28 insertions(+), 5 deletions(-) > > create mode 100644 arch/x86/kernel/macros.S So this patch appears to break the xtensa cross-build on my system, with an older version of crosstools: MODPOST vmlinux.o /home/mingo/crosstool-korg/bin//gcc-4.9.0-nolibc/xtensa-linux/bin/xtensa-linux-ld:./arch/xtensa/kernel/vmlinux.lds:430: syntax error /home/mingo/tip/Makefile:1010: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 make[1]: Leaving directory '/dev/shm/tip/build' Makefile:146: recipe for target 'sub-make' failed Thanks, Ingo