Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp7008380imm; Tue, 24 Jul 2018 07:00:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdP5cqEGaOoDl+2v6uwOWbrfBWILahGDAh2IxkRtmsZdzYIXD9Eqbs0Zk7PwPWUWCC/ZvV6 X-Received: by 2002:a17:902:9687:: with SMTP id n7-v6mr16764389plp.33.1532440854876; Tue, 24 Jul 2018 07:00:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532440854; cv=none; d=google.com; s=arc-20160816; b=Ss3wEngffFhffVfMxzOrWJGyfU+paLt7/RLiXk0IaZ0CxtS7aHo4E4G1Y/bWx26WtQ z3o0MmbuQiLT4/YNXfQP019W46bMiVjAd49ln1A0Zhry4z85UueLWpMs+jvGt4P1mN0E GRlQeOiR+xhe3qhqcWPWnU/M64S37uvJJ1jXoXlhH+YKcQBtb5mTtieHWLoPFk2mM12j dgL7f7tyDVnUVln2pVi15YGHADXShqnDrNxBVBfIjVl3VmCRMf/Lnj4hO9Nb5+sBlrD8 SlbPkHqsVuFgM8tck48R7BWvvkIbLsmC1YbWVE6qa3lL6CHpyft50p74QaGbUZpNNNrS cD7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to:arc-authentication-results; bh=G1ARDAYAJCrVhWfFcZVMAHCUUVSRkpCSg6lldG6OSr0=; b=pa7xzxltxN/uTtHDvw2K5OtPGqAW7r6wMcVK+tEA3XZ/5VhYZyNySVAH6+xt4VeOc7 u9KL+cxLhLg6kLBlLa4y1Oel6ybdrV0sKMiLRk0lq23ghRy2sIrH2bdGeBuClnp7FpPW y6Y+6gGEIvPTEGbMU+iM2PVRo3llDagLovtufNLD42KPZeJjdjZjQntcb+Hgej0r9FFM aLzUv+xlia4v6V4G7Q0riHqU01Wy6oYKI66jtkXTj+um90UbAv3KMJRbWuO4LeEtyCTs E5uc5rCxwXPRnhO9JoggfdIYr609NSo7iHzygy7W3l7aDwK/86lNW86ZZULopbxPxkFP PEYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q23-v6si11588130pgl.275.2018.07.24.07.00.39; Tue, 24 Jul 2018 07:00:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388426AbeGXPG0 (ORCPT + 99 others); Tue, 24 Jul 2018 11:06:26 -0400 Received: from ozlabs.org ([203.11.71.1]:58963 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388329AbeGXPG0 (ORCPT ); Tue, 24 Jul 2018 11:06:26 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 41Zg380lfkz9s3N; Tue, 24 Jul 2018 23:59:47 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: bd90284cc6c1c9e8e48c8eadd0c79574fcce0b81 In-Reply-To: <20180430145558.4308-2-npiggin@gmail.com> To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Jiri Slaby , linux-kernel@vger.kernel.org, Nicholas Piggin , Greg Kroah-Hartman Subject: Re: [01/15] powerpc/powernv: opal_put_chars partial write fix Message-Id: <41Zg380lfkz9s3N@ozlabs.org> Date: Tue, 24 Jul 2018 23:59:47 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-04-30 at 14:55:44 UTC, Nicholas Piggin wrote: > The intention here is to consume and discard the remaining buffer > upon error. This works if there has not been a previous partial write. > If there has been, then total_len is no longer total number of bytes > to copy. total_len is always "bytes left to copy", so it should be > added to written bytes. > > This code may not be exercised any more if partial writes will not be > hit, but this is a small bugfix before a larger change. > > Reviewed-by: Benjamin Herrenschmidt > Signed-off-by: Nicholas Piggin Patches 1-9 applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/bd90284cc6c1c9e8e48c8eadd0c795 cheers