Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp7177308imm; Tue, 24 Jul 2018 09:37:11 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcymUND6mqowVwNV40GjZ1urX+1avucp21kcVZ+AiZr7KRGWWZBHjrfcA9W406xoOhanpcj X-Received: by 2002:a17:902:8207:: with SMTP id x7-v6mr17438782pln.57.1532450231138; Tue, 24 Jul 2018 09:37:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532450231; cv=none; d=google.com; s=arc-20160816; b=ghCEERADx524qO55AbaYcd3AqA/g4IoAh/dc5yqG33L5xf5gHWwaSdlTkt+kcWEuQC H18bj5PzgJKQclF9fUxESaRrHY5uxdOIH0DGFJfK8b3WdXqM1vNENh1sIySOy6itQfKt uTpRr79pu33Lx/g9qtC50g74eJXgEv5l9EJvj4BR1p1mstvGMP6ecV2zTSx6akID3DOo G0IkQUf765iG6P8gQKXvwZzbyYQ0HMi4Rjjwki/HzeQcGsiCk0yIDIRNC4y5Kk42nxQl G1yQpnvYp51KahYuCSEpNXOrYv/c2iathgIL0Ec907Ae9etGpoahwaMS8NXT5lKXt9Ry 2kPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=/NvoAYqOqxnK5WATLklkd7YUmmn6pHlkmr1mpfuA+qY=; b=rpOyeVceSUcOlfXu+t3XZQad9DFCtgLf/0zqDyQUYYJW4ksVacpVZWZiSETGvUY8pA wPJkL/Q3nScwLf0HG8rEhcM20IIo+q3gjBlCLhMwN7SnuBMzTF5zpH7qifB3hBf09iZI axgJKCcmxB1hJM+Zizsf+oWCts5rmv5a2H9nvQ/cnpPmZThW8RcfRYft2bEa1OHEaQax O+z7fQSal4NnV5B5VkLsKjLzSIHC2k00YIgTo7xz55TdfodiDkbmjQkqhaujbV9XnVv3 HlhQI6Tz5gPnth82Jgb9yCa0fueUVHdkdRuoorjQODgGJB72O9WDnQjjd3X+PuodCTVd 6UhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11-v6si11201759plb.195.2018.07.24.09.36.56; Tue, 24 Jul 2018 09:37:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388470AbeGXRmh (ORCPT + 99 others); Tue, 24 Jul 2018 13:42:37 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42400 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388324AbeGXRmh (ORCPT ); Tue, 24 Jul 2018 13:42:37 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A372840201A3; Tue, 24 Jul 2018 16:35:19 +0000 (UTC) Received: from treble (ovpn-120-113.rdu2.redhat.com [10.10.120.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20CA92026D68; Tue, 24 Jul 2018 16:35:19 +0000 (UTC) Date: Tue, 24 Jul 2018 11:35:17 -0500 From: Josh Poimboeuf To: Peter Zijlstra Cc: Ingo Molnar , Prashant Bhole , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II) Message-ID: <20180724163517.flt3pmdphvsqbegc@treble> References: <60466ab6-311b-ad8d-2f79-32702174cb95@lab.ntt.co.jp> <20180719153347.buoe6pavpqc75zbb@treble> <20180719174311.GK2494@hirez.programming.kicks-ass.net> <20180719211954.GZ2512@hirez.programming.kicks-ass.net> <20180723133006.7mkzrdeaa4jo56md@treble> <20180723141427.GA2458@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180723141427.GA2458@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20180323 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 24 Jul 2018 16:35:19 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 24 Jul 2018 16:35:19 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jpoimboe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 23, 2018 at 04:14:27PM +0200, Peter Zijlstra wrote: > On Mon, Jul 23, 2018 at 08:30:06AM -0500, Josh Poimboeuf wrote: > > On Thu, Jul 19, 2018 at 11:19:54PM +0200, Peter Zijlstra wrote: > > > --- a/include/uapi/linux/perf_event.h > > > +++ b/include/uapi/linux/perf_event.h > > > @@ -143,6 +143,8 @@ enum perf_event_sample_format { > > > PERF_SAMPLE_PHYS_ADDR = 1U << 19, > > > > > > PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */ > > > + > > > + __PERF_SAMPLE_CALLCHAIN_EARLY = 1UL << 63, > > > > Given the kbuild test robot errors for building on 32-bit, looks like > > the 63 needs to be changed to 31 so it fits in an int? > > I made it 1ULL << 63. The actual field (perf_event_attr::sample_type is > u64). Ok, did you post this somewhere? -- Josh