Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] arm64: enable RapidIO config options in Kconfig
To:     Will Deacon <will.deacon@arm.com>, Alexei Colin <acolin@isi.edu>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Alex Bounine <alex.bou9@gmail.com>,
        Barry Wood <barry.wood@idt.com>,
        John Paul Walters <jwalters@isi.edu>
References: <20180724134513.86796-1-acolin@isi.edu>
 <20180724151458.GE25412@arm.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <71f6f129-4151-1603-10aa-9e600d6389ed@infradead.org>
Date:   Tue, 24 Jul 2018 09:49:51 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180724151458.GE25412@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/24/2018 08:14 AM, Will Deacon wrote:
> On Tue, Jul 24, 2018 at 09:45:14AM -0400, Alexei Colin wrote:
>> ARM64 SoCs with a PCI bus present the RapiodIO options; SoCs with
>> RapidIO IP blocks but without a PCI bus, need to select HAS_RAPIDIO in
>> Kconfig.platforms.
>>
>> HAS_RAPIDIO was chosen over HAVE_RAPIDIO to be consistent with
>> other architectures which already define this flag (powerpc).
>>
>> Signed-off-by: Alexei Colin <acolin@isi.edu>
>> ---
>>
>> Tested that kernel builds with RapidIO subsystem and switch drivers and that
>> modules insert successfully in a custom Qemu hardware model.
>> Maintainers for RapidIO subsystem CCed.
>> Similar patch for ARM has been submitted.
>>
>>  arch/arm64/Kconfig | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 42c090cf0292..8dceaa5b674c 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -293,6 +293,22 @@ config PCI_SYSCALL
>>  
>>  source "drivers/pci/Kconfig"
>>  
>> +config HAS_RAPIDIO
>> +	bool
>> +	default n
>> +
>> +config RAPIDIO
>> +	tristate "RapidIO support"
>> +	depends on HAS_RAPIDIO || PCI
>> +	help
>> +	  This feature enables support for RapidIO high-performance
>> +	  packet-switched interconnect.
>> +
>> +	  If you say Y here, the kernel will include drivers and
>> +	  infrastructure code to support RapidIO interconnect devices.
> 
> It feels a bit weird to push this help text into the arch Kconfig files,
> rather than just have them provide the HAS_RAPIDIO symbol, but if that's
> what everybody else is doing then I guess it's fine.

Both Arnd and Russell King asked for moving CONFIG_RAPIDIO to drivers/rapidio/Kconfig,
and I also think that would be better.

-- 
~Randy