Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp7253164imm; Tue, 24 Jul 2018 10:52:36 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcPVl1gYUXxNnzVv4TPd9D2QkwfkHuWe9VIUMehYCmwWIo35frlCGGa1dosC36Q6u43h6F0 X-Received: by 2002:a65:64c8:: with SMTP id t8-v6mr17222188pgv.110.1532454756662; Tue, 24 Jul 2018 10:52:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532454756; cv=none; d=google.com; s=arc-20160816; b=w5zNDiUS0FnO01oTjvf7FTmYyObe/Gzfu8D1BUiwKacsqfB7be9BkGR/9Gh5Fh9gvH sdAxYtmOlKv5XnfTWLiQB9SHxG+37sv2TaKbplBVqajvlhqKhVAOI9KlZFNL7MH1IY9i U5sHRC1yKJG1KeRK7CHKn0Yi/asIiGlsxr7AwBOYI8TuSDMFRIjamSJLVZAL3e5/iXWb sFk3fjhVMYH8wx5DeH4T9SbaOWK2gbIFYBVatyPMyjvsdHosLuNXwt1TfR0pnGfOaDHX Od1K+nN5mnPIaB0E5UGyXB/jJrXLqW2u8BtUx/CeHGALUG6Z9b7Zh12iWRAWGKSdNC8t 1DyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=rhXdS0JlrmQPOo8uGulR2+QL5OPOPxsKAh847CNTQ/4=; b=SQEM9DFc2sXAlsVljYueV6MUTpnIqrgnkO8/pAS451ZgATqyKCGUTVheTnMQRN6duc nF0HL8MYT1ZOJhCTe00cvYGVCyYSDN1h49LtgjF/Ahwf5/i67ZpGegAQ5MA2Qc3dPiLC IK1+EJoMW6z7NsEdD7nTJKshZrunkx2p74hG71uzfetum9nfBMYzKWqQHhegdrNaJAwd tw5ej6eHkJPZuwsUsZI9N3qYaoDd8r+nhQ6qHwMDgiS3UnmCqp+e/kkDZQcbzSriNasb cPkDMnmr4trReQj/BbEMx3skwJpD2KGQuA13Pf/c+LuTd3KrH1CGPdw8ROj/S7Hqs6XP jg2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=uvsHUZYr; dkim=fail header.i=@chromium.org header.s=google header.b=Vf+e+Qs+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q126-v6si12358751pfb.277.2018.07.24.10.52.21; Tue, 24 Jul 2018 10:52:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=uvsHUZYr; dkim=fail header.i=@chromium.org header.s=google header.b=Vf+e+Qs+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388513AbeGXS7G (ORCPT + 99 others); Tue, 24 Jul 2018 14:59:06 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35921 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388463AbeGXS7F (ORCPT ); Tue, 24 Jul 2018 14:59:05 -0400 Received: by mail-yw0-f194.google.com with SMTP id v197-v6so1854671ywg.3 for ; Tue, 24 Jul 2018 10:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=rhXdS0JlrmQPOo8uGulR2+QL5OPOPxsKAh847CNTQ/4=; b=uvsHUZYrS3sBKeM0HtbKbZ3xPXdcwuJ8AhYPxgqfiCY5Pat3ehrX28d96unQlycbNa i0LeqtVa/LJbw4O3lVzzmVJeImEXsJ1JsooXgp4xv0qVfCa0DvKzh4AUzipkxq8jLyvw SOxuhfnuezIk7S8EGpuTb01X6k3vrO1uwbg5cvbxH14G7YT4l22+T2I3ggwCxhFKyyNU wh/PyC2iYVj2XthzcUe+HHsRZZzn2lbM0xTdry5noPPBOxJnHop+lvwbSOFQrGM0r9D5 vCLLhj4hp6hlAOxhKS1bZBGkd7L2Wv2/dGN9DMIS8a99bb7gfpHC19Ojci/Lv07H9WbN QSvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=rhXdS0JlrmQPOo8uGulR2+QL5OPOPxsKAh847CNTQ/4=; b=Vf+e+Qs+KsB5jzqdQpCFCQsCot8FuZYZaZ4TjtBuLthOrSs/RFLnobhdEb5KI16WX+ 3xzF6qmPGEKT/mB+rjd0tr4zTYU2Gwq+HTC53imQS+bZNxoH6jTMo5SMBCz5PU18uyx5 5bO07SsBlJ2wTLa2dufLbt9zEkIsO7YX7Qfzw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=rhXdS0JlrmQPOo8uGulR2+QL5OPOPxsKAh847CNTQ/4=; b=ZDo0bfSL+3W9cSaS2wIKlgaPF1brGt2U6j2FmjQSSXkQtbqwz5FH8tox1XYe1hPf9/ AtfQWZmRBTTluxG1+y5WXFrruj9vaiiWi75ZQNoh3NbWFqOuShKSeg4HjsBb8d9nZgg4 Fr/oRG9SW3a1OS14DG089z3YmLF0U15znA7HhdZk1FbcE73hOND3qsTdf7rexfcG4Ojk B65ELPZtSkYzwZSvbHRBO3pTMhYMTkx51agKPQr1nXBH63xmrAaG6w7Db0if3FwBoN9C BNPPZRHxM900m1u573e8l+fxerMBG/NudDgUBE4uLv5Udg2xKOm5nOo0xf1IftrcEzUV tvjg== X-Gm-Message-State: AOUpUlHi9Q5O2a17UCkIRMC4IxdydkxLL9RAtQpflS+3GmMynGKECUiz A4QNn10ajZkd9EbiHlPiwKIqWlpTKA9v6Yr6Tr+7xg== X-Received: by 2002:a0d:fa42:: with SMTP id k63-v6mr9750845ywf.53.1532454688449; Tue, 24 Jul 2018 10:51:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:6602:0:0:0:0:0 with HTTP; Tue, 24 Jul 2018 10:51:27 -0700 (PDT) In-Reply-To: References: <20180724164936.37477-1-keescook@chromium.org> <20180724164936.37477-18-keescook@chromium.org> From: Kees Cook Date: Tue, 24 Jul 2018 10:51:27 -0700 X-Google-Sender-Auth: Y-WRmfgZIwyg4O9ztQxJjmQvpZQ Message-ID: Subject: Re: [PATCH v6 17/18] crypto: ccm: Remove VLA usage To: Ard Biesheuvel Cc: Herbert Xu , Arnd Bergmann , Eric Biggers , "Gustavo A. R. Silva" , Alasdair Kergon , Rabin Vincent , Tim Chen , "Rafael J. Wysocki" , Pavel Machek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "the arch/x86 maintainers" , Philipp Reisner , Lars Ellenberg , Jens Axboe , Giovanni Cabiddu , Mike Snitzer , Paul Mackerras , Greg Kroah-Hartman , David Howells , Johannes Berg , Tudor-Dan Ambarus , Jia-Ju Bai , Andrew Morton , Geert Uytterhoeven , Josh Poimboeuf , David Woodhouse , Will Deacon , device-mapper development , linux-pm , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , drbd-dev@lists.linbit.com, linux-block , qat-linux@intel.com, linux-ppp@vger.kernel.org, "" , "open list:ANDROID DRIVERS" , linux-afs@lists.infradead.org, "" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 9:57 AM, Ard Biesheuvel wrote: > On 24 July 2018 at 18:49, Kees Cook wrote: >> From: Ard Biesheuvel >> >> In the quest to remove all stack VLA usage from the kernel[1], this >> drops AHASH_REQUEST_ON_STACK by preallocated the ahash request area >> with the skcipher area (which are not used at the same time). >> > > -EGRAMMAR Whoops. Will fix my poor sentence merging. :) -Kees -- Kees Cook Pixel Security