Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: bisected: 4.18-rc* regression: x86-32 troubles (with timers?)
To:     Meelis Roos <mroos@linux.ee>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Linux Kernel list <linux-kernel@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>
References: <alpine.LRH.2.21.1807041414080.3671@math.ut.ee>
 <CAK8P3a1RkNc_kShHBJ6QENrQheQi=C93DmnknC1S_uJDcTDqww@mail.gmail.com>
 <alpine.LRH.2.21.1807051254050.21817@math.ut.ee>
 <alpine.LRH.2.21.1807151803010.17406@math.ut.ee>
 <CAK8P3a2NtB_FmiSjrzZb=HoshEzo+MP2xwafC3QcMg79rffipg@mail.gmail.com>
 <alpine.LRH.2.21.1807161948380.27791@math.ut.ee>
 <alpine.LRH.2.21.1807162200180.27791@math.ut.ee>
 <alpine.LRH.2.21.1807202339490.8506@math.ut.ee>
 <alpine.LRH.2.21.1807210154100.8506@math.ut.ee>
 <CAK8P3a19pCbn5Ns0jVqGTiSmGj4AOgjWL0CQtAA-sYRqY4Gvjw@mail.gmail.com>
 <32227088-7754-c160-8046-e860f42ca91c@iogearbox.net>
 <alpine.LRH.2.21.1807232322430.11834@math.ut.ee>
 <4a48811d-4094-ee4c-33ca-2cf0446a6313@iogearbox.net>
 <alpine.LRH.2.21.1807240744570.11834@math.ut.ee>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <bc29beb2-f4c5-3d6c-2b64-1c0e11af4241@iogearbox.net>
Date:   Tue, 24 Jul 2018 20:40:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <alpine.LRH.2.21.1807240744570.11834@math.ut.ee>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/24/2018 06:47 AM, Meelis Roos wrote:
>>> Anyway, I started compile of v4.18-rc5 that was the latest I tested, 
>>> with the commit in question reverted. Will see if I can test tomorrow 
>>> morning. But I will leave tomorrow for a week and can only test further 
>>> things if they happen to boot fine (no manual reboot possible for a 
>>> week).
>>
>> Ok, thanks, please keep us posted on the outcome with the revert. Right
>> now I would doubt it's related resp. changes anything on the issue, but
>> lets see.
> 
> v4.18-rc5 minus the patch in question worked fine on 2 bootups so it 
> seems to be good.

And this was with CONFIG_BPF_JIT_ALWAYS_ON=y, correct? Could you try the
same with this below applied:

diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c
index 5579987..313c983 100644
--- a/arch/x86/net/bpf_jit_comp32.c
+++ b/arch/x86/net/bpf_jit_comp32.c
@@ -175,7 +175,7 @@ static const u8 bpf2ia32[][2] = {
 #define SCRATCH_SIZE 96

 /* Total stack size used in JITed code */
-#define _STACK_SIZE	(stack_depth + SCRATCH_SIZE)
+#define _STACK_SIZE	(stack_depth + SCRATCH_SIZE + 4)

 #define STACK_SIZE ALIGN(_STACK_SIZE, STACK_ALIGNMENT)


Thanks,
Daniel