Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp10770imm; Tue, 24 Jul 2018 13:01:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe6Dfa81jqODKOgHoqNDH+MsjeE2YeSUylvFFSw45CRl6jLTsxBAmjh0tPfNjXl7pbKyAkm X-Received: by 2002:a17:902:b709:: with SMTP id d9-v6mr18431023pls.138.1532462494972; Tue, 24 Jul 2018 13:01:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532462494; cv=none; d=google.com; s=arc-20160816; b=mrQgNJMTfGAjxW6mAmR/gkjQTr45Wmzbyo8LtOu9bUBITORHIboH7EE13vfAmf/o9x XdZvxQj7JLDqLSHBIt5m4JzFM4EuSZJrWJdpYIv4wucurapWfosnxD+rJRtKuN7bgzjl Bk+//SaRvdSLN1MIvdlx4vEsWXT/MlT04qDszNC/si6vZJ/IetmtsIzo1EhfYBrnhYH0 ydlj9Z6CrNEIEQunXzLjALcK5Al5w/oAJv+FnXpIYjF7lz6uUbubA6I6KnQ3xPk+/Esk QMh8tnuhn0g4JfCZs8MNvDATo7XTmGeiO7C0Ig+ufr+k4dxcDId0Mut2+2y0UR4hnEPw ZH2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=afsmkqbzM0laTKBiD5uerJtPWgYnNA5ry00NwSH90a4=; b=nsp0jKQFrKa0rAMxn1q59saWRIL+7z+QRMtOb8NtmMCJsSDa/m1u3KB191PxcPgY/j S0NXEv+OvWrk9FKi0t+bgwh5GHjewgzTXs+oqI1oyO1NvEaRBAm+2io8Jxjuc90QdkxD /XnmaTCVv4ZXznPlccG05qPlNWDHWUkNKbDEblxbo2VBtgP26eCNSjHVQ6wfwhA7Em6+ JNrQUboC3gIMB07kRaOTlzLOZGmtti6d8M2n4WqXpcgsAaUSgHwyCDRVxhTwQDBAAIUe T7xFEsfsH7e4/MOUmP1RhooDTeH4qyw/3gMP95I57Mi2YC5gNdbN0VQpCaisnNnqZYH4 HP3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=PazNeWvw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c25-v6si11264073pgl.519.2018.07.24.13.01.20; Tue, 24 Jul 2018 13:01:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=PazNeWvw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388722AbeGXVI3 (ORCPT + 99 others); Tue, 24 Jul 2018 17:08:29 -0400 Received: from mail-lj1-f178.google.com ([209.85.208.178]:43343 "EHLO mail-lj1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388699AbeGXVI3 (ORCPT ); Tue, 24 Jul 2018 17:08:29 -0400 Received: by mail-lj1-f178.google.com with SMTP id r13-v6so4675477ljg.10 for ; Tue, 24 Jul 2018 13:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=afsmkqbzM0laTKBiD5uerJtPWgYnNA5ry00NwSH90a4=; b=PazNeWvwtxTu7j8H9dNTf5PIiaDZFNcSxw/VwrbqNie0QvONvhGxUbkjhNLlAutZaf al2lmz/QANCyWv0jeEijfAZ3qETduIrEnW0Y2kg18WuS7YM4l5KnFaxTFSyCGJnYof3c 3oTmJXGk6iCuFxKXu5OGp+QQpHoXeinjXtD4wD+pZLPcuQBQSSpPlHmqp7m/ycgYNCSw bBvFuL9VDDc44sepKmrHkceRTQRMQ7ZDJNljuV5/KFknXs5djxCZ3+WKPCoZd7ptKE13 gRWcS27YbhUX0Iyf1jaBmWf742KwQIdz6mhNThW6NfWZTwmGaAqLp/ShHXY9hmQM08sD aORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=afsmkqbzM0laTKBiD5uerJtPWgYnNA5ry00NwSH90a4=; b=ogwtCAd6XxH8oBfH+VgfndZb3NuafONEAuNWSQcgkXgWi2SMPe+xNyfTixLdiBa3xE 2jEv62YHUKBmTIn8sBa0fk0zPNAMOPNNXOV23Ga5zoFE2SxpTfNKys0hkKtTcSQ1ZSck yjgcuANhjMbj9isdy++QzR2m1/Jxkv1g1BUSXE1aC9YWVzns+WH4sMeNeqzlqVm/VXP0 IvABrn/edOD5Cdm0X+hd7XE/CWEnyzAto5RWpa+8iYP7iiFLVAiibdOBxpWf1G6m6X1e w4Ta/3+m6JR7TED6z+JWyMyXodCt6YOhZuON4fYbrz1VL24kDa671dSLWYoG2WIgyn+p Ti3Q== X-Gm-Message-State: AOUpUlHUACljDC28Q8fRvnvc2NWCrehvwe1Q4DEsnbfTyp8A3WeRGP/l KYrVK/SwtwoNZqx21SP7+/sWBvBwQ+GQrp4f6/YCuA== X-Received: by 2002:a2e:82cc:: with SMTP id n12-v6mr1446191ljh.58.1532462423805; Tue, 24 Jul 2018 13:00:23 -0700 (PDT) MIME-Version: 1.0 References: <20180718001455.140575-1-rkir@google.com> <20180718001455.140575-3-rkir@google.com> <20180721074611.GC6484@kroah.com> In-Reply-To: <20180721074611.GC6484@kroah.com> From: Roman Kiryanov Date: Tue, 24 Jul 2018 13:00:12 -0700 Message-ID: Subject: Re: [PATCH 3/3] tty: Mark goldfish_tty_line_count as const To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Todd Kjos Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Then why not just make it a #define? With "const" the diff is smaller. > No need to waste the memory of a variable, right? I believe the compiler will produce the same binary for const and for #define if optimization is enabled.