Date: Sun, 21 Sep 2003 22:59:22 +0400
From: Oleg Drokin <green@linuxhacker.ru>
To: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org, greg@kroah.com
Subject: [PATCH] [2.4] devio.c memleak on unexpected disconnect
Message-ID: <20030921185922.GA1185@linuxhacker.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 968
Lines: 26

Hello!

  There is a memleak in devio.c (User space communication with USB devices)
  recently added, it forgets to free the buffer if device was disconnected.

  The patch is trivial, please apply.
  Found with help of smatch.


===== drivers/usb/devio.c 1.17 vs edited =====
--- 1.17/drivers/usb/devio.c	Mon Aug 19 20:49:38 2002
+++ edited/drivers/usb/devio.c	Sun Sep 21 22:51:15 2003
@@ -1114,7 +1114,7 @@
                        usb_driver_release_interface (driver, ifp);
                        up (&driver->serialize);
                } else
-                       return -ENODATA;
+                       retval = -ENODATA;
                break;
 
        /* let kernel drivers try to (re)bind to the interface */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/