Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp229044imm; Tue, 24 Jul 2018 17:52:52 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcmiks/lqnuFNqDbNW9MoNgwvVRfnANxRHWf7XRzJ39R+bMx7kh28qiSHXSZAs70lsKAteF X-Received: by 2002:a63:bf43:: with SMTP id i3-v6mr18440292pgo.342.1532479972029; Tue, 24 Jul 2018 17:52:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532479972; cv=none; d=google.com; s=arc-20160816; b=bbpYiiIpgp+Wri6TN3tuUCKpPQCrcVXXoXvEGyDxWAwlrD9GAhLU2pkyDsostGCttK NIJd9gzkukfay6zvb7qcWIKsmSxNSq4Me7VQGzm0qakOCqaxh+v9ZJKbKDUwLmWyEONm uHt9vfuIETRUjMdq7VUUKHlMZmaaMKX2o9rwXN2shSbkhiO/arcQL8KU2ZvkYVwvBexd QtKm+f2hYS7RErpIC7pYoPk06LU8Dc/C3X+IfI+2dEcuHJ2qG28qP7N29ftnxXTaNWSt Cf7q2uVzpfcIf9U15EFSSXcs8yLil148D0Pr4n7B/xPVPEbAXTP689VouS8cUZYKDvQy fb5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:message-id:date :mime-version:dkim-signature:arc-authentication-results; bh=IXFWQrif5lHpzEaGyI+7rOwxQNASxjZB/sxJ05/r6js=; b=kJ74Tjo22WBn1t+XRNp2hRDtkiH3w7kYWtAXPM0hF4OXfTQbzUYAc9wL4WY7b6lqQo K0Yoku98naoeQUqExxB/bCmP/Z0wT1FC4x3NWg5Ny7D9Ldlb0spr9aPbM8OdqHz7PPw8 gwZi52TtVj4Y2TGu1v4tvYwm1xC3BGYRwnFbD2JoDO88Jpdyl3bIPPELwUoaRoXd+gYH PQwMwOb2F0xK/ZAr4nZvLs8Gwvss3KkxNj4iP0Sg/Qlh81iOVLCSRGVUZaG8elqcSPii PakCjd6FZAB/9rvBTqeGuweQcc9TA+NO9SFkey1VeaaLD7cyYwouHaf8AcnpX++bS8wG T8MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LDWcqJ0l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g27-v6si12123662pgm.208.2018.07.24.17.52.37; Tue, 24 Jul 2018 17:52:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LDWcqJ0l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388497AbeGYCAu (ORCPT + 99 others); Tue, 24 Jul 2018 22:00:50 -0400 Received: from mail-it0-f73.google.com ([209.85.214.73]:35113 "EHLO mail-it0-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388420AbeGYCAu (ORCPT ); Tue, 24 Jul 2018 22:00:50 -0400 Received: by mail-it0-f73.google.com with SMTP id r184-v6so4221784ith.0 for ; Tue, 24 Jul 2018 17:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:date:message-id:subject:from:to:cc; bh=IXFWQrif5lHpzEaGyI+7rOwxQNASxjZB/sxJ05/r6js=; b=LDWcqJ0l7W8ki2dr7nHpmi1rLDW8gjsL6Bjz0ruAhSHQ3mepwfEB247rGoPHzXjVDF +28GC+uJ64f4ZtqrngWclEGo/UurKT/aq8cVjqejsAgtjB0e3FQsiBljcPeoU9HOUHgS VAwoppHAZtcxjO8AZwMzCOAyOxE9NY3NxbMAxE3eEnguwNkYrzLip0N5NsMRRbm9N2+j aHOFtvU8AmgrgRpscSC4KSxbAuQ9A9c0meVZtwq1KxITCigYAtmgE/nxPupALRMT/9oH 88/U/L1zoYdhVoieV5kitgi4b07eMDTK1luY90FlvCgwuiJVhUaQVNokH971sTAhEGtv nc8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc; bh=IXFWQrif5lHpzEaGyI+7rOwxQNASxjZB/sxJ05/r6js=; b=lnRUFES5MmQeL+ikvYHizcJ39BHjb+1Wz+QhHltBvCV+Fx4njSUS2hAbHJlNQOjBOT KLU3YkQNpKR4SKps6R2EbKbJJk7isDEmYQYlmIB+Gvj5ZUsAdPLYQyYlipdjLb1yOhW9 DVkaA2VYloYBg8vccLjnPWqKpYLXIkqqzpLE4DJ93xjH+wMMe+SWieCyd8bRIjmbO5AQ aDrXeZjAdvkgvi4DN8DwBUORsYrPEb6Xj0jH/njhkjUsiEr5BnBk7a+Uk+S0n/vqzEly 64NGb95R78bmh2nEQNH8u6FyE3CRhOw0xbtzfYQ3dyRaV4VG+BCoATNWXNofC2uT1GNw Rc8g== X-Gm-Message-State: AOUpUlEPaLkeByXgLYr248PWxr35G7l3Z7qzdvm24g/uLyyMhdH4L+km vY8pizd5NfJsRRCEB098eouR2nAi MIME-Version: 1.0 X-Received: by 2002:a6b:3805:: with SMTP id f5-v6mr7212046ioa.40.1532479905620; Tue, 24 Jul 2018 17:51:45 -0700 (PDT) Date: Tue, 24 Jul 2018 17:51:31 -0700 Message-Id: <20180725005133.107823-1-rkir@google.com> X-Mailer: git-send-email 2.18.0.233.g985f88cf7e-goog Subject: [PATCH v2 1/3] tty: Address checkpatch warnings in goldfish.c From: rkir@google.com To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Roman Kiryanov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roman Kiryanov checkpatch.pl complained about missing blank lines (between variable definitions and executable code) and using just "unsigned" instead of "unsigned int". Signed-off-by: Roman Kiryanov --- Changes in v2: - Updated the commit message. drivers/tty/goldfish.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index 37caba7c3aff..a92fcb2b0002 100644 --- a/drivers/tty/goldfish.c +++ b/drivers/tty/goldfish.c @@ -172,6 +172,7 @@ static void goldfish_tty_shutdown(struct tty_port *port) static int goldfish_tty_open(struct tty_struct *tty, struct file *filp) { struct goldfish_tty *qtty = &goldfish_ttys[tty->index]; + return tty_port_open(&qtty->port, tty, filp); } @@ -201,11 +202,12 @@ static int goldfish_tty_chars_in_buffer(struct tty_struct *tty) { struct goldfish_tty *qtty = &goldfish_ttys[tty->index]; void __iomem *base = qtty->base; + return readl(base + GOLDFISH_TTY_REG_BYTES_READY); } static void goldfish_tty_console_write(struct console *co, const char *b, - unsigned count) + unsigned int count) { goldfish_tty_do_write(co->index, b, count); } @@ -219,7 +221,7 @@ static struct tty_driver *goldfish_tty_console_device(struct console *c, static int goldfish_tty_console_setup(struct console *co, char *options) { - if ((unsigned)co->index >= goldfish_tty_line_count) + if ((unsigned int)co->index >= goldfish_tty_line_count) return -ENODEV; if (!goldfish_ttys[co->index].base) return -ENODEV; -- 2.18.0.233.g985f88cf7e-goog