Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp244321imm; Tue, 24 Jul 2018 18:13:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcmxQWyxftxfmfYmp2MCnjnEuESV779Mzpevc7W1Tmt6v4UEr7tJQoEM4xuLzRNeHfjMiNr X-Received: by 2002:a17:902:7c89:: with SMTP id y9-v6mr18988654pll.187.1532481208596; Tue, 24 Jul 2018 18:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532481208; cv=none; d=google.com; s=arc-20160816; b=IIGRH9AYBZmzLnEkfMrPCEN1+BObO4iBJVcnDqd0+Adz0jNdoVObcFm77CALYwCDiE OMShPligeDAmFIs74pY+EjLC39eZbyX4H0pfyIDZMHKXxP+XU3xpfbKdxI1F4tFtpqt1 yTv5y+7re8v/pIBKdEwDwExhBsqLcTq6Ga8BlBdpJFP5HjgCUDHZowmfAI8479HPGw0p 9Q6buLXM/LsUQ+nHVP0Tp6faePizOmIUzfN7hEYm084KMxgonqjGwhPTUDFJ5r6hDegw FchU6zMT5bWqSdPD36JnDNJYOQa6rTOm3/+SPBrby8548koVbCajvu+l7QRukWbtIa7b Xcvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=fGbqOH+EULgeKRiOp5smtdPfiiiOF8J8Z/nbw/yEPVg=; b=H4EkMFV8ygxi6q2VDrE+qWTHS17NvhKTbOCxkCH4mcJuzdcZRm3BfuavcZY8eHWx0E /fGNNfUhd5StabzhqaY6zgDk8O+NJp+BxeVcdcMLXAeQfROxFyXtg2qDZrm9CQRBOUok Wqnsw6AMGCJuOjpKdSRtPmfvHJueCLNQa9mjkVLVpBrjqkIW6WW11COlNEBnXU6sp2bI 0dGt7LGBgNxcXhUg/1j2qbyr5loSS8cZwj2nyVFdTreJsZbVSv2RyBMNQjLhnR4gyY6T dk6m5nEi/SpqjA1WzNYrDgfqtXyiM0cWGcjt6y85jnD0Q0TbCTxTC0Htir9OETiL1Pmj DoPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q28-v6si11501445pgm.362.2018.07.24.18.13.11; Tue, 24 Jul 2018 18:13:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388517AbeGYCVa (ORCPT + 99 others); Tue, 24 Jul 2018 22:21:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60768 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388457AbeGYCV3 (ORCPT ); Tue, 24 Jul 2018 22:21:29 -0400 Received: from localhost.localdomain (c-24-4-125-7.hsd1.ca.comcast.net [24.4.125.7]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 0CC8CDC0; Wed, 25 Jul 2018 01:12:20 +0000 (UTC) Date: Tue, 24 Jul 2018 18:12:18 -0700 From: Andrew Morton To: Pavel Tatashin Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com, mhocko@suse.com, linux-mm@kvack.org, dan.j.williams@intel.com, jack@suse.cz, jglisse@redhat.com, jrdr.linux@gmail.com, bhe@redhat.com, gregkh@linuxfoundation.org, vbabka@suse.cz, richard.weiyang@gmail.com, dave.hansen@intel.com, rientjes@google.com, mingo@kernel.org, osalvador@techadventures.net, abdhalee@linux.vnet.ibm.com, mpe@ellerman.id.au Subject: Re: [PATCH 2/3] mm: calculate deferred pages after skipping mirrored memory Message-Id: <20180724181218.13a1ed1d7a3e9a37e35707a9@linux-foundation.org> In-Reply-To: <20180724235520.10200-3-pasha.tatashin@oracle.com> References: <20180724235520.10200-1-pasha.tatashin@oracle.com> <20180724235520.10200-3-pasha.tatashin@oracle.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jul 2018 19:55:19 -0400 Pavel Tatashin wrote: > update_defer_init() should be called only when struct page is about to be > initialized. Because it counts number of initialized struct pages, but > there we may skip struct pages if there is some mirrored memory. What are the runtime effects of this error?