Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   djw@t-chip.com.cn
To:     Heiko Stuebner <heiko@sntech.de>
Cc:     djw@t-chip.com.cn, linux-rockchip@lists.infradead.org,
        Wayne Chou <zxf@t-chip.com.cn>, devicetree@vger.kernel.org,
        Jianqun Xu <jay.xu@rock-chips.com>,
        Jacob Chen <jacob-chen@iotwrt.com>,
        Brian Norris <briannorris@chromium.org>,
        Klaus Goger <klaus.goger@theobroma-systems.com>,
        linux-kernel@vger.kernel.org,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Will Deacon <will.deacon@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v0] arm64: dts: rockchip: add support for ROC-RK3399-PC board
References: <1532161826-2537-1-git-send-email-djw@t-chip.com.cn>
        <139327780.KNaNigg5Hs@phil>
Date:   Wed, 25 Jul 2018 11:57:51 +0800
In-Reply-To: <139327780.KNaNigg5Hs@phil> (Heiko Stuebner's message of "Tue, 24
        Jul 2018 11:28:45 +0200")
Message-ID: <87in54ge68.fsf@archiso.i-did-not-set--mail-host-address--so-tickle-me>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Heiko,

Heiko Stuebner <heiko@sntech.de> writes:
> Hi Levin,
>
> Am Samstag, 21. Juli 2018, 10:30:26 CEST schrieb djw@t-chip.com.cn:
>> From: Levin Du <djw@t-chip.com.cn>
>> 
>> ROC-RK3399-PC is the first power efficient 4GB DDR4 single board
>
> maybe "is a power efficient" instead of "the first" ;-)
>
> [...]
>
ok :)

>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
>> new file mode 100644
>> index 0000000..207f2e3
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
>> @@ -0,0 +1,717 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2017 T-Chip Intelligent Technology Co., Ltd
>> + */
>> +
>> +/dts-v1/;
>> +#include <dt-bindings/pwm/pwm.h>
>> +#include "rk3399.dtsi"
>> +#include "rk3399-opp.dtsi"
>> +
>> +/ {
>> +	model = "Firefly ROC-RK3399-PC Board";
>> +	compatible = "firefly,roc-rk3399-pc", "rockchip,rk3399";
>> +
>> +	chosen {
>> +		bootargs = "earlycon=uart8250,mmio32,0xff1a0000 swiotlb=1";
>
> I don't think we want to hard-code linux bootargs in the generic devicetree
>
removed. though I think that earlycon is useful in debugging.

>> +		stdout-path = "serial2:1500000n8";
>> +	};
>> +
>> +	backlight: backlight {
>> +		compatible = "pwm-backlight";
>> +		enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
>> +		pwms = <&pwm0 0 25000 0>;
>> +		brightness-levels = <
>> +			  0   1   2   3   4   5   6   7
>
> As Rob noted in the px30 evb patch, there is now a property helping
> to drop these long lists of brightness levels, see
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=1e5e7cc794b5a332c23216dade0a2e937d694b7f
adapted. 

>> +			  8   9  10  11  12  13  14  15
>> +			 16  17  18  19  20  21  22  23
>> +			 24  25  26  27  28  29  30  31
>> +			 32  33  34  35  36  37  38  39
>> +			 40  41  42  43  44  45  46  47
>> +			 48  49  50  51  52  53  54  55
>> +			 56  57  58  59  60  61  62  63
>> +			 64  65  66  67  68  69  70  71
>> +			 72  73  74  75  76  77  78  79
>> +			 80  81  82  83  84  85  86  87
>> +			 88  89  90  91  92  93  94  95
>> +			 96  97  98  99 100 101 102 103
>> +			104 105 106 107 108 109 110 111
>> +			112 113 114 115 116 117 118 119
>> +			120 121 122 123 124 125 126 127
>> +			128 129 130 131 132 133 134 135
>> +			136 137 138 139 140 141 142 143
>> +			144 145 146 147 148 149 150 151
>> +			152 153 154 155 156 157 158 159
>> +			160 161 162 163 164 165 166 167
>> +			168 169 170 171 172 173 174 175
>> +			176 177 178 179 180 181 182 183
>> +			184 185 186 187 188 189 190 191
>> +			192 193 194 195 196 197 198 199
>> +			200 201 202 203 204 205 206 207
>> +			208 209 210 211 212 213 214 215
>> +			216 217 218 219 220 221 222 223
>> +			224 225 226 227 228 229 230 231
>> +			232 233 234 235 236 237 238 239
>> +			240 241 242 243 244 245 246 247
>> +			248 249 250 251 252 253 254 255>;
>> +		default-brightness-level = <200>;
>> +	};
>
> [...]
>
>> +	vcc_vbus_typec0: vcc-vbus-typec0 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vcc_vbus_typec0";
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +	};
>> +
>> +	vcc12v_sys: mp8859-dcdc1 {
>
> The mp8859 seems to be an i2c-device, as also shown by the
> nearly empty mp8859 entry below, so shouldn't this regulator
> be defined there?

Question here. Since mp8859 driver is not mainlined yet. Shall I leave
the regulator here (mp8859 defaults to output 5V) and remove the
mp8859 from the i2c?

>
>
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vcc12v_sys";
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		regulator-min-microvolt = <12000000>;
>> +		regulator-max-microvolt = <12000000>;
>> +		vin-supply = <&vcc_vbus_typec0>;
>> +	};
>
> [...]
>
>> +	vcc_hub_en: vcc_hub_en-regulator {
>> +		compatible = "regulator-fixed";
>> +		enable-active-high;
>> +		gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&hub_rst>;
>> +		regulator-name = "vcc_hub_en";
>> +		regulator-always-on;
>
> missing vin-supply
This just comes in need of setting GPIO2_A4 (HUB_RST) to high 
This dummy regulator should be removed.

I modify the pinctrl of hub_rst to output high:

               hub_rst: hub-rst {                                                                                                                 
                        rockchip,pins = <2 RK_PA4 RK_FUNC_GPIO &pcfg_output_high>;                                                                 
               };                                                                                                                                 

and add hub_rst to the pinctrl-0 of vcc5v0_host:

    vcc5v0_host: vcc5v0-host-regulator {                                                                                                       
            compatible = "regulator-fixed";                                                                                                    
            enable-active-high;                                                                                                                
            gpio = <&gpio1 RK_PA0 GPIO_ACTIVE_HIGH>;                                                                                           
            pinctrl-names = "default";                                                                                                         
            pinctrl-0 = <&vcc5v0_host_en &hub_rst>;                                                                                            
            regulator-name = "vcc5v0_host";                                                                                                    
            regulator-always-on;                                                                                                               
            vin-supply = <&vcc_sys>;                                                                                                           
    };

Tested show that it works. But is it the recommended way to set this
 gpio (HUB_RST) high? BTW, vcc5v0_host is the usb host voltage,
 and HUB_RST needs to set high for the usb hub chip to work.

>
>> +	}
>> +
>
> [...]
>
>> +	vdd_cpu_b: regulator@40 {
>> +		compatible = "silergy,syr827";
>> +		reg = <0x40>;
>> +		fcs,suspend-voltage-selector = <1>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&vsel1_gpio>;
>> +		regulator-name = "vdd_cpu_b";
>> +		regulator-min-microvolt = <712500>;
>> +		regulator-max-microvolt = <1500000>;
>> +		regulator-ramp-delay = <1000>;
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		vsel-gpios = <&gpio1 18 gpio_active_high>;
>
> vsel-gpios is not defined in the mainline dt-binding of the fan5355/syr82*
>
removed.

>> +		vin-supply = <&vcc3v3_sys>;
>> +
>> +		regulator-state-mem {
>> +			regulator-off-in-suspend;
>> +		};
>> +	};
>> +
>> +	vdd_gpu: regulator@41 {
>> +		compatible = "silergy,syr828";
>> +		reg = <0x41>;
>> +		fcs,suspend-voltage-selector = <1>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&vsel2_gpio>;
>> +		regulator-name = "vdd_gpu";
>> +		regulator-min-microvolt = <712500>;
>> +		regulator-max-microvolt = <1500000>;
>> +		regulator-ramp-delay = <1000>;
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		vsel-gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>;
>
> same as above
>
removed

>> +		vin-supply = <&vcc3v3_sys>;
>> +
>> +		regulator-state-mem {
>> +			regulator-off-in-suspend;
>> +		};
>> +	};
>> +};
>> +
>> +&i2c1 {
>> +	i2c-scl-rising-time-ns = <300>;
>> +	i2c-scl-falling-time-ns = <15>;
>> +	status = "okay";
>> +};
>> +
>> +&i2c3 {
>> +	i2c-scl-rising-time-ns = <450>;
>> +	i2c-scl-falling-time-ns = <15>;
>> +	status = "okay";
>> +};
>> +
>> +&i2c4 {
>> +	i2c-scl-rising-time-ns = <600>;
>> +	i2c-scl-falling-time-ns = <20>;
>> +	status = "okay";
>> +
>> +	mp8859: mp8859@66 {
>> +		compatible = "mps,mp8859";
>
> missing a dt-binding and also a real regulator implementation?
>
Since this driver is not upstreamed yet. Will remove it.

>> +		reg = <0x66>;
>> +	};
>> +
>> +	fusb1: usb-typec@22 {
>> +		compatible = "fcs,fusb302";
>> +		reg = <0x22>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&fusb1_int>;
>> +		fcs,int-n = <&gpio1 RK_PA1 GPIO_ACTIVE_HIGH>;
>
> mainline binding expects an "interrupts" property not the
> fcs,int-n from above
>
It seems no existing user of fusb302 yet. I take that fcs,int-n
from the driver code. But I look up the binding doc, and come
with this result:

    fusb1: usb-typec@22 {                                                                                                                      
            compatible = "fcs,fusb302";                                                                                                        
            reg = <0x22>;                                                                                                                      
            pinctrl-names = "default";                                                                                                         
            pinctrl-0 = <&fusb1_int>;                                                                                                          
            interrupt-parent = <&gpio1>;                                                                                                       
            interrupts = <1 IRQ_TYPE_LEVEL_LOW>;                                                                                               
            status = "okay";                                                                                                                   
    };                                                                                                                                         


>> +		status = "okay";
>> +	};
>> +
>> +};
>> +
>> +&i2c7 {
>> +	i2c-scl-rising-time-ns = <600>;
>> +	i2c-scl-falling-time-ns = <20>;
>> +	status = "okay";
>> +
>> +	fusb0: usb-typec@22 {
>> +		compatible = "fcs,fusb302";
>> +		reg = <0x22>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&fusb0_int>;
>> +		fcs,int-n = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>;
>
> same as above
>
fixed like above

>> +		status = "okay";
>> +	};
>> +};
>> +
>> +&i2s0 {
>> +	rockchip,playback-channels = <8>;
>> +	rockchip,capture-channels = <8>;
>> +	#sound-dai-cells = <0>;
>
> sound-dai-cells are in rk3399.dtsi now ... see
> https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?id=4486baca66e7a96a6ded3957cb522872a49870ce
>
remove it.

>> +	status = "okay";
>> +};
>> +
>> +&i2s1 {
>> +	rockchip,playback-channels = <2>;
>> +	rockchip,capture-channels = <2>;
>> +	#sound-dai-cells = <0>;
>
> same as above
>
remove it.

>> +	status = "okay";
>> +};
>> +
>> +&i2s2 {
>> +	#sound-dai-cells = <0>;
>
> same as above
>
remove it.

>> +	status = "okay";
>> +};
>> +
>
>> +&tcphy0 {
>> +	extcon = <&fusb0>;
>
> the extcon is not described in the mainline fusb302 binding.
>
remove it.

>> +	status = "okay";
>> +};
>> +
>> +&tcphy1 {
>> +	extcon = <&fusb1>;
>
> same as above
>
remove it.

>> +	status = "okay";
>> +};
>> +
>> +&tsadc {
>> +	/* tshut mode 0:CRU 1:GPIO */
>> +	rockchip,hw-tshut-mode = <1>;
>> +	/* tshut polarity 0:LOW 1:HIGH */
>> +	rockchip,hw-tshut-polarity = <1>;
>> +	status = "okay";
>> +};
>> +
>> +&u2phy0 {
>> +	status = "okay";
>> +
>> +	u2phy0_otg: otg-port {
>> +		phy-supply = <&vcc5v0_host>;
>> +		//status = "disabled";
>
> don't leave commented stuff in the dt please.
>
remove it, sorry for the noise.

>> +		status = "okay";
>> +	};
>> +
>> +	u2phy0_host: host-port {
>> +		phy-supply = <&vcc5v0_host>;
>> +		status = "okay";
>> +	};
>> +};
>> +
>> +&u2phy1 {
>> +	status = "okay";
>> +
>> +	u2phy1_otg: otg-port {
>> +		phy-supply = <&vcc5v0_host>;
>> +		//status = "disabled";
>
> same as above
>
remove it, sorry for the noise.

>> +		status = "okay";
>> +	};
>> +
>> +	u2phy1_host: host-port {
>> +		phy-supply = <&vcc5v0_host>;
>> +		status = "okay";
>> +	};
>> +};
>
>
> Thanks
> Heiko

Thank you very much, Heiko.

Regards,
Levin