Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 25 Jul 2018 06:06:00 +0200
From:   Dominique Martinet <asmadeus@codewreck.org>
To:     piaojun <piaojun@huawei.com>
Cc:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        Eric Van Hensbergen <ericvh@gmail.com>,
        Ron Minnich <rminnich@sandia.gov>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        v9fs-developer@lists.sourceforge.net, groug@kaod.org
Subject: Re: [PATCH] fs/9p/xattr.c: catch the error of p9_client_clunk when
 setting xattr failed
Message-ID: <20180725040600.GA11041@nautica>
References: <5B57EACC.2060900@huawei.com>
 <20180725033200.GA29865@nautica>
 <5B57F564.9070604@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5B57F564.9070604@huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

piaojun wrote on Wed, Jul 25, 2018:
> On 2018/7/25 11:32, Dominique Martinet wrote:
> >>  		p9_client_write(fid, 0, &from, &retval);
> > 
> > I'm not sure what to do about this but it's also possible for
> > p9_client_write to not write the full length without setting and error.
> > 
> > We should probably compare the return value of p9_client_write and
> > value_len to detect short writes and return an error in this case.
> 
> It looks like we could identify short writes error from the *err. If no
> error case breaks the while loop, the total equal to the whole data len.

Ah, I looked too fast and missed the while loop in p9_client_write...
It's rather unusual for such a low level call to handle retries, but I
guess that's 9p.

Right, will take that patch as is then.

Thanks,
-- 
Dominique