Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp513287imm; Wed, 25 Jul 2018 00:58:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcCYkoUc1XyTl9AFowzRW68VDXTtho8EHsLlgF0/VQwQET2MhCa+4E1IIqyIihivd0Plg0M X-Received: by 2002:a63:d401:: with SMTP id a1-v6mr19194649pgh.414.1532505523346; Wed, 25 Jul 2018 00:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532505523; cv=none; d=google.com; s=arc-20160816; b=0GImMhtcjsNvmOOBTe5bfOK5ToXlfsVWJ9c+Dm6h2arirU2ILgJ/HPSIbl44/kgaOJ ValTjM47iTgEg3R3Mms44LOx9PLBXjogLIdyOWv84EliFd3rnXRDy68VR980NROs2TVt h85nRBMsw7ZR/leZdoy4WD7nz3cwprPSEk8W9d90k9sLj0EuAh2VOGodhC2uwI7dQvYE 4FPGdxNSO8yW4mPDkSxO7/xXMtoXuevETYxRlSAkJnE022/iv+aaSWbhJPSJPWWOkhRd WFzA4ELJgbS6wtCQGgSHCyM4UhzV+ksZTNwuj/3ewIbfPaVlNUdC0dD8TX+eiiusj+X9 6L+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=No7Jl+hjOzDiRXZF1Rw1sIcvjpUR+FnrthtsgYQyGvs=; b=DRHoNaYUSwUpqXvDfkKSfzaEdehYuVIHYMFZroTWYEh1sUuUR8StDmz5SHMZ1L1HTl 8xkymw2ylBecS7vtedW4ePSqNeK7WTM94I7e/ahWb5sGFimSObRqkProiD2Bs39oWhPH eKNpOPIkQf9pD8xaND0Frfksgch9rRQS5O5/eJmbp189lTn6pm4bsfqhcnc8UcDuO89v BF7aFuo7Qmj70uap55g2tnXdAJjP0fCrY9ay5jgOwl0se330jIi14PSbC0e1bi3rL5Ei qZ0NIj9XvnNg5iQC74h/DVCyMmIFz94XJYWwDCwBoDD8GdUZZLekq2WQuwlYGBdQz4ty sGjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9-v6si12435267pgk.384.2018.07.25.00.58.27; Wed, 25 Jul 2018 00:58:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbeGYJID (ORCPT + 99 others); Wed, 25 Jul 2018 05:08:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36468 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728441AbeGYJID (ORCPT ); Wed, 25 Jul 2018 05:08:03 -0400 Received: from localhost (LFbn-1-12238-233.w90-92.abo.wanadoo.fr [90.92.53.233]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 12B85AD2; Wed, 25 Jul 2018 07:57:32 +0000 (UTC) Date: Wed, 25 Jul 2018 09:57:29 +0200 From: Greg Kroah-Hartman To: Georgios Tsotsos Cc: devel@driverdev.osuosl.org, James Hogan , linux-kernel@vger.kernel.org, Aaro Koskinen Subject: Re: [PATCH 0/4] Staging: octeon-usb: Fixes and Coding style applied. Message-ID: <20180725075729.GA22990@kroah.com> References: <20180724223853.10198-1-tsotsos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180724223853.10198-1-tsotsos@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 25, 2018 at 01:38:49AM +0300, Georgios Tsotsos wrote: > Hello, > > Previously patches were sent with wrong cover format, please ignore. > > I am sending four patches which trying to resolve TODO list requirements > no 45 about octeon-usb. > There are SPDX licence additions on c and header files. > Checkpatch warnings are resolved,also a notice about CVMX_WAIT_FOR_FIELD32 macro. > It could improve readability and maintenance of this module if function > cvmx_usb_poll_channel() break down (and probably some others too) My same comments hold true for the "no changelog" patches :( thanks, greg k-h