Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [PATCH 09/32] ARM: dts: omap3-gta04: make NAND partitions compatible with recent U-Boot
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20180725080735.GA7467@lenoch>
Date:   Wed, 25 Jul 2018 10:18:28 +0200
Cc:     Marek Belisko <marek@goldelico.com>,
        =?utf-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <EECC7962-DEAB-4C21-98A7-EBAE4AEA312B@goldelico.com>
References: <cover.1532501910.git.hns@goldelico.com> <8dcf3efd3270451314a663c125841ca87ed2b387.1532501910.git.hns@goldelico.com> <20180725080735.GA7467@lenoch>
To:     Ladislav Michl <ladis@linux-mips.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 25.07.2018 um 10:07 schrieb Ladislav Michl <ladis@linux-mips.org>:
>=20
> On Wed, Jul 25, 2018 at 08:58:41AM +0200, H. Nikolaus Schaller wrote:
>> Vendor defined U-Boot has changed the partition scheme a while ago:
>>=20
>> * kernel partition 6MB
>> * file system partition uses the remainder up to end of the NAND
>> * increased size of the environment partition (to get an OneNAND =
compatible base address)
>> * shrink the U-Boot partition
>>=20
>> Let's be compatible (e.g. Debian kernel built from upstream).
>=20
> That, in fact, is breaking compatibility.

With what? Nobody is using the old u-boot partition scheme any more
(it is >5 years old).

> So once you are touching this
> what about relying on partitioning provided by bootloader just to =
prevent
> something like this happening again?

Well, we define what compatible means here (since we are the vendor).
And people complain with us. We simply recommend them to upgrade the
boot-loader.

BR,
Nikolaus

>=20
> 	ladis
>=20
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/arm/boot/dts/omap3-gta04.dtsi | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>=20
>> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi =
b/arch/arm/boot/dts/omap3-gta04.dtsi
>> index 65f77a0b5dd4..03fe404cbf56 100644
>> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
>> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
>> @@ -645,22 +645,22 @@
>>=20
>> 		bootloaders@80000 {
>> 			label =3D "U-Boot";
>> -			reg =3D <0x80000 0x1e0000>;
>> +			reg =3D <0x80000 0x1c0000>;
>> 		};
>>=20
>> -		bootloaders_env@260000 {
>> +		bootloaders_env@240000 {
>> 			label =3D "U-Boot Env";
>> -			reg =3D <0x260000 0x20000>;
>> +			reg =3D <0x240000 0x40000>;
>> 		};
>>=20
>> 		kernel@280000 {
>> 			label =3D "Kernel";
>> -			reg =3D <0x280000 0x400000>;
>> +			reg =3D <0x280000 0x600000>;
>> 		};
>>=20
>> -		filesystem@680000 {
>> +		filesystem@880000 {
>> 			label =3D "File System";
>> -			reg =3D <0x680000 0xf980000>;
>> +			reg =3D <0x880000 0>;	/* 0 =3D =
MTDPART_SIZ_FULL */
>> 		};
>> 	};
>> };
>> --=20
>> 2.12.2
>>=20
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" =
in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html