Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp692180imm; Wed, 25 Jul 2018 04:40:29 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfd1DF0bINeYtJUxJfs2PkAitjXK8TTSH8pWOvWHrFwdimYUm1io3S8KBXZ1zFYyDNGEPa+ X-Received: by 2002:a63:4951:: with SMTP id y17-v6mr20472215pgk.32.1532518829239; Wed, 25 Jul 2018 04:40:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532518829; cv=none; d=google.com; s=arc-20160816; b=CRtjFV6+cLxoYSXx8IArADOroFmOoWovWVcdXXx9YLRLl5TL+Y6t1F6CA7mYu6r4gd hSH24ELGZDonmRRlhCj5kXaTMWwi0mPpblwQ6yolLBvpR3bCjp8ffT9JNJKldH+8Y4oZ QHtmQkJDzUb6fJ10b9PsohwRZsd8I5fWqtk3Jan2dC+bwHMmawMy8oMqDeaAT1bihIL5 dBcmYzcu3n4xy/ntsXA/W2z2l86lM4INU0w6/QyfcTvWDMSKWNUM79JnfdEzFqLqLKoL t7k5qG+4hCGOw7pi6Dkbw4uvR6K77owksq4AZNgGy6zXFVB01ZYkAAT1GQyOVFZCIt2O Suew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=j3v/nFp3fjtc5iMaX/WT3wAaLTVUZizvfKI7Z6OJb78=; b=vnbO+TNUdcxQrnK4MxSkOQ6/xag5AyI9d1X0MXtRNQEW+6Gp+gi6eMFxweUAVqb8G3 ocFEUUczNAsGZMuEE9CO4XNfWcRdBRS80+S66R8cpr0mfZVUbyQWyN9jmAto3gqk+wld BW6CfhKAba4hoBbtLP8+6kdWXNFpiYFiQHtPinG4dRv6zlYmcsnDKPrxIsPxqRBbKW4F 9tlLEe6sKfyU2vJhgYZNNcd2oHVHBAgf1iY9kFjeZevaVNTXiKlMRvgp8R8xWHrOYnrz YV6XSJ7HoDRl/jGZbgzJyyRTYD3M+TreGXuRTBXRlahX8+wt2u4EHVGam4sLt99bUrKH rnAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FnoW5WcL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u134-v6si15114148pfc.244.2018.07.25.04.40.14; Wed, 25 Jul 2018 04:40:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FnoW5WcL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbeGYMt2 (ORCPT + 99 others); Wed, 25 Jul 2018 08:49:28 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39552 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728907AbeGYMt1 (ORCPT ); Wed, 25 Jul 2018 08:49:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=j3v/nFp3fjtc5iMaX/WT3wAaLTVUZizvfKI7Z6OJb78=; b=FnoW5WcL8Y8r7Ty3P8UblbfYW zjQJ+h1ClKnJGY3EQjs/ESzmEJAEPK2/43ctnDiz1Xj6H1r+6rfI5Rn6IYPIV33JBqCwLfKLj1nRT lSZ7YTn/ZIJHKxSwzw/tZVFC6KQxrgH1CnPdsuoKimdL6b9/x/j1gh0bp8nwv4LiV0BD7oiVG9mjh nO3uMCs4vOUwEZ9HCi2Wrg0DU8RcK580iRte7NQLg2/ie4R9uuvDCOkWPMi0eSxUmtSjwTbuL0LFr nNRJHjVll3zwrXQQtf/t+pEJvMFSLU3I0IYuqFxUM6ObWfyGYl1Xj67jTgrlVp3UY+jDEPOeh8Up2 Erk99S7kQ==; Received: from clnet-p19-102.ikbnet.co.at ([83.175.77.102] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fiI7N-0006oF-QK; Wed, 25 Jul 2018 11:38:10 +0000 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] swiotlb: remove a pointless comment Date: Wed, 25 Jul 2018 13:37:57 +0200 Message-Id: <20180725113802.18943-2-hch@lst.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180725113802.18943-1-hch@lst.de> References: <20180725113802.18943-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This comments describes an aspect of the map_sg interface that isn't even exploited by swiotlb. Signed-off-by: Christoph Hellwig --- kernel/dma/swiotlb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 4f8a6dbf0b60..9062b14bc7f4 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -925,12 +925,6 @@ swiotlb_sync_single_for_device(struct device *hwdev, dma_addr_t dev_addr, * appropriate dma address and length. They are obtained via * sg_dma_{address,length}(SG). * - * NOTE: An implementation may be able to use a smaller number of - * DMA address/length pairs than there are SG table elements. - * (for example via virtual mapping capabilities) - * The routine returns the number of addr/length pairs actually - * used, at most nents. - * * Device ownership issues as mentioned above for swiotlb_map_page are the * same here. */ -- 2.18.0