Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp803345imm; Wed, 25 Jul 2018 06:32:30 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeiv+iNqSv181H1m/e2TAMnvGgt6h2Xi4hjji1cJuVmPqmfaUy+HWPIv2AG7gcJLVqpJzef X-Received: by 2002:a62:ea05:: with SMTP id t5-v6mr22164262pfh.228.1532525549966; Wed, 25 Jul 2018 06:32:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532525549; cv=none; d=google.com; s=arc-20160816; b=hOqQ6HGmH38dddhagFoOsZFpNHC4nsXWxxnFM945ik1LvRIepWmqUixexqgUkwLsnX jbfCQC2W6wNF3i+vLG+tc4L4WKkgrEhCpT6jUVa8Lu4aLo0JhCwYGvDBaLdOpOqm/nh9 XeXYJoEdVwTP7d7hXF7c7i8fjBPFnMtbrNDHveRX/j6REFRlIzVVSOFpN93rES0IeU9t kUSEWP2Lng0N8u9B59m4vwDa5P7maq5urladJpEV+G56l/qWTIxm0LLE2HDvqW1byeZz IJriDcxLKXAYSZ+w5pTbIoREf99h3WkKcBHCD4bOrbu+7vvmmSW2o8SHuNFQt0RY3YVc nc2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=Wx/a9GUz+pfbicn3FOf2bFgrCs+XSca0oG6rjsniZQs=; b=JsYZUBhsRV+Irl+E2jDpGo5WL0DnZ2u7FUZPMrEx3Ceqs188XTJ9b5lrydVo1SpEPd bjGhhv0VqNa8FOjBXINZshby7VnKm1RzsdL2t7oEpuXZQO8elIxITF+cX59esH08X1Po NdIn4G0iRJcoTUoVoqG5yLcsQpTrQxt/Uww8etXwmmaMkcVJyIY5NsC5f21QSsOOm11c hgyLofRyR3fRjcVwRBvih8t+GUsa5UnAQdKXOf9yjYMOVJCuWWEG+SXWF+Or+ljgCsoL RUa8kUizVFju/va+oZUnB+nA7RrEnSp8N+AP5jeXzBqsNuyrWqvtNL598697wVuJlEOx eCIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26-v6si12960142pgl.49.2018.07.25.06.32.14; Wed, 25 Jul 2018 06:32:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728998AbeGYOnH (ORCPT + 99 others); Wed, 25 Jul 2018 10:43:07 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50582 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728425AbeGYOnG (ORCPT ); Wed, 25 Jul 2018 10:43:06 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 04AA77721D; Wed, 25 Jul 2018 13:31:25 +0000 (UTC) Received: from redhat.com (ovpn-121-228.rdu2.redhat.com [10.10.121.228]) by smtp.corp.redhat.com (Postfix) with SMTP id 1429110FFE4D; Wed, 25 Jul 2018 13:31:15 +0000 (UTC) Date: Wed, 25 Jul 2018 16:31:08 +0300 From: "Michael S. Tsirkin" To: Anshuman Khandual Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, aik@ozlabs.ru, robh@kernel.org, joe@perches.com, elfring@users.sourceforge.net, david@gibson.dropbear.id.au, jasowang@redhat.com, benh@kernel.crashing.org, mpe@ellerman.id.au, hch@infradead.org, linuxram@us.ibm.com, haren@linux.vnet.ibm.com, paulus@samba.org, srikar@linux.vnet.ibm.com Subject: Re: [RFC 4/4] virtio: Add platform specific DMA API translation for virito devices Message-ID: <20180725162951-mutt-send-email-mst@kernel.org> References: <20180720035941.6844-1-khandual@linux.vnet.ibm.com> <20180720035941.6844-5-khandual@linux.vnet.ibm.com> <20180720160550-mutt-send-email-mst@kernel.org> <3dd36d8e-3bc8-91ba-cf6d-939495439d2c@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3dd36d8e-3bc8-91ba-cf6d-939495439d2c@linux.vnet.ibm.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 25 Jul 2018 13:31:25 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 25 Jul 2018 13:31:25 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 23, 2018 at 07:46:09AM +0530, Anshuman Khandual wrote: > There is a redundant definition of virtio_has_iommu_quirk in the tools > directory (tools/virtio/linux/virtio_config.h) which does not seem to > be used any where. I guess that can be removed without problem. It's there just to make tools/virtio build. Try make -C tools/virtio/ In fact I see there's a missing definition for dma_rmb/dma_wmb there, I'll post a patch. -- MST