Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp919062imm; Wed, 25 Jul 2018 08:20:18 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdbIvqGE+diAR9DMzJ+JvC7TOTIIMVuy7A5ajzEMT5GdD93AFA5qGNigFE/PqhDKRkqZ8le X-Received: by 2002:a17:902:a989:: with SMTP id bh9-v6mr21813484plb.245.1532532018046; Wed, 25 Jul 2018 08:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532532018; cv=none; d=google.com; s=arc-20160816; b=yq1BavB+wGy57CGhItL4+3rKTeJS9AfB/WfCmOMwPdul/Ofnk4lM8E8goMxr+khHsj vvCctDRpnkZgMVB1KYnGwarwpvBvmJwSlTtIubh4c9EWR6OxWF5u3K9N+KodmLxzVj6e OUcpY2cTCG4VouUKmcTkxyeWvBpj0JLlKOZP3eo4gFN0nmoVIt08Y619m8dxCjKWRDZ6 S8Ixs9oOXm4FNoxbNR1iNl5liIZhpWYlRmKCyuz6pnVOZGIvsGtgocXJA4WmmzUnGAsg D6DlwyZwQVPKnw5Nf5fFjHMplrUcygFXDtSriYyU8Lu29O/fTuDFnGaQUkvZMyP2vSLp u7Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=T1W2XgxdIof+RX666dwmxyjqhFl/toLCJCTsLIB6q54=; b=Xa3b2v8eOVn4Ri7pOg9xbaw7NEbdy7CGRT+l3GZkKVI4P6uTnfeW4JUWqpYTKDFw/t HvG+oP9CWNSC8oGtWlRoTz3KPU7b51OclKEuc71N5EixhYxIfwcKZqPsMpXNG3RaGE3+ hmnIMfb0isoagQW1V9JgsHvl8MFLY1u58LQVgtSF5/X06Goeh3MHH0nFPuI+DjHgHrT3 97vypbhB7Kl8j9+fG/HUdHr6WGiZqLi5Cm9nAsaSVYnN51e0sp2pw5L+OgMlApygi1nR r0JWoOUvjKxwNzNfn7dAXMyeU6MEjb6liSDv14FWRFUq8bEJc29ZcN7KymRLs3sLpmL3 R13Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h69-v6si14164553pfc.206.2018.07.25.08.20.02; Wed, 25 Jul 2018 08:20:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728557AbeGYQbT (ORCPT + 99 others); Wed, 25 Jul 2018 12:31:19 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47472 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728341AbeGYQbS (ORCPT ); Wed, 25 Jul 2018 12:31:18 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6PFJAD5102975 for ; Wed, 25 Jul 2018 11:19:10 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ketx2j6aa-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Jul 2018 11:19:10 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jul 2018 11:19:09 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 25 Jul 2018 11:19:05 -0400 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6PFJ48o9109962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Jul 2018 15:19:04 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5EEA8112064; Wed, 25 Jul 2018 11:18:50 -0400 (EDT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 18D5A112061; Wed, 25 Jul 2018 11:18:47 -0400 (EDT) Received: from oc6336877782.ibm.com (unknown [9.80.203.19]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 25 Jul 2018 11:18:46 -0400 (EDT) Subject: Re: [PATCH 6/7] powerpc/traps: Print signal name for unhandled signals To: Murilo Opsfelder Araujo , linux-kernel@vger.kernel.org Cc: Michael Neuling , Simon Guo , Nicholas Piggin , Paul Mackerras , "Eric W . Biederman" , Andrew Donnellan , "Alastair D'Silva" , Sukadev Bhattiprolu , linuxppc-dev@lists.ozlabs.org, Cyril Bur , "Tobin C . Harding" References: <20180724192720.32417-1-muriloo@linux.ibm.com> <20180724192720.32417-7-muriloo@linux.ibm.com> From: Gustavo Romero Date: Wed, 25 Jul 2018 12:19:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180724192720.32417-7-muriloo@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18072515-0072-0000-0000-00000385A31B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009425; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01065968; UDB=6.00547619; IPR=6.00843828; MB=3.00022318; MTD=3.00000008; XFM=3.00000015; UTC=2018-07-25 15:19:08 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18072515-0073-0000-0000-000048D74CAD Message-Id: <0364bdc4-ddf9-85de-1128-8fc8791d63dd@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-25_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=829 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807250164 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Murilo, LGTM. Just a comment: On 07/24/2018 04:27 PM, Murilo Opsfelder Araujo wrote: > This adds a human-readable name in the unhandled signal message. > > Before this patch, a page fault looked like: > > Jul 11 16:04:11 localhost kernel: pandafault[6303]: unhandled signal 11 at 00000000100007d0 nip 000000001000061c lr 00007fff93c55100 code 2 in pandafault[10000000+10000] > > After this patch, a page fault looks like: > > Jul 11 18:14:48 localhost kernel: pandafault[6352]: segfault (11) at 000000013a2a09f8 nip 000000013a2a086c lr 00007fffb63e5100 code 2 in pandafault[13a2a0000+10000] I _really_ don't want to bikeshed here, but I vouch for keeping the "unhandled" word before the signal name, like: [...] pandafault[6352]: unhandled segfault (11) at 000000013a2a09f8 nip [...] because the issue reported here is really that we got a segfault _and_ there was no handler to catch it. But feel free to wait for additional comments to decide it. Cheers, Gustavo