Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <MWHPR02MB2816A41E9C145BC8D89F834AA7540@MWHPR02MB2816.namprd02.prod.outlook.com>
References: <1532519491-19502-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <1532519491-19502-5-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <CAHp75VfM8h9CKXO9bfmF74fcLW68Rs+1514Je=o1jOFd52Uf7A@mail.gmail.com> <MWHPR02MB2816A41E9C145BC8D89F834AA7540@MWHPR02MB2816.namprd02.prod.outlook.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 25 Jul 2018 18:24:37 +0300
Message-ID: <CAHp75VfBYPF5u9e64VMrDfi7yC2XyAwr5qa7ow1Xat5hFq1etQ@mail.gmail.com>
Subject: Re: [PATCH 4/8] usb: dwc3: implement stream transfer timeout
To:     Anurag Kumar Vulisha <anuragku@xilinx.com>
Cc:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>,
        USB <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 25, 2018 at 6:14 PM, Anurag Kumar Vulisha
<anuragku@xilinx.com> wrote:

>>> +/*
>>> + * Timeout value in msecs used by stream_timeout_timer when streams
>>> +are enabled  */
>>> +#define STREAM_TIMEOUT         50
>>
>>Perhaps, STREAM_TIMEOUT_MS 50
>>
>>Dunno about this driver, but it's a usual practice to help reader with understanding
>>code on the first glance.
>>
>
> Since I have mentioned "msecs" in comment above describing the STREAM_TIMEOUT,
> thought it would suffice. But if you feel I should change it, I  will fix it in v2

But you didn't put that comment before each occurrence of this
constant in the code, right?
That's what I'm talking about. If reader looks into the code, there is
no need to understand the order of the value for timeout, since units
are part of the name.

Of course, you may ignore this comment.

-- 
With Best Regards,
Andy Shevchenko