Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp927415imm; Wed, 25 Jul 2018 08:29:29 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdvKyvlsM3vBXxZzWsicrP1Kae0hOnnSnJhe+AfCzEjtgMyx0rw6Z/dD2Oj0ZT2hdtCXFCk X-Received: by 2002:a17:902:b08d:: with SMTP id p13-v6mr22031733plr.0.1532532569318; Wed, 25 Jul 2018 08:29:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532532569; cv=none; d=google.com; s=arc-20160816; b=b/P3WBdbTmmyGHL4Jn93KqVXovkN0c6q3kahReI+mITbd9RRcWskTbD9Gj0n1Vd02f 34eOVJd/NdghsEeaR6su1b2Rwpl0D6m6ZsqrgBORUIZOB6hPaGEfjLJJI2mrfV1YSswP N4wcP73TO9Yi+fRVkXOtHTyIP2nURoW8RVvnrBjIP/NeAwwiBD8rh2dMh3ZunqjquuuR 0SMAowzzgEt5dDaY1d4Zyj4BLx3c8tVFqST2neNyFxrX33Vf+2gZtkgZfcxxJdTdoIeG H6NJsOZkhXWueGwzR+m7qdk8IpwVhtQPzUkYl4E2vy8P4c3Y3GEyVgOkIYysIafw1Gao oG8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=58tkg3WyrisZMa0y69re/Yopb27hA6C9YptAv71Z8vc=; b=Ey1rcKfet8OzHBrDDM9kdgDck43q8XY4Eenp9VAbrIEltpwAvhNSliQrYbfhpO6lhA SHWeT/a7HhDz31VK2yiun7wIP1VZa3+DbbItrgSG0iOyT2G7kSXq9MKLJrjnLBA74YZH RHI53CeigjBfmDHLhgZmEgOFPSZEMQ+Hz8aNbobXhu72I7qyUdeIDHYjOa3jYYpZazOe OOoDaZdDSndvjxAWsVaV5a7eV6h9DhHvKUyfePIyw7ptdVlG/FomdgMBBrFndXlrCfZo 0oOOGHX17yEYNNMib9l0dja1xIyfJzfDQByDdzAsE995fEclz+uqQe/HH96yAzInvVAa 9Z/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=blEnRgQA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l184-v6si14075666pge.257.2018.07.25.08.29.14; Wed, 25 Jul 2018 08:29:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=blEnRgQA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728701AbeGYQjz (ORCPT + 99 others); Wed, 25 Jul 2018 12:39:55 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:35042 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728436AbeGYQjz (ORCPT ); Wed, 25 Jul 2018 12:39:55 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6PFNdOh171140; Wed, 25 Jul 2018 15:27:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=58tkg3WyrisZMa0y69re/Yopb27hA6C9YptAv71Z8vc=; b=blEnRgQAdJMUgUp66TBboMJW1Mx1DDqiCtDSrFyJIerTmgmAUgZqISfTbNnAhWNDTLIh oDNZto9Rm/1n1D9FjQfC4lvE3Jr6MS7PIYWxXroIsqsKVqGgyB8wptVI432+N5JCO8Um 27/g8SiStLK2MY2swiHIBvG234N68QDPEMj3jnWRYLoB5WG1iWwUJSRTch8Pk4ex2n8G IVqAt0pbmmvtEeKIVBfUcYQ/tPLnwrGRWZaWIkOvVuCbl+F/FqoFPRGRVRqL27eqgah4 WSEYnjyNXgP+SKUfQS2SvBpbA3N20Eo/HUi5LTSZwwbt6TNLRuWlYl3zVWHjm3xxOIMq uw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2kbwfpwx95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jul 2018 15:27:32 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6PFRVO8007160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jul 2018 15:27:31 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w6PFRVbc019293; Wed, 25 Jul 2018 15:27:31 GMT Received: from oracle.com (/10.39.227.239) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Jul 2018 08:27:31 -0700 Date: Wed, 25 Jul 2018 11:27:25 -0400 From: Sowmini Varadhan To: "Gustavo A. R. Silva" Cc: Ka-Cheong Poon , Santosh Shilimkar , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rds: send: Fix dead code in rds_sendmsg Message-ID: <20180725152725.GD8870@oracle.com> References: <20180725152227.GA26303@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725152227.GA26303@embeddedor.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8964 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=840 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807250165 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/25/18 10:22), Gustavo A. R. Silva wrote: > Currently, code at label *out* is unreachable. Fix this by updating > variable *ret* with -EINVAL, so the jump to *out* can be properly > executed instead of directly returning from function. > > Addresses-Coverity-ID: 1472059 ("Structurally dead code") > Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") > Signed-off-by: Gustavo A. R. Silva Acked-by: Sowmini Varadhan