Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp990926imm; Wed, 25 Jul 2018 09:32:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfDyLmeRXN5+os8DwMsOCbD1xnKFnEjp1AiPKI+MJg6RqFZVSNjRqZBMIZlnIMEyddUfZa7 X-Received: by 2002:a17:902:9a01:: with SMTP id v1-v6mr22020791plp.20.1532536374304; Wed, 25 Jul 2018 09:32:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532536374; cv=none; d=google.com; s=arc-20160816; b=ye70harP2ThGG/kB5VzKKbx3G8GooWYCUgungVRJDi1+7TLJTOoQtNEJ+R351FIFV3 vHwyOzJC97ocjGUcKRxmgY20VTH9ybmcnO/pcxonj1Is1edgbxgmWh5/G2HNSgCqaxio pJZZJUC8pr5T16pYAJwyMxx2eUoxotX3/yEKjvNqMDWx2eJN3jZM1+IF1pIG277c9BhS s/DyVwp6bNQEyJOoNr1dEZy8oI4AdNsdrQrBdZ6Rmp3NWNDm6jxJ+4rjZOYHF0o6X3fC +J2A7w/hFC0ZcTs4/Az2E6SGxj1Y9YM/Kjmvzxsa2koklUpse8PWgHVJuqhRS7cFm2O3 kNaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature:arc-authentication-results; bh=EaVoYjQdBx9/3lRavseUAcFEV1qkUDTM2ZL7YrB5MV0=; b=GV/aE4qTkf9/q9zY/4pp1AsfC7+OtGz308PfsczujFIM0/4LctL3kJPeJaoitTLqO9 RlFO+bygoq7w3BXIOAXiC3QpRBoBIBAe6NH+lWO81dCwRdrKhkc0/504LjEIf3/nfOIq tvt+9BjUcPyk+t6uV2ugnsfAvFNunsR950FB+CW3g7d6AmQwNyIonhXkK+g64eshaHQH jceavdXqbypNOTwR7o3LUbY3Os1RjlELO5nSSEKodEFD+3GMQdsDvRc6ccXLdJ2ukiyB JK5FCX4hiSlSQk7PE9rZQIWhDzHzjBd4jYH1jrBVh9nOQWnBDZof5/6uCo2km//ht1bP D1WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cfyrnbmq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j67-v6si13590304pgc.186.2018.07.25.09.32.39; Wed, 25 Jul 2018 09:32:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cfyrnbmq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729939AbeGYRnF (ORCPT + 99 others); Wed, 25 Jul 2018 13:43:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:51974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728644AbeGYRnE (ORCPT ); Wed, 25 Jul 2018 13:43:04 -0400 Received: from localhost (unknown [104.132.1.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BCFB5204EC; Wed, 25 Jul 2018 16:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1532536239; bh=EaVoYjQdBx9/3lRavseUAcFEV1qkUDTM2ZL7YrB5MV0=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=CfyrnbmqvNZxw416YJCLQQIvRXEH3YY1KL7I5F7E+J0+90umO+u6EQ3htyDYBVjp9 5Mog09W6uy6wimmU1FdVblp/w0x41wbJFMFKYWtg8YRYVjuQRfpf9wOQDwri55QkBa DUghWGMtpQEYBPNfgYvWitgUKZhLixyHk4q+sfCU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Mikko Perttunen , mturquette@baylibre.com From: Stephen Boyd In-Reply-To: <20180711082104.27955-1-mperttunen@nvidia.com> Cc: leonard.crestez@nxp.com, cyndis@kapsi.fi, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mikko Perttunen References: <20180711082104.27955-1-mperttunen@nvidia.com> Message-ID: <153253623910.48062.11060369743420676475@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH] clk: core: Potentially free connection id Date: Wed, 25 Jul 2018 09:30:39 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Mikko Perttunen (2018-07-11 01:21:04) > Patch "clk: core: Copy connection id" made it so that the connector > id (con_id) is kstrdup_const'ed to cater to drivers that pass non- > constant connection ids. The patch added the corresponding kfree_const > to __clk_free_clk, but struct clk's can be freed also via __clk_put. > Add the kfree_const call to __clk_put and add comments to both > functions to remind that the logic in them should be kept in sync. > = > Fixes: 253160a8ad06 ("clk: core: Copy connection id") > Signed-off-by: Mikko Perttunen > --- Applied to clk-next