Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Rajan Vaja <rajan.vaja@xilinx.com>, mturquette@baylibre.com
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <1531833420-27175-1-git-send-email-rajan.vaja@xilinx.com>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rajan Vaja <rajan.vaja@xilinx.com>
References: <1531833420-27175-1-git-send-email-rajan.vaja@xilinx.com>
Message-ID: <153253683456.48062.11538822357721957211@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH] clk: clk-fixed-factor: Clear OF_POPULATED flag in case of failure
Date:   Wed, 25 Jul 2018 09:40:34 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Rajan Vaja (2018-07-17 06:17:00)
> Fixed factor clock has two initializations at of_clk_init() time
> and during platform driver probe. Before of_clk_init() call,
> node is marked as populated and so its probe never gets called.
> =

> During of_clk_init() fixed factor clock registration may fail if
> any of its parent clock is not registered. In this case, it doesn't
> get chance to retry registration from probe. Clear OF_POPULATED
> flag if fixed factor clock registration fails so that clock
> registration is attempted again from probe.
> =

> Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
> ---
>  drivers/clk/clk-fixed-factor.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> =

> diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-facto=
r.c
> index d72ef2d..f3ae4ff 100644
> --- a/drivers/clk/clk-fixed-factor.c
> +++ b/drivers/clk/clk-fixed-factor.c
> @@ -177,8 +177,15 @@ static struct clk *_of_fixed_factor_clk_setup(struct=
 device_node *node)
> =

>         clk =3D clk_register_fixed_factor(NULL, clk_name, parent_name, fl=
ags,
>                                         mult, div);
> -       if (IS_ERR(clk))
> +       if (IS_ERR(clk)) {
> +               /*
> +                * If parent clock is not registered, registration would =
fail.
> +                * Clear OF_POPULATED flag so that clock registration can=
 be
> +                * attempted again from probe function.
> +                */
> +               of_node_clear_flag(node, OF_POPULATED);
>                 return clk;
> +       }

BTW, this patch was seriously mangled for me so I had to apply it by
hand. Please be more careful next time and consider using something like
git-send-email and git-format-patch to send patches.